From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 39783139694 for ; Thu, 3 Aug 2017 20:56:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 581281FC056; Thu, 3 Aug 2017 20:56:28 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1069D1FC006 for ; Thu, 3 Aug 2017 20:56:26 +0000 (UTC) Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 9E95B341788 for ; Thu, 3 Aug 2017 20:56:25 +0000 (UTC) Received: by mail-it0-f48.google.com with SMTP id h199so3409980ith.0 for ; Thu, 03 Aug 2017 13:56:25 -0700 (PDT) X-Gm-Message-State: AIVw113jAwMNXIAsckbtJGxYul58RI1/YyY+0psCc3/uuPMlD+nFQ9pp 10RiKr8MqUZJuX8J1oocIG0s/amP+Q== X-Received: by 10.36.104.140 with SMTP id v134mr723193itb.11.1501793783626; Thu, 03 Aug 2017 13:56:23 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.107.175.210 with HTTP; Thu, 3 Aug 2017 13:56:03 -0700 (PDT) In-Reply-To: <1501775657.22592.3.camel@gentoo.org> References: <1501775657.22592.3.camel@gentoo.org> From: Mike Gilbert Date: Thu, 3 Aug 2017 16:56:03 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] Allow variable refs in HOMEPAGE To: Gentoo Dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: c48c2a14-af32-48e0-85ff-3bca0e8f7a67 X-Archives-Hash: c86fffe5d4fcb44d781d7a893d9c73ce On Thu, Aug 3, 2017 at 11:54 AM, Micha=C5=82 G=C3=B3rny = wrote: > On czw, 2017-08-03 at 11:33 -0400, Mike Gilbert wrote: >> I would like to remove the ban on variable references in the HOMEPAGE >> variable in ebuilds. >> >> As I understand it, this ban was put in place so that people can >> easily copy/paste from an ebuild to a web browser. >> >> If people want to copy/paste the URL, they can easily query the final >> value using the portage API, or a tool written against it. > > I object! Portage API does not work conveniently for ebuilds scattered > all over the place, or visible through gitweb. > > In fact, I would like to request an opposite motion: I would like to ban > all constant-value variable references unless they give a *very* large > measurable benefit. > > I'm really tired of people who try hard to replace everything with > a variable when it doesn't give any benefit. It only means that: > > - when reviewing multiple ebuilds, I constantly need to look at PN to > figure out whether someone didn't screw up the vars, > > - things are not suitable for straightforward copy-paste for testing, > > - everything falls apart when someone renames the package (either us or > upstream). In particular, it becomes PITA to figure out which ${PN} > represent the upstream name, and which ones strictly refer to the > package name. > > In other words: > > a. P/PV/PF are acceptable because versions change frequently, > > b. PN might be acceptable when used for MY_P and so on, > > c. no variables in HOMEPAGE, EGIT_REPO_URI, constant part of SRC_URI > (so I could at least open the directory containing the file), > > d. no random ${PN} all over the install phase. After thinking about it, I suppose this makes sense. If we can get some agreement to use ${PN} and other static values as little as possible, I can support that. What really doesn't make sense to me is to ban it just for HOMEPAGE, but allow it everywhere else.