From: Mike Gilbert <floppym@gentoo.org>
To: Gentoo Dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] Allow variable refs in HOMEPAGE
Date: Thu, 3 Aug 2017 16:56:03 -0400 [thread overview]
Message-ID: <CAJ0EP408MVcFpBoAqCbzTfehAugtvxPK+jsndiPTbhv6eh0Cdg@mail.gmail.com> (raw)
In-Reply-To: <1501775657.22592.3.camel@gentoo.org>
On Thu, Aug 3, 2017 at 11:54 AM, Michał Górny <mgorny@gentoo.org> wrote:
> On czw, 2017-08-03 at 11:33 -0400, Mike Gilbert wrote:
>> I would like to remove the ban on variable references in the HOMEPAGE
>> variable in ebuilds.
>>
>> As I understand it, this ban was put in place so that people can
>> easily copy/paste from an ebuild to a web browser.
>>
>> If people want to copy/paste the URL, they can easily query the final
>> value using the portage API, or a tool written against it.
>
> I object! Portage API does not work conveniently for ebuilds scattered
> all over the place, or visible through gitweb.
>
> In fact, I would like to request an opposite motion: I would like to ban
> all constant-value variable references unless they give a *very* large
> measurable benefit.
>
> I'm really tired of people who try hard to replace everything with
> a variable when it doesn't give any benefit. It only means that:
>
> - when reviewing multiple ebuilds, I constantly need to look at PN to
> figure out whether someone didn't screw up the vars,
>
> - things are not suitable for straightforward copy-paste for testing,
>
> - everything falls apart when someone renames the package (either us or
> upstream). In particular, it becomes PITA to figure out which ${PN}
> represent the upstream name, and which ones strictly refer to the
> package name.
>
> In other words:
>
> a. P/PV/PF are acceptable because versions change frequently,
>
> b. PN might be acceptable when used for MY_P and so on,
>
> c. no variables in HOMEPAGE, EGIT_REPO_URI, constant part of SRC_URI
> (so I could at least open the directory containing the file),
>
> d. no random ${PN} all over the install phase.
After thinking about it, I suppose this makes sense. If we can get
some agreement to use ${PN} and other static values as little as
possible, I can support that.
What really doesn't make sense to me is to ban it just for HOMEPAGE,
but allow it everywhere else.
next prev parent reply other threads:[~2017-08-03 20:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 15:33 [gentoo-dev] Allow variable refs in HOMEPAGE Mike Gilbert
2017-08-03 15:54 ` Michał Górny
2017-08-03 20:56 ` Mike Gilbert [this message]
2017-08-03 23:10 ` Sam Jorna
2017-08-03 17:21 ` Jonas Stein
2017-08-07 14:05 ` Kent Fredric
2017-08-03 18:21 ` Michael Orlitzky
2017-08-03 18:32 ` Michał Górny
2017-08-03 18:57 ` Mike Gilbert
2017-08-03 19:12 ` Michael Orlitzky
2017-08-03 19:39 ` Mike Gilbert
2017-08-03 19:56 ` Michael Orlitzky
2017-08-03 20:46 ` Mike Gilbert
2017-08-03 22:33 ` Ulrich Mueller
2017-08-04 3:24 ` Michael Orlitzky
2017-08-04 6:50 ` Michał Górny
2017-08-04 13:43 ` Michael Orlitzky
2017-08-04 14:02 ` Peter Stuge
2017-08-04 6:51 ` Ulrich Mueller
2017-08-03 19:39 ` Ulrich Mueller
2017-08-03 19:34 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ0EP408MVcFpBoAqCbzTfehAugtvxPK+jsndiPTbhv6eh0Cdg@mail.gmail.com \
--to=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox