From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-101844-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 4207B158004
	for <garchives@archives.gentoo.org>; Wed, 22 May 2024 15:00:00 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id E4BB72BC019;
	Wed, 22 May 2024 14:59:56 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id A11D0E2AC5
	for <gentoo-dev@lists.gentoo.org>; Wed, 22 May 2024 14:59:56 +0000 (UTC)
Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2e6792ea67fso80892391fa.1
        for <gentoo-dev@lists.gentoo.org>; Wed, 22 May 2024 07:59:55 -0700 (PDT)
X-Gm-Message-State: AOJu0Yyixer8Bt+vuzZeJRVtKwAPjZZ0pkbfBURyf5DJqQ8hPBSa9A1P
	W26gynDOH4p9Tvm+Qi+FjTH8ynbvbgBeFutYfVYs3TqPElRt6fGMjHlANyJT0slF5NoOWUnaABc
	xf79LeoFT053nnhD0vwaxpi2KeZ8=
X-Google-Smtp-Source: AGHT+IEvvFQHBd3VwN8vKjQnO+Ri84PgqTeEbhn83RfCwHKwyXktV3fLYGEjIIrIsaapMauhYs94HG22S71tPl+C+l4=
X-Received: by 2002:a2e:8ec7:0:b0:2e9:48db:353a with SMTP id
 38308e7fff4ca-2e9496645camr13405501fa.53.1716389990732; Wed, 22 May 2024
 07:59:50 -0700 (PDT)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
References: <20240522015830.1841810-1-floppym@gentoo.org> <20240522020519.1845786-1-floppym@gentoo.org>
 <246638361b9afd85bcb42aad0f710a29e1b773a2.camel@gentoo.org>
In-Reply-To: <246638361b9afd85bcb42aad0f710a29e1b773a2.camel@gentoo.org>
From: Mike Gilbert <floppym@gentoo.org>
Date: Wed, 22 May 2024 10:59:39 -0400
X-Gmail-Original-Message-ID: <CAJ0EP40+sMWWW50cS-_dhVQ6m6edQ8g7=LcK=emHhi=Y1eSY0g@mail.gmail.com>
Message-ID: <CAJ0EP40+sMWWW50cS-_dhVQ6m6edQ8g7=LcK=emHhi=Y1eSY0g@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack
 on sig files
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 287810b8-c990-4ea2-9783-4cd047ed8292
X-Archives-Hash: c528e20e4d8d32566585190901bb1b12

On Tue, May 21, 2024 at 11:38=E2=80=AFPM Micha=C5=82 G=C3=B3rny <mgorny@gen=
too.org> wrote:
>
> On Tue, 2024-05-21 at 22:05 -0400, Mike Gilbert wrote:
> > Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> > ---
> >  eclass/verify-sig.eclass | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
> > index b74ed78290aa..4d48c9ed8503 100644
> > --- a/eclass/verify-sig.eclass
> > +++ b/eclass/verify-sig.eclass
> > @@ -426,10 +426,14 @@ verify-sig_src_unpack() {
> >                       verify-sig_verify_detached \
> >                               "${DISTDIR}/${f%.*}" "${DISTDIR}/${f}"
> >               done
> > -     fi
> >
> > -     # finally, unpack the distfiles
> > -     default_src_unpack
> > +             # finally, unpack the distfiles
> > +             if [[ ${#distfiles[@]} -gt 0 ]]; then
> > +                     unpack "${distfiles[@]}"
> > +             fi
> > +     else
> > +             default_src_unpack
> > +     fi
> >  }
> >
> >  fi
>
> Please make a pull request or send a patch with more context.
> As submitted, this patch is completely unreadable.

Sure, I updated the commit message per ulm's comments, and opened a PR.

https://github.com/gentoo/gentoo/pull/36776