Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files

[Mike Gilbert <floppym@gentoo.org>]

On Tue, May 21, 2024 at 11:38 PM Michał Górny <mgorny@gentoo.org> wrote:
>
> On Tue, 2024-05-21 at 22:05 -0400, Mike Gilbert wrote:
> > Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> > ---
> >  eclass/verify-sig.eclass | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
> > index b74ed78290aa..4d48c9ed8503 100644
> > --- a/eclass/verify-sig.eclass
> > +++ b/eclass/verify-sig.eclass
> > @@ -426,10 +426,14 @@ verify-sig_src_unpack() {
> >                       verify-sig_verify_detached \
> >                               "${DISTDIR}/${f%.*}" "${DISTDIR}/${f}"
> >               done
> > -     fi
> >
> > -     # finally, unpack the distfiles
> > -     default_src_unpack
> > +             # finally, unpack the distfiles
> > +             if [[ ${#distfiles[@]} -gt 0 ]]; then
> > +                     unpack "${distfiles[@]}"
> > +             fi
> > +     else
> > +             default_src_unpack
> > +     fi
> >  }
> >
> >  fi
>
> Please make a pull request or send a patch with more context.
> As submitted, this patch is completely unreadable.

Sure, I updated the commit message per ulm's comments, and opened a PR.

https://github.com/gentoo/gentoo/pull/36776