public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group
@ 2012-07-20  8:32 Michael Weber
  2012-07-20 10:18 ` Maxim Kammerer
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Weber @ 2012-07-20  8:32 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

is it intentional behavior, that home directories created by enewuser
belong to $user:root (or pwd group) instead of $user:$group ?

I recently set net-misc/minidlna to run as non-root and ended up with
minidlna:minidlna, see [1] for implementation details (and my
workaround) and [2,3] for the discussion leading to the situation.

p.s. I aware that chown/chmod and missing ${EPREFIX} makes this a bad
hack and fails on Prefix.

Michael

[2] https://bugs.gentoo.org/394373
[3] https://bugs.gentoo.org/426726

- --
Gentoo Dev
http://xmw.de/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iF4EAREIAAYFAlAJF5YACgkQknrdDGLu8JAoQQD/U2vrcw/bOuGtmcKelM7gbfh9
aV+Nqk89M7re+gYLhY8A/RLSaNztCvQ+ti/ZYeETDEcui7wmT1kEuilxjwz1RrPV
=9ogI
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group
  2012-07-20  8:32 [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group Michael Weber
@ 2012-07-20 10:18 ` Maxim Kammerer
  2012-07-20 15:23   ` Ian Stakenvicius
  0 siblings, 1 reply; 6+ messages in thread
From: Maxim Kammerer @ 2012-07-20 10:18 UTC (permalink / raw
  To: gentoo-dev

On Fri, Jul 20, 2012 at 11:32 AM, Michael Weber <xmw@gentoo.org> wrote:
> is it intentional behavior, that home directories created by enewuser
> belong to $user:root (or pwd group) instead of $user:$group ?

This seems like the result of a hasty bugfix to me:
  https://bugs.gentoo.org/23627
  http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/eutils.eclass?r1=1.36&r2=1.37

Wrong group ownership shouldn't matter much, since ebuilds should
probably explicitly set home directory ownership / permissions with
fowners / fperms anyway (in src_install()). However, that doesn't work
due to:
  https://bugs.gentoo.org/396153

Having a switch for enewuser to skip creating home directory would
solve the issue for majority of usecases, but a request I opened was
resolved as a duplicate of the bug above (which I don't expect to be
resolved anytime soon):
  https://bugs.gentoo.org/395961

-- 
Maxim Kammerer
Liberté Linux: http://dee.su/liberte



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group
  2012-07-20 10:18 ` Maxim Kammerer
@ 2012-07-20 15:23   ` Ian Stakenvicius
  2012-07-20 16:44     ` Maxim Kammerer
  0 siblings, 1 reply; 6+ messages in thread
From: Ian Stakenvicius @ 2012-07-20 15:23 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 20/07/12 06:18 AM, Maxim Kammerer wrote:
> On Fri, Jul 20, 2012 at 11:32 AM, Michael Weber <xmw@gentoo.org>
> wrote:
>> is it intentional behavior, that home directories created by
>> enewuser belong to $user:root (or pwd group) instead of
>> $user:$group ?
> 
> This seems like the result of a hasty bugfix to me: 
> https://bugs.gentoo.org/23627 
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/eutils.eclass?r1=1.36&r2=1.37
>
>  Wrong group ownership shouldn't matter much, since ebuilds should 
> probably explicitly set home directory ownership / permissions
> with fowners / fperms anyway (in src_install()). However, that
> doesn't work due to: https://bugs.gentoo.org/396153
> 
> Having a switch for enewuser to skip creating home directory would 
> solve the issue for majority of usecases, but a request I opened
> was resolved as a duplicate of the bug above (which I don't expect
> to be resolved anytime soon): https://bugs.gentoo.org/395961
> 

enewuser won't create a home directory if you don't specify one (ie
it's set to /dev/null or it's unset).  Also, you can use 'esethome' to
set the home directory to an existing directory.  With both of these
options I don't think that a --do-not-create-homedir option is necessary.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iF4EAREIAAYFAlAJd+YACgkQ2ugaI38ACPDmLgD8C/CifrMost6b5cYVZn3R+FnU
K3Qf6Tp85S/gSPT7fC0A/ikEDaKGQxqainhzWRfl0fyyb6MSRZphzcz+uwb+Y/1t
=yFDr
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group
  2012-07-20 15:23   ` Ian Stakenvicius
@ 2012-07-20 16:44     ` Maxim Kammerer
  2012-07-22  1:22       ` Michael Weber
  0 siblings, 1 reply; 6+ messages in thread
From: Maxim Kammerer @ 2012-07-20 16:44 UTC (permalink / raw
  To: gentoo-dev

On Fri, Jul 20, 2012 at 6:23 PM, Ian Stakenvicius <axs@gentoo.org> wrote:
> enewuser won't create a home directory if you don't specify one (ie
> it's set to /dev/null or it's unset).  Also, you can use 'esethome' to
> set the home directory to an existing directory.  With both of these
> options I don't think that a --do-not-create-homedir option is necessary.

Well, with this approach there will now be three separate code blocks,
just to create user's home directory: enewuser in pkg_preinst(),
fperms / fowners in src_install(), and esethome in pkg_postinst().
Changing permissions as suggested by Kevin Pyle [1] looks more
attractive then, since everything is in one code block. Moreover, if
you want to keep the same semantics with esethome (only set the home
directory when the user is created), you will need to keep a variable
across ebuild phases. Also, it looks like pkg_postinst() is on the way
out [2]. All-in-all, I think that a --do-not-create-homedir (or a
shorter equivalent) is a good idea.

[1] https://bugs.gentoo.org/show_bug.cgi?id=395961#c1
[2] http://archives.gentoo.org/gentoo-dev/msg_ed43ed0df212ea26ef953fb061e9e860.xml

-- 
Maxim Kammerer
Liberté Linux: http://dee.su/liberte



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group
  2012-07-20 16:44     ` Maxim Kammerer
@ 2012-07-22  1:22       ` Michael Weber
  2012-07-22  1:45         ` Maxim Kammerer
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Weber @ 2012-07-22  1:22 UTC (permalink / raw
  To: gentoo-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 07/20/2012 06:44 PM, Maxim Kammerer wrote:
> I think that a --do-not-create-homedir (or a shorter equivalent) is
> a good idea.

Yeah, just allow optional arguments to useradd like (useradd --help)
  -m, --create-home             create the user's home directory
  -M, --no-create-home          do not create the user's home directory

I would prefer an behavior similar to regular `useradd -m -g $group`
calls.

- --
Gentoo Dev
http://xmw.de/


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iF4EAREIAAYFAlALVegACgkQknrdDGLu8JCucAD9GN0ZSVQxoTSkf+usb+9aybpH
Q1Sa8MJck/QXhzj+BPEBAISzuqa4sM/+eh3PJEBJ3JwtVNwrNWhLv0eRiF9sWiz5
=zYTB
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group
  2012-07-22  1:22       ` Michael Weber
@ 2012-07-22  1:45         ` Maxim Kammerer
  0 siblings, 0 replies; 6+ messages in thread
From: Maxim Kammerer @ 2012-07-22  1:45 UTC (permalink / raw
  To: gentoo-dev

On Sun, Jul 22, 2012 at 4:22 AM, Michael Weber <xmw@gentoo.org> wrote:
> Yeah, just allow optional arguments to useradd like (useradd --help)
>   -m, --create-home             create the user's home directory
>   -M, --no-create-home          do not create the user's home directory

IIRC, enewuser allowed extra arguments to useradd previously —
however, this feature was removed, probably because enewuser-like
functions are supposed to be multi-platform. I think that -M didn't
work even back then, since home directory is created explicitly by
enewuser.

-- 
Maxim Kammerer
Liberté Linux: http://dee.su/liberte


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-07-22  1:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20  8:32 [gentoo-dev] enewuser: home beloning $user:root inset of $user:$group Michael Weber
2012-07-20 10:18 ` Maxim Kammerer
2012-07-20 15:23   ` Ian Stakenvicius
2012-07-20 16:44     ` Maxim Kammerer
2012-07-22  1:22       ` Michael Weber
2012-07-22  1:45         ` Maxim Kammerer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox