[gentoo-dev] RFC: change of the default value for EHG_REVISION (mercurial.eclass)

[gentoo-dev] RFC: change of the default value for EHG_REVISION (mercurial.eclass)

[Christoph Junghans]

With nelchael's retirement I (with backup from djc) will take over the
maintenance of mercurial.eclass. As one of the first things I would
like to change the default value of EHG_REVISION.

EHG_REVISION defines the revision/branch/tag to be checkout in src_unpack.
The current default is "tip", which identifies the most recent revision.
This can lead to unwanted branch changes (see
<https://bugs.gentoo.org/show_bug.cgi?id=380947#c16>) as the branch in
which tip resides is not fixed.
The new default should be "default", which is mercurial's default name
for the main branch.

Looking at the packages using mercurial.eclass
(<http://qa-reports.gentoo.org/output/eclass-usage/mercurial.txt>) the
above change shouldn't cause any problems (some packages already use
EHG_REVISION="default" to avoid branch changes), but I will wait
another week before committing the change.

--
Christoph Junghans
http://dev.gentoo.org/~ottxor/

Re: [gentoo-dev] RFC: change of the default value for EHG_REVISION (mercurial.eclass)

[Mike Gilbert]

On Tue, Dec 18, 2012 at 4:10 PM, Christoph Junghans <ottxor@gentoo.org> wrote:
> With nelchael's retirement I (with backup from djc) will take over the
> maintenance of mercurial.eclass. As one of the first things I would
> like to change the default value of EHG_REVISION.
>
> EHG_REVISION defines the revision/branch/tag to be checkout in src_unpack.
> The current default is "tip", which identifies the most recent revision.
> This can lead to unwanted branch changes (see
> <https://bugs.gentoo.org/show_bug.cgi?id=380947#c16>) as the branch in
> which tip resides is not fixed.
> The new default should be "default", which is mercurial's default name
> for the main branch.
>
> Looking at the packages using mercurial.eclass
> (<http://qa-reports.gentoo.org/output/eclass-usage/mercurial.txt>) the
> above change shouldn't cause any problems (some packages already use
> EHG_REVISION="default" to avoid branch changes), but I will wait
> another week before committing the change.
>
> --
> Christoph Junghans
> http://dev.gentoo.org/~ottxor/
>

Sounds good to me; using "tip" never made sense to me either.

Re: [gentoo-dev] RFC: change of the default value for EHG_REVISION (mercurial.eclass)

[Rafael Goncalves Martins]

On Tue, Dec 18, 2012 at 7:31 PM, Mike Gilbert <floppym@gentoo.org> wrote:
> On Tue, Dec 18, 2012 at 4:10 PM, Christoph Junghans <ottxor@gentoo.org> wrote:
>> With nelchael's retirement I (with backup from djc) will take over the
>> maintenance of mercurial.eclass. As one of the first things I would
>> like to change the default value of EHG_REVISION.
>>
>> EHG_REVISION defines the revision/branch/tag to be checkout in src_unpack.
>> The current default is "tip", which identifies the most recent revision.
>> This can lead to unwanted branch changes (see
>> <https://bugs.gentoo.org/show_bug.cgi?id=380947#c16>) as the branch in
>> which tip resides is not fixed.
>> The new default should be "default", which is mercurial's default name
>> for the main branch.
>>
>> Looking at the packages using mercurial.eclass
>> (<http://qa-reports.gentoo.org/output/eclass-usage/mercurial.txt>) the
>> above change shouldn't cause any problems (some packages already use
>> EHG_REVISION="default" to avoid branch changes), but I will wait
>> another week before committing the change.
>>
>> --
>> Christoph Junghans
>> http://dev.gentoo.org/~ottxor/
>>
>
> Sounds good to me; using "tip" never made sense to me either.
>

+1

--
Rafael Goncalves Martins
Gentoo Linux developer
http://rafaelmartins.eng.br/