From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id BE7871389AE for ; Mon, 11 Feb 2013 22:48:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 11C0C21C008; Mon, 11 Feb 2013 22:48:52 +0000 (UTC) Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com [209.85.223.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0EA2CE0205 for ; Mon, 11 Feb 2013 22:48:50 +0000 (UTC) Received: by mail-ie0-f175.google.com with SMTP id c12so8443131ieb.34 for ; Mon, 11 Feb 2013 14:48:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding :x-gm-message-state; bh=kqh4X4zH8bbSWXH4PrzQ9p9pMXBN+H6cSBVDUTM7ToM=; b=chIPm0CFBRnl8jOageB7PURCzp7jzPYBl0sdWtY8cDlj+Df41zviZqv1RG0CRLeN5R CpQHXc1VLiwhHGVf3LvnNc1TNNVI9onj8dP40rpkxyx8WEm2IHtxXvDbW3AM6ZOo1WAT GRoI/f8WanFGKhK7UAEJ+E2i08OZ+H7tP+DykAjdZPQjIilIB9cBGWb9QSr2YVowkj0K wN4HzJxeLFoo8I9ZLmNTTgJVy0d7fscI4AdrBu3fmnDyiWQ9Hu3m1CIpzhCrOzg/p6AI GaFZdP1LdXx5MQWFZC7Fu8QpE4I2sy+PWRVWjEWktDu9pX+a/Scbx6uzxynedWYPuJqB gsbg== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.50.222.195 with SMTP id qo3mr14671428igc.14.1360622930085; Mon, 11 Feb 2013 14:48:50 -0800 (PST) Received: by 10.64.33.15 with HTTP; Mon, 11 Feb 2013 14:48:49 -0800 (PST) In-Reply-To: <1360620883-22562-1-git-send-email-mgorny@gentoo.org> References: <1360620883-22562-1-git-send-email-mgorny@gentoo.org> Date: Mon, 11 Feb 2013 23:48:49 +0100 Message-ID: Subject: Re: [gentoo-dev] [RFC/PATCH] A cleaner API for virtualx.eclass From: =?UTF-8?Q?Diego_Elio_Petten=C3=B2?= To: "gentoo-dev@lists.gentoo.org" Cc: x11@gentoo.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQnZco/loCS9XTJq9EyaoWE6yoR+jTTJcL4D9jGLU7PJvRpyPKILvU4CClsI+BUwfiYaDv4S X-Archives-Salt: b1dbf96a-23c7-47e6-8a6f-b08c01254cf3 X-Archives-Hash: 5bfdd6cae3025abe38adde44c4972faa I'd say, "Go for it!" But on the other hand I wonder if it might make sense to have something more generic, so that one only has to call something in a way such as virtualx_setup run_tests --foo virtualx_cleanup The reason why I'm wondering this is that we need some more "virtual environments" for testing purposes, really: so many packages need a D-Bus session (and I'd rather have them using a test session than a system one!), and at least in Ruby world we often need a database (sometimes more than one)... Diego Elio Petten=C3=B2 =E2=80=94 Flameeyes flameeyes@flameeyes.eu =E2=80=94 http://blog.flameeyes.eu/ On Mon, Feb 11, 2013 at 11:14 PM, Micha=C5=82 G=C3=B3rny wrote: > Hello, fellow developers, > > The current virtualx.eclass API is a bit insane. It seems a bit like > stacking of a few next APIs, mostly designed to quickly run 'make > check', then extended to general functions. > > For example running a function 'run_tests' with parameter '--foo' would > look like: > > VIRTUALX_COMMAND=3Drun_tests virtualmake --foo > > which is really awful, considering that '--foo' is a parameter to > 'run_tests' and not virtualmake. > > My patches introduce a single wrapper with argv-as-parameter syntax. > That is, the fore-mentioned example would look like: > > virtualx run_tests --foo > > Depending on the maintainer decisions and your feedback, I believe that > even all the X* short-hand functions could be deprecated. They are a bit > shorter: > > Xemake check > > vs: > > virtualx emake check > > but I don't think that's much of a difference. > > What are your thoughts? > >