public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: TOMAS FABRIZIO ORSI <torsi@fi.uba.ar>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Eselect repository feature request
Date: Wed, 21 Jun 2023 11:12:55 -0300	[thread overview]
Message-ID: <CAHTSwYg4rrtLE=7UEmS8WnLqxLs0qEP9+_tFqsviu1_9=c24VQ@mail.gmail.com> (raw)
In-Reply-To: <92ac9bbb-7c82-115d-fd70-298ef39ef5a7@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 3212 bytes --]

>
> I just checked the internal overlays team guide[1] and it does
> explicitly say that repo_name should match the repositories.xml <name>.

Oh, great news then. Thanks for checking. Also thank you overlays team!

That being said it is possible for the
> owner to change repo_name and (accidentally) not update
> repositories.xml. These cases should be fixed but exactly how would have
> to be determined on a case by case basis.
>
That is true, however I think those are "edge" cases. Furthermore, how
often do
people change their overlay's name? I legitimately do not know.

In any case, this is just something to keep in mind when writing this
> check. It is not fully guaranteed that eselect repository can find the
> repository that is requested in some master= entry.
>
Great point.
Btw, in your opinion, do you think having this emerge --sync + eselect
repository feature is doable?

Best regards,
- Tomas Fabrizio Orsi


El mié, 21 jun 2023 a las 10:58, Andrew Ammerlaan (<
andrewammerlaan@gentoo.org>) escribió:

> On 21/06/2023 15:40, TOMAS FABRIZIO ORSI wrote:
> >     What I meant is that emerge --sync/eix --sync does this check
> >     instead of
> >     eselect repository. To me this makes sense since we can only do this
> >     check *after* syncing.
> >
> > That is a great point; I had not considered it.
> > So, you are saying to have emerge --sync/eix --sync check the masters
> > key and then warn the user of not synced up overlays, correct?
>
> Yes
>
> >     This however would require
> >     that profiles/repo_name is always equal to the name entry in
> >     repositories.xml, I'm not sure if this is currently always the case.
> >
> > I had not considered this possibility either.
> > If that's the case, then I believe there are to possible behaviors:
> > If the names do match, then emerge --sync/eix --sync could both:
> >       1. issue a warning of the missing overlay dependency
> >       2. run the command to add said overlay (with confirmation).
> > On the other hand, if the names do not match, a missing dependency
> warning
> > could be issued, skipping the second step.
> > This sounds to me to be fairly reasonable behaviour.
> >
> > In the cases where the names do not match; what could be the best
> > solution to "fix" this? Change repositories.xml on a case by case basis?
> > Ask overlay owners to change their profiles/repo_name and
> > profiles/masters key? Neither?
>
> I just checked the internal overlays team guide[1] and it does
> explicitly say that repo_name should match the repositories.xml <name>.
> So probably there is no problem. That being said it is possible for the
> owner to change repo_name and (accidentally) not update
> repositories.xml. These cases should be fixed but exactly how would have
> to be determined on a case by case basis.
>
> In any case, this is just something to keep in mind when writing this
> check. It is not fully guaranteed that eselect repository can find the
> repository that is requested in some master= entry.
>
> Best regards,
> Andrew
>
> [1]
> https://wiki.gentoo.org/wiki/Project:Overlays/Internal_Overlays_team_guide
>
>
>

[-- Attachment #2: Type: text/html, Size: 4467 bytes --]

  reply	other threads:[~2023-06-21 14:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-18 20:39 [gentoo-dev] Eselect repository feature request TOMAS FABRIZIO ORSI
2023-06-20 13:44 ` Florian Schmaus
2023-06-20 14:41   ` TOMAS FABRIZIO ORSI
2023-06-20 17:08     ` Florian Schmaus
2023-06-20 17:26       ` Mike Gilbert
2023-06-20 18:07         ` Andrew Ammerlaan
2023-06-21  2:17           ` TOMAS FABRIZIO ORSI
2023-06-21  7:15             ` Andrew Ammerlaan
2023-06-21 13:40               ` TOMAS FABRIZIO ORSI
2023-06-21 13:58                 ` Andrew Ammerlaan
2023-06-21 14:12                   ` TOMAS FABRIZIO ORSI [this message]
2023-06-21 14:30                     ` Andrew Ammerlaan
2023-06-21 14:43                       ` TOMAS FABRIZIO ORSI
2023-06-21 15:07                         ` Mike Gilbert
2023-06-21 15:34                           ` TOMAS FABRIZIO ORSI
2023-06-21 15:41         ` Florian Schmaus
2023-06-21 15:56           ` Mike Gilbert
2023-06-21 16:47             ` TOMAS FABRIZIO ORSI
2023-06-21 17:45               ` Mike Gilbert
2023-06-21 17:59                 ` TOMAS FABRIZIO ORSI
2023-06-24 17:02                   ` Florian Schmaus
     [not found]                   ` <8ef315e8-a9fe-c33a-7ab4-ef7653c10cb9@gentoo.org>
     [not found]                     ` <CAHTSwYiXiO2OMU4A5TiunrEy+Zs+UMFwoV3wmSdEW5RNrS5xJA@mail.gmail.com>
     [not found]                       ` <CAHTSwYgO7F2gOOSWHDOBFry4YBb1a1KSy9g8h4iUh+rK0GFRuQ@mail.gmail.com>
     [not found]                         ` <2d264617-f48e-d129-adc2-10aac6cef2a2@gentoo.org>
2023-07-12 18:03                           ` TOMAS FABRIZIO ORSI
2023-06-21 17:59                 ` Anna
2023-06-21 16:49             ` Florian Schmaus
2023-06-21 17:28               ` Mike Gilbert
2023-06-21 18:42               ` Sam James
2023-06-21 19:03                 ` TOMAS FABRIZIO ORSI
2023-06-21 19:16                   ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHTSwYg4rrtLE=7UEmS8WnLqxLs0qEP9+_tFqsviu1_9=c24VQ@mail.gmail.com' \
    --to=torsi@fi.uba.ar \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox