* [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage.
@ 2019-09-27 19:31 Manoj Gupta
2019-09-27 19:48 ` Brian Evans
0 siblings, 1 reply; 3+ messages in thread
From: Manoj Gupta @ 2019-09-27 19:31 UTC (permalink / raw
To: gentoo-dev; +Cc: Manoj Gupta
sys-libs/db-18.1.32 can builds without "--default-symver"
linker flag. This fixes the build issue when using LLD linker
which does not support this flag.
Given that sys-libs/db is the only Gentoo package using
"--default-symver" linker, it is probably not a terrible idea to
drop use of "--default-symver" flag.
Signed-off-by: Manoj Gupta <manojgupta@google.com>
---
sys-libs/db/{db-18.1.32.ebuild => db-18.1.32-r1.ebuild} | 6 ------
1 file changed, 6 deletions(-)
rename sys-libs/db/{db-18.1.32.ebuild => db-18.1.32-r1.ebuild} (97%)
diff --git a/sys-libs/db/db-18.1.32.ebuild b/sys-libs/db/db-18.1.32-r1.ebuild
similarity index 97%
rename from sys-libs/db/db-18.1.32.ebuild
rename to sys-libs/db/db-18.1.32-r1.ebuild
index be515fd043e..c23babeb9d9 100644
--- a/sys-libs/db/db-18.1.32.ebuild
+++ b/sys-libs/db/db-18.1.32-r1.ebuild
@@ -146,12 +146,6 @@ multilib_src_configure() {
is-flagq -O[s123] || append-flags -O2
fi
- # Add linker versions to the symbols. Easier to do, and safer than header file
- # mumbo jumbo.
- if use userland_GNU ; then
- append-ldflags -Wl,--default-symver
- fi
-
# use `set` here since the java opts will contain whitespace
if multilib_is_native_abi && use java ; then
myconf+=(
--
2.23.0.444.g18eeb5a265-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage.
2019-09-27 19:31 [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage Manoj Gupta
@ 2019-09-27 19:48 ` Brian Evans
2019-09-27 19:54 ` Manoj Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Brian Evans @ 2019-09-27 19:48 UTC (permalink / raw
To: gentoo-dev, Manoj Gupta
[-- Attachment #1.1: Type: text/plain, Size: 517 bytes --]
On 9/27/2019 3:31 PM, Manoj Gupta wrote:
> sys-libs/db-18.1.32 can builds without "--default-symver"
> linker flag. This fixes the build issue when using LLD linker
> which does not support this flag.
>
> Given that sys-libs/db is the only Gentoo package using
> "--default-symver" linker, it is probably not a terrible idea to
> drop use of "--default-symver" flag.
>
But won't this change how *other* packages can be confused with multiple
slots of sys-libs/db installed at the same time?
Brian
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 834 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage.
2019-09-27 19:48 ` Brian Evans
@ 2019-09-27 19:54 ` Manoj Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Manoj Gupta @ 2019-09-27 19:54 UTC (permalink / raw
To: Brian Evans; +Cc: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On Fri, Sep 27, 2019 at 12:49 PM Brian Evans <grknight@gentoo.org> wrote:
> On 9/27/2019 3:31 PM, Manoj Gupta wrote:
> > sys-libs/db-18.1.32 can builds without "--default-symver"
> > linker flag. This fixes the build issue when using LLD linker
> > which does not support this flag.
> >
> > Given that sys-libs/db is the only Gentoo package using
> > "--default-symver" linker, it is probably not a terrible idea to
> > drop use of "--default-symver" flag.
> >
>
> But won't this change how *other* packages can be confused with multiple
> slots of sys-libs/db installed at the same time?
>
> Thanks,
I am not sure how multiple slotting will work after this change. Maybe,
it'd be better to make use of a version script suggested at
https://bugs.llvm.org/show_bug.cgi?id=43452. But I am not familiar with
this package enough to create a version script for
each installed shared library.
Thanks,
Manoj
Brian
>
>
[-- Attachment #2: Type: text/html, Size: 1629 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-27 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-27 19:31 [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage Manoj Gupta
2019-09-27 19:48 ` Brian Evans
2019-09-27 19:54 ` Manoj Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox