* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog
[not found] <20140614161527.E3EA22004E@flycatcher.gentoo.org>
@ 2014-06-14 20:06 ` hasufell
2014-06-14 20:50 ` Vadim A. Misbakh-Soloviov
0 siblings, 1 reply; 7+ messages in thread
From: hasufell @ 2014-06-14 20:06 UTC (permalink / raw
To: gentoo-dev
Maxim Koltsov (maksbotan):
> # Copyright 1999-2014 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> # $Header: /var/cvsroot/gentoo-x86/games-strategy/openxcom/openxcom-1.0.0.ebuild,v 1.1 2014/06/14 16:15:27 maksbotan Exp $
>
> EAPI=5
>
> inherit cmake-utils games
eutils.eclass is missing, but you make use of doicon/domenu
>
> DESCRIPTION="An open-source reimplementation of the popular UFO: Enemy Unknown"
> HOMEPAGE="http://openxcom.org/"
> SRC_URI="http://openxcom.org/wp-content/uploads/downloads/2014/06/${P}.tar.gz"
>
> LICENSE="GPL-3"
There seem to be more licenses, at least I find ZLIB in loadpng.h.
> SLOT="0"
> KEYWORDS="~amd64 ~x86"
> IUSE="debug doc"
>
> RDEPEND="app-arch/unzip
> >=dev-cpp/yaml-cpp-0.5.1
> media-libs/libsdl
It is very uncommon that games work without any libsdl USE flag enabled.
Did you double check?
> media-libs/sdl-gfx
> media-libs/sdl-image
Sure we don't need any use flags here? I see resources that are png files.
> media-libs/sdl-mixer"
The bug says something about intro music in different formats, yet we
don't have any USE flags for sdl-mixer. Did you test with all of them
disabled?
Further: Opengl is missing as a dependency. It directly links against it
and cmake checks for it.
> DEPEND="${RDEPEND}
> doc? ( app-doc/doxygen )"
>
> DOCS=( README.txt )
>
add cmake-utils_src_prepare explicitly, otherwise we might face issues
wrt bug #513170 (games.eclass inherits base.eclass which exports
src_prepare)
> src_configure() {
> mycmakeargs=(
why not make it "local mycmakeargs"?
> "-DCMAKE_INSTALL_PREFIX=${GAMES_PREFIX}"
> "-DDATADIR=${GAMES_DATADIR}/${PN}"
> )
> cmake-utils_src_configure
> }
>
> src_compile() {
> use doc && cmake-utils_src_compile doxygen
> cmake-utils_src_compile
> }
>
> src_install() {
> cmake-utils_src_install
> use doc && dohtml -r "${CMAKE_BUILD_DIR}"/docs/html/*
> doicon res/linux/icons/openxcom.svg
The modern way is to do:
doicon -s scalable res/linux/icons/openxcom.svg
and then update the icon cache, see games-action/trosh for an example
(and besides, it's an awesome game, lol)
> domenu res/linux/openxcom.desktop
>
> prepgamesdirs
> }
>
> pkg_postinst() {
> games_pkg_postinst
> elog "In order to play you need to copy GEODATA, GEOGRAPH, MAPS, ROUTES, SOUND,"
> elog "TERRAIN, UFOGRAPH, UFOINTRO, UNITS folders from the original X-COM game to"
> elog "${GAMES_DATADIR}/${PN}/data"
The above almost looks like it should also be in some kind of readme,
maybe use readme.gentoo here?
> }
>
Did you get a review from the games team?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog
2014-06-14 20:06 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog hasufell
@ 2014-06-14 20:50 ` Vadim A. Misbakh-Soloviov
2014-06-14 20:56 ` hasufell
2014-06-14 21:46 ` Jeroen Roovers
0 siblings, 2 replies; 7+ messages in thread
From: Vadim A. Misbakh-Soloviov @ 2014-06-14 20:50 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1.1: Type: text/plain, Size: 4821 bytes --]
=2D-nextPart1777642.JIEGotd4AA
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"
0JIg0L/QuNGB0YzQvNC1INC+0YIg0KHQsSwgMTQg0LjRjtC90Y8gMjAxNCAyMDowNjo1NCDQv9C+
0LvRjNC30L7QstCw0YLQtdC70YwgaGFzdWZlbGwg0L3QsNC/0LjRgdCw0Ls6Cj4gTWF4aW0gS29s
dHNvdiAobWFrc2JvdGFuKToKPiAgPC4uLj4KCldoYXQgYWJvdXQgYWRkaW5nIHN1Y2ggY2hlY2tz
IGluIHJlcG9tYW4/CgpQLlMuCgo+IERpZCB5b3UgZ2V0IGEgcmV2aWV3IGZyb20gdGhlIGdhbWVz
IHRlYW0/CgpZb3UncmUgcmlnaHQgaW4gYWxsIHJlbWFya3MsIGJ1dCBNYXhpbSBpcyBqdXN0IHBy
b3h5IGhlcmUuCkFuZCBJJ20gbm90IHN1cmUgaWYgb3JpZ2luYWwgbWFpbnRhaW5lciByZWFkcyAt
ZGV2LiBTbywgeW91J2QgcHJvYmFibHkgYWRkcmVzcyAKcmVtYXJrcyBoaW0uCgovLyBBbHRob3Vn
aCwgd2UncmUgYWxyZWFkeSBmb3J3YXJkZWQgdGhpcyBlbWFpbCB0byBoaW0uCgotLSAKQmVzdCBy
ZWdzcmRzLAptdmEKCg==
=2D-nextPart1777642.JIEGotd4AA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="utf-8"
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/=
REC-html40/strict.dtd">
<html><head><meta name=3D"qrichtext" content=3D"1" /><style type=3D"tex=
t/css">
p, li { white-space: pre-wrap; }
</style></head><body style=3D" font-family:'Droid Serif'; font-size:8pt=
; font-weight:600; font-style:italic;">
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">=D0=
=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D0=A1=D0=B1, 14 =
=D0=B8=D1=8E=D0=BD=D1=8F 2014 20:06:54 =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=
=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C hasufell =D0=BD=D0=B0=D0=BF=D0=B8=
=D1=81=D0=B0=D0=BB:</p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">>=
; Maxim Koltsov (maksbotan):</p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">>=
; <...></p>
<p style=3D"-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px=
; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0p=
x; "> </p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Wha=
t about adding such checks in repoman?</p>
<p style=3D"-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px=
; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0p=
x; "> </p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">P.S=
.</p>
<p style=3D"-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px=
; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0p=
x; "> </p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">>=
; Did you get a review from the games team?</p>
<p style=3D"-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px=
; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0p=
x; "> </p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">You=
're right in all remarks, but Maxim is just proxy here.</p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">And=
I'm not sure if original maintainer reads -dev. So, you'd probably add=
ress remarks him.</p>
<p style=3D"-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px=
; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0p=
x; "> </p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">// =
Although, we're already forwarded this email to him.</p>
<p style=3D"-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px=
; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0p=
x; "> </p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">-- =
</p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Bes=
t regsrds,</p>
<p style=3D" margin-top:0px; margin-bottom:0px; margin-left:0px; margin=
=2Dright:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">mva=
</p>
<p style=3D"-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px=
; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0p=
x; "> </p></body></html>
=2D-nextPart1777642.JIEGotd4AA--
This is a multi-part message in MIME format.
[-- Attachment #1.2: Type: text/plain, Size: 469 bytes --]
В письме от Сб, 14 июня 2014 20:06:54 пользователь hasufell написал:
> Maxim Koltsov (maksbotan):
> <...>
What about adding such checks in repoman?
P.S.
> Did you get a review from the games team?
You're right in all remarks, but Maxim is just proxy here.
And I'm not sure if original maintainer reads -dev. So, you'd probably address
remarks him.
// Although, we're already forwarded this email to him.
--
Best regsrds,
mva
[-- Attachment #1.3: Type: text/html, Size: 3605 bytes --]
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog
2014-06-14 20:50 ` Vadim A. Misbakh-Soloviov
@ 2014-06-14 20:56 ` hasufell
2014-06-14 21:46 ` Jeroen Roovers
1 sibling, 0 replies; 7+ messages in thread
From: hasufell @ 2014-06-14 20:56 UTC (permalink / raw
To: gentoo-dev
Vadim A. Misbakh-Soloviov:
> В письме от Сб, 14 июня 2014 20:06:54 пользователь hasufell написал:
>> Maxim Koltsov (maksbotan):
>> <...>
>
> What about adding such checks in repoman?
>
which one?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog
2014-06-14 20:50 ` Vadim A. Misbakh-Soloviov
2014-06-14 20:56 ` hasufell
@ 2014-06-14 21:46 ` Jeroen Roovers
2014-06-14 23:17 ` Rich Freeman
1 sibling, 1 reply; 7+ messages in thread
From: Jeroen Roovers @ 2014-06-14 21:46 UTC (permalink / raw
To: gentoo-dev
On Sun, 15 Jun 2014 03:50:06 +0700
"Vadim A. Misbakh-Soloviov" <mva@mva.name> wrote:
> You're right in all remarks, but Maxim is just proxy here.
And that's where the whole proxy maintainership falls down, isn't it?
The committer should check for and take responsibility for any QA
issues that may arise.
jer
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog
2014-06-14 21:46 ` Jeroen Roovers
@ 2014-06-14 23:17 ` Rich Freeman
2014-06-15 1:44 ` Jeroen Roovers
0 siblings, 1 reply; 7+ messages in thread
From: Rich Freeman @ 2014-06-14 23:17 UTC (permalink / raw
To: gentoo-dev
On Sat, Jun 14, 2014 at 5:46 PM, Jeroen Roovers <jer@gentoo.org> wrote:
> On Sun, 15 Jun 2014 03:50:06 +0700
> "Vadim A. Misbakh-Soloviov" <mva@mva.name> wrote:
>
>> You're right in all remarks, but Maxim is just proxy here.
>
> And that's where the whole proxy maintainership falls down, isn't it?
> The committer should check for and take responsibility for any QA
> issues that may arise.
Not having seen the original email, this is just a generalization.
Sure, those who commit are responsible for QA, but in general we
should be going easy on them, especially for minor stuff. If nobody
is willing to commit then there will be no proxies.
Look at Linus as an example - do you think he tests half the code he
merges personally? He probably doesn't even own hardware for 80% of
the drivers in the kernel. What he does do is ensure that he can
trust the people who feed stuff to him, and deal with them when they
drop the ball. I see that as the role of a Gentoo dev who is proxying
- they do provide a level of quality, but their main role should be to
liaison with the proxy maintainer and ensure that they are keeping up
their end of the bargain.
Rich
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog
2014-06-14 23:17 ` Rich Freeman
@ 2014-06-15 1:44 ` Jeroen Roovers
2014-06-15 2:12 ` Rich Freeman
0 siblings, 1 reply; 7+ messages in thread
From: Jeroen Roovers @ 2014-06-15 1:44 UTC (permalink / raw
To: gentoo-dev
On Sat, 14 Jun 2014 19:17:49 -0400
Rich Freeman <rich0@gentoo.org> wrote:
> Sure, those who commit are responsible for QA, but in general we
> should be going easy on them, especially for minor stuff.
Nobody was going hard on anyone. hasufell replied to an automated
e-mail, blaming no one in particular for a few issues he found. mva
replied that Maxim was not responsible. I replied that having
non-responsible proxy committers is a problem.[1]
> If nobody is willing to commit then there will be no proxies.
That might be the cost of having a better quality main tree. Or do you
suppose we wait until a couple of tiers down someone gains an
understanding of how to fix simple QA issues? The proxy committer
should be ready to do that, being a (somewhat more) skilled Gentoo
developer who presumably can invest the time to quickly fix any problems
that are found after the commit.
That's where by necessity we diverge from the Linux development
process, which has no such hierarchy and which wasn't a good example of
anything we do to begin with.
jer
[1] And now it's been removed from the tree again. The Games herd is
brutal, yes. Is that what you meant?
https://bugs.gentoo.org/show_bug.cgi?id=470188
[2] I understand Hitler ran a pretty tight ship, but did he check
everything himself? Must have been how he lost that war.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog
2014-06-15 1:44 ` Jeroen Roovers
@ 2014-06-15 2:12 ` Rich Freeman
0 siblings, 0 replies; 7+ messages in thread
From: Rich Freeman @ 2014-06-15 2:12 UTC (permalink / raw
To: gentoo-dev
On Sat, Jun 14, 2014 at 9:44 PM, Jeroen Roovers <jer@gentoo.org> wrote:
> On Sat, 14 Jun 2014 19:17:49 -0400
> Rich Freeman <rich0@gentoo.org> wrote:
>
>> Sure, those who commit are responsible for QA, but in general we
>> should be going easy on them, especially for minor stuff.
>
> Nobody was going hard on anyone. hasufell replied to an automated
> e-mail, blaming no one in particular for a few issues he found. mva
> replied that Maxim was not responsible. I replied that having
> non-responsible proxy committers is a problem.[1]
Yup. I agree there is a balance here. It lies somewhere between devs
who commit for proxy maintainers basically being full maintainers and
having no accountability whatsoever.
As you pointed out, no big deal here.
Rich
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-15 2:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140614161527.E3EA22004E@flycatcher.gentoo.org>
2014-06-14 20:06 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in games-strategy/openxcom: openxcom-1.0.0.ebuild metadata.xml Manifest ChangeLog hasufell
2014-06-14 20:50 ` Vadim A. Misbakh-Soloviov
2014-06-14 20:56 ` hasufell
2014-06-14 21:46 ` Jeroen Roovers
2014-06-14 23:17 ` Rich Freeman
2014-06-15 1:44 ` Jeroen Roovers
2014-06-15 2:12 ` Rich Freeman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox