From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RHy61-0001L8-Tr for garchives@archives.gentoo.org; Sun, 23 Oct 2011 13:28:14 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 44B0F21C13D; Sun, 23 Oct 2011 13:28:04 +0000 (UTC) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) by pigeon.gentoo.org (Postfix) with ESMTP id A3B1A21C0CA for ; Sun, 23 Oct 2011 13:27:34 +0000 (UTC) Received: by bke11 with SMTP id 11so8642956bke.40 for ; Sun, 23 Oct 2011 06:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=HplZ0X0hVLJCgagASMqI4lZAahVW2AP0cS7qAovuqjY=; b=qC1FyqLt6kmMJn3k1lEw+DK+JDhsLFUQqXCx0458MeGx/iP2XeJ4mo6MsflS13Yg7F rBZV86lZdOr75CBFwkrXChqmRma0+myJSfLkPb77YsedTY5j+fz+pxlJbEedY6oqS01M S9uin++6di0jMsOfvy+1fRlGNovwosYTgoKJY= Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.204.9.129 with SMTP id l1mr15046419bkl.15.1319376453732; Sun, 23 Oct 2011 06:27:33 -0700 (PDT) Sender: freemanrich@gmail.com Received: by 10.204.56.65 with HTTP; Sun, 23 Oct 2011 06:27:33 -0700 (PDT) In-Reply-To: <4EA40AED.2070600@gentoo.org> References: <20111023120055.76C302004B@flycatcher.gentoo.org> <4EA40AED.2070600@gentoo.org> Date: Sun, 23 Oct 2011 09:27:33 -0400 X-Google-Sender-Auth: tPeE4OTUglnyj7EZ3DTX1GWsnQY Message-ID: Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-sound/cdparanoia: ChangeLog cdparanoia-3.10.2-r3.ebuild From: Rich Freeman To: gentoo-dev@lists.gentoo.org Cc: scarabeus@gentoo.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: ab0d32bdefc83cccf0301ca36466c3e3 On Sun, Oct 23, 2011 at 8:39 AM, Samuli Suominen wro= te: > On 10/23/2011 03:00 PM, Tomas Chvatal (scarabeus) wrote: >> scarabeus =A0 =A011/10/23 12:00:55 >> >> =A0 Modified: =A0 =A0 =A0 =A0 =A0 =A0 ChangeLog cdparanoia-3.10.2-r3.ebu= ild >> =A0 Log: >> =A0 Bump to eapi4 and punt static libs. > > Time to revert this commit as I don't see anything in the ebuild that > disables building the static archives at compile phase. > > This is same as hiding the problem, not solving it. Not the way we do > things at sound@. > >> + =A0 =A0 use static-libs || find "${ED}" -name '*.a' -exec rm -f {} + Doesn't reverting this seem a bit like shooting yourself in the foot to remove an ingrown toenail? Unless I'm missing something this DOES get rid of the unneeded archives. Now, sure, you'd save a few milliseconds of CPU if they weren't built in the first place. However, you're proposing replacing an ebuild that builds but doesn't install undesired files with one that builds them AND installs them (since the hypothetical ebuild that does neither doesn't exist yet). Perfection shouldn't hold us back from improvement. By all means open up a bug asking for the next level of improvement if it really bothers people. Now, if there is some subtle issue that causes issues during build if the files are there and only removed at the last minute then clearly that is a bigger problem. Rich