public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Rich Freeman <rich0@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [RFC] Revisiting GLEP 81 (acct-*) policies (reviews, cross-distro syncing)
Date: Tue, 10 Dec 2019 10:54:04 -0500	[thread overview]
Message-ID: <CAGfcS_nGKy-GgW7gwYzc4aMya_X-1b8byYbu8x2pDfTZcK1SoQ@mail.gmail.com> (raw)
In-Reply-To: <79c81a90-af55-5661-307d-e4143e99a644@gentoo.org>

On Tue, Dec 10, 2019 at 9:50 AM Michael Orlitzky <mjo@gentoo.org> wrote:
>
> For esoteric packages with a dedicated user, though, you're probably
> right. The main benefit of the mailing list posts so far is that they
> let me track down pull requests and suggest that people ignore the
> example in the devmanual.
>

Do the list reviews really put people off that much?  It seems like
eclasses.  Plenty of packages have one-off eclasses that nobody cares
about except the specific project, in which case the list posts are
just a formality and largely a NOOP.  However, this list isn't really
high-traffic.  Ditto with last-rites and so on.  I think having the
opportunity for review is probably worth it even if often it is just a
NOOP.

If people are afraid to post something for review because of potential
criticism then maybe we need to work more to make sure people
understand that everybody makes mistakes and nobody knows everything,
and this is why we have reviews in the first place.  Nobody is going
to have their commit access removed because they didn't notice
something and were thoughtful enough to get more eyes on it before
commiting it.  IMO that is a sign of responsible commit access.

-- 
Rich


      parent reply	other threads:[~2019-12-10 15:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09  8:17 [gentoo-dev] [RFC] Revisiting GLEP 81 (acct-*) policies (reviews, cross-distro syncing) Michał Górny
2019-12-09  9:44 ` Ulrich Mueller
2019-12-09 10:00   ` Ulrich Mueller
2019-12-09 16:54 ` Thomas Deutschmann
2019-12-09 17:47   ` Ulrich Mueller
2019-12-09 18:02     ` Thomas Deutschmann
2019-12-09 18:48       ` Ulrich Mueller
2019-12-09 20:10         ` Thomas Deutschmann
2019-12-10 14:36           ` Michael Orlitzky
2019-12-09 21:48 ` Alec Warner
2019-12-10  5:28   ` Michał Górny
2019-12-10  5:44 ` Joonas Niilola
2019-12-10 11:47   ` Rich Freeman
2019-12-10 12:26     ` Thomas Deutschmann
2019-12-10 12:44       ` Rich Freeman
2019-12-10 13:25         ` Thomas Deutschmann
2019-12-10 13:48           ` Rich Freeman
2019-12-10 16:05     ` Joonas Niilola
2019-12-10 16:25       ` Michael Orlitzky
2019-12-10 13:34   ` Michał Górny
2019-12-10 16:13     ` Joonas Niilola
2019-12-10 16:17       ` Michał Górny
2019-12-10 14:50 ` Michael Orlitzky
2019-12-10 15:04   ` Michał Górny
2019-12-10 15:54   ` Rich Freeman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGfcS_nGKy-GgW7gwYzc4aMya_X-1b8byYbu8x2pDfTZcK1SoQ@mail.gmail.com \
    --to=rich0@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox