public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Rich Freeman <rich0@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] gentoo-x86 tree cleanup for 'DESCRIPTION ends with a '.' character' warnings
Date: Tue, 12 Aug 2014 09:26:07 -0400	[thread overview]
Message-ID: <CAGfcS_nBN7sjsJxa+72MY7VAt=AQ8UqvTRmD2cqr=RKeKDoFOg@mail.gmail.com> (raw)
In-Reply-To: <53EA0CC6.6050000@gentoo.org>

On Tue, Aug 12, 2014 at 8:47 AM, hasufell <hasufell@gentoo.org> wrote:
>
> First, a sentence does not need to have a predicate. I know that for 99%
> sure in german and the english wikipedia article seems to suggest the
> same. Correct me if I am wrong.
>

In English your typical English class would teach that every sentence
must have a predicate.  From what Google tells me it technically isn't
entirely true, but every sentence generally does contain a verb.  So,
"library that implements SSL" is not a sentence under any
circumstances.

> Second, there are valid descriptions that are full ordinary sentences
> without referencing ${PN}:
> "Access a working SSH implementation by means of a library".
>
> In addition, repoman doesn't check for full sentences that reference
> ${PN}, such as:
> "Portage is the package management and distribution system for Gentoo".
>
> So we have another (useless) repoman warning with false positives.
>

Yeah, at best this seems a bit trivial.  Do we have a policy that
descriptions aren't allowed to be complete sentences?  Many of our
developers are not native English speakers in the first place, so
striving for grammatical perfection is a bit optimistic.  On top of
that, repoman certainly isn't a native English speaker, so expecting
it to achieve grammatical perfection is a really tall order.  And
please don't suggest making languagetool a dependency for portage...

I don't have a problem with QA recommending new tree policies, but if
they're going to do this the QA team ought to first ensure that the
team agrees (however they want to govern that), and then communicate
the policy before implementing it.  I'd also implement it in
documentation before doing so in repoman, otherwise we're going to
have a repoman full of 800 rules whose origin is a mystery.  I'm fine
with QA policies going into effect by default, but communicating them
allows objections to be raised and an appeal made to Council if
necessary before we get too far along.  This isn't just about due
process - it is hard for developers to even comply with a policy they
are unaware of.

Rich


  reply	other threads:[~2014-08-12 13:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10 12:22 [gentoo-dev] gentoo-x86 tree cleanup for 'DESCRIPTION ends with a '.' character' warnings Sergei Trofimovich
2014-08-11 20:34 ` Bertrand Jacquin
2014-08-12 18:32   ` Michał Górny
2014-08-12  1:48 ` William Hubbs
2014-08-12  1:59   ` Manuel Rüger
2014-08-12  2:42     ` William Hubbs
2014-08-12  4:20       ` Tyler Pohl
2014-08-12  5:29         ` [gentoo-dev] " Duncan
2014-08-12 11:33           ` Alex Xu
2014-08-12 12:47       ` [gentoo-dev] " hasufell
2014-08-12 13:26         ` Rich Freeman [this message]
2014-08-12 14:26           ` hasufell
2014-08-12 16:24           ` William Hubbs
2014-08-12 18:37           ` Chris Reffett
2014-08-12 21:08             ` hasufell
2014-08-12 13:54         ` Ian Stakenvicius
2014-08-12 14:04           ` [gentoo-dev] repoman --nonag (was Re: gentoo-x86 tree cleanup for 'DESCRIPTION ends with a '.' character' warnings ) Ian Stakenvicius
2014-08-12 16:36             ` Rich Freeman
2014-08-12 16:57               ` Ian Stakenvicius
2014-08-12 17:08                 ` hasufell
2014-08-12 17:13                   ` Ian Stakenvicius
2014-08-12 17:25                     ` Rich Freeman
2014-08-12 17:46                       ` William Hubbs
2014-08-12 19:01             ` Michał Górny
2014-08-12 19:11               ` Ian Stakenvicius
2014-08-13  8:47             ` Tom Wijsman
2014-08-12 18:46   ` [gentoo-dev] gentoo-x86 tree cleanup for 'DESCRIPTION ends with a '.' character' warnings Michał Górny
2014-08-18 14:10     ` Ben de Groot
2014-08-13  8:38   ` Tom Wijsman
2014-08-13 16:36     ` [gentoo-dev] " Duncan
2014-08-12 22:00 ` [gentoo-dev] " Alexander Berntsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGfcS_nBN7sjsJxa+72MY7VAt=AQ8UqvTRmD2cqr=RKeKDoFOg@mail.gmail.com' \
    --to=rich0@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox