From: Rich Freeman <rich0@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] On banning merge commits
Date: Sun, 8 May 2016 08:34:37 -0400 [thread overview]
Message-ID: <CAGfcS_mz-yK+3ejJTzcJ2L0pvBNaESyd+4PKCXYqG6hSKxGdfQ@mail.gmail.com> (raw)
In-Reply-To: <CAATnKFBHX_=rQXaeuq4OCxmN+Y5b70jd46G_njKLr7hgDxp7jw@mail.gmail.com>
On Sun, May 8, 2016 at 8:18 AM, Kent Fredric <kentfredric@gmail.com> wrote:
> On 9 May 2016 at 00:09, Anthony G. Basile <blueness@gentoo.org> wrote:
>> 1. announce to gentoo-dev@ the intention to start a branch intending to
>> merge
>>
>> 2. hack hack hack
>>
>> 3. test the merge for any conflicts etc,
>>
>> 4. announce to the list a date/time to merge
>>
>> 5. if okay, ermge
>
> It would make much sense for this series to be visible on Master as a
> "add Perl 5.24 to tree" commit, because all the changes are inherently
> interdependent,
> and it would make little sense to rewind to a specific point within
> that series and use it as a portage tree.
>
> But that's not significant enough to warrant a lot of formal fluffing around.
>
> It for sure would be best if that 100 commit range was rebased before
> merging, but it should still be a non-fast-forward merge just to keep
> the history logical.
>
++
merges shouldn't just be used for random pull-requests. However, when
you're touching multiple packages/etc they should be considered. They
should also be considered if for some reason you had a bazillion
commits to a single package that for some reason shouldn't be rebased.
I imagine that they'll be a small portion of commits as a result.
However, for the situations where they're appropriate they make a lot
of sense.
This was some of Duncan's point, but I will comment that we'll never
have as clean a history as the kernel simply because we don't have a
release-based workflow with the work cascading up various trees. The
kernel is almost an ideal case for a merge-based workflow. I imagine
that half of Gentoo's commit volume is random revbumps and keyword
changes and that is just going to be noise no matter what. If we were
release-based we could do that stuff in its own branch and merge it
all in at once, but that just isn't us.
--
Rich
next prev parent reply other threads:[~2016-05-08 12:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 23:52 [gentoo-dev] On banning merge commits Patrice Clement
2016-05-08 5:09 ` Michał Górny
2016-05-08 5:44 ` cbergstrom
2016-05-08 8:21 ` Greg KH
2016-05-08 9:35 ` Daniel Campbell
2016-05-08 8:58 ` [gentoo-dev] " Duncan
2016-05-08 9:25 ` Kent Fredric
2016-05-08 10:21 ` Duncan
2016-05-08 10:35 ` Dirkjan Ochtman
2016-05-08 10:30 ` [gentoo-dev] " Dirkjan Ochtman
2016-05-08 12:00 ` Michał Górny
2016-05-08 12:31 ` Dirkjan Ochtman
2016-05-08 11:13 ` Andreas K. Hüttel
2016-05-08 11:28 ` M. J. Everitt
2016-05-08 9:15 ` Andrew Savchenko
2016-05-08 10:06 ` Amadeusz Żołnowski
2016-05-08 12:53 ` Brian Dolbec
2016-05-08 15:15 ` Jeroen Roovers
2016-05-08 22:25 ` Daniel Campbell
2016-05-08 11:25 ` Andreas K. Hüttel
2016-05-08 11:57 ` Rich Freeman
2016-05-08 12:07 ` Kent Fredric
2016-05-08 21:56 ` [gentoo-dev] " Duncan
2016-05-08 12:09 ` [gentoo-dev] " Anthony G. Basile
2016-05-08 12:18 ` Kent Fredric
2016-05-08 12:34 ` Rich Freeman [this message]
2016-05-08 12:43 ` Anthony G. Basile
2016-05-08 22:02 ` [gentoo-dev] " Duncan
2016-05-08 17:03 ` [gentoo-dev] " Alexis Ballier
2016-05-08 17:07 ` Kent Fredric
2016-05-09 11:27 ` Kristian Fiskerstrand
2016-05-09 12:23 ` Rich Freeman
2016-05-09 12:36 ` Kent Fredric
2016-05-09 12:59 ` Rich Freeman
2016-05-10 12:04 ` Alexis Ballier
2016-05-10 14:18 ` Kent Fredric
2016-05-11 10:21 ` Alexis Ballier
2016-05-11 14:34 ` Kent Fredric
2016-05-11 15:12 ` Rich Freeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGfcS_mz-yK+3ejJTzcJ2L0pvBNaESyd+4PKCXYqG6hSKxGdfQ@mail.gmail.com \
--to=rich0@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox