From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 70E2713825A for ; Sun, 15 May 2016 01:01:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AAAAD14303; Sun, 15 May 2016 00:59:58 +0000 (UTC) Received: from mail-io0-f194.google.com (mail-io0-f194.google.com [209.85.223.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 57D25142FE for ; Sun, 15 May 2016 00:59:52 +0000 (UTC) Received: by mail-io0-f194.google.com with SMTP id x35so20378052ioi.0 for ; Sat, 14 May 2016 17:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to; bh=Z78tSQrHvtFS+8jG/6PZuftMvQB4FWlCU/x8HE1cmjc=; b=FQzQfTjL5aSBa86y9kzAJFeHo4HAu+4RkKqvXbPkENfr0GFtMOvCQAAwyGZ+bwmjZx zXQGCZ42vr8Sm6MVoiCrtp8ikPK/cZZx82OJDSEsAXF5J9zIkr6oZPCy/0uiFLVzdFcm AKih20l0SHOOOs0nOiofAYe8m7zfwgtN1ZvcFPujH63Ugx/18nQR++QjfaEsBH/WvfM1 t6IOhXfHsjO7xTNIPBjICMXME0HSeXr+ryjQlnO/vLJtDeDb/sZTjIAou2XXFih1NlYn uB9erSS7gQi6MNZOYx3WKl8OV6X5UdOFcgJjV9e1QryYG0+8GN6P/8eY2RVPn3prfMBQ LDFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to; bh=Z78tSQrHvtFS+8jG/6PZuftMvQB4FWlCU/x8HE1cmjc=; b=dADlkiU26s2rjElm7NBg82wS8uc/3NL0S7eBN+RPtiuea/CWkirgmosFNdVAcElg5d Ara6z5IdLgAfIdi6BeIkV7MtAqNdjc6D9wnOyocRSvcQRMtrbsz3waRKynElQQMqo4Rz W8tiXTPFQMjOTe/0amPMbnA+QddOhWYu9cOzBg1Pi9WTgzwhD9fMvr4CUS1HCpeQ80Gz paiG6r0huSLv6oRZ6atwodEqeh9MWx4IxNSeNdYuvehLaYG3SBaLhg0zutV2YYlXCpyL C6jO2KcZNw3bmyubPxwiFdUqBsqH4hKrIGqq6j2UxJmcDUin583cWkos6e3zqqqy5HPq CGVA== X-Gm-Message-State: AOPr4FU1v16qwE6GJEU6ndbRvJqPfriU14I8tv4cB9NjV9GVNwNqJoSkc79vZsElCWC3HFQPOmEcIxIKmKRYBw== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.107.182.137 with SMTP id g131mr15926939iof.27.1463273991564; Sat, 14 May 2016 17:59:51 -0700 (PDT) Sender: freemanrich@gmail.com Received: by 10.64.159.8 with HTTP; Sat, 14 May 2016 17:59:51 -0700 (PDT) In-Reply-To: <2471981.YXCVhQinPE@localhost> References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <1537862.pH6huOSrz0@localhost> <2471981.YXCVhQinPE@localhost> Date: Sat, 14 May 2016 20:59:51 -0400 X-Google-Sender-Auth: RcoMqm_UGd8thVqJuAzxqDHdSJY Message-ID: Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ From: Rich Freeman To: gentoo-dev Content-Type: text/plain; charset=UTF-8 X-Archives-Salt: 3f1a9cee-74a5-49e7-97e5-f05221c954e6 X-Archives-Hash: 3196f655c996b2e944fd8ea2758aebb7 On Sat, May 14, 2016 at 7:40 PM, Aaron Bauman wrote: > > Please enlighten me as to what was impolite here? The strong language of > "seriously" or definitively stating that the individual did not perform the > necessary QA actions before committing? He actually didn't "state" anything at all - he posted a set of rhetorical questions. And the use of "seriously" was inflammatory. In fact, if you're trying to avoid injecting passion into a discussion it is worth thinking carefully about just about any word ending in "ly" that you put into a sentence. Nine times out of ten the word isn't necessary and can cause more harm than good. > Both of which are completely called > for and appropriate. No vulgarity, insults, or demeaning words were used. I disagree. The tone was uncivil and demeaning. > How would you have responded professionally? > How about this: You inserted this code snippet into the middle of a command line, so it is certain to break in either case. This should have been detected during testing; please be sure to test changes to ebuilds/eclasses before committing them. Additionally eclass changes should be submitted to the lists for review in any case prior to being committed. Or by all means refer the issue to QA/Comrel if you want to escalate it. I'm in no way suggesting that we should accept bad commits. IMO when we see bad commits we should: 1. Just point them out politely if it is a one-off. ANYBODY can make a mistake. 2. If they're a trend or show signs of bad practices like not testing changes then escalate to QA/Comrel. 3. Let QA/Comrel do their job and block commit access or refer the dev for more mentoring/etc as appropriate. Then we actually fix the problem instead of just yelling at each other. -- Rich