From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9A821138334 for ; Wed, 12 Sep 2018 23:03:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E969AE0D73; Wed, 12 Sep 2018 23:03:46 +0000 (UTC) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 86F9AE0D6C for ; Wed, 12 Sep 2018 23:03:46 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id k19-v6so1740932pfi.1 for ; Wed, 12 Sep 2018 16:03:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=k/6rrB4OFkc+ge0ERN5VhuM251XeLUOa8isi+f/WX9g=; b=uZhH+I0dlkc/sW1durVPkEDAgfUWdQJk2eAGLoDWtd6ylKzLUP4vAlCb/Vkt2uYz9n JYR7X+2KixQMa15HTUd6Eto3pVTtNMBOEjg7WIcaBDW6gapm2lvsv6zEoTmIXg9E2auZ z5BwTzfmCEk6VYO3DUXBQJwm13Vfa9eoHQzLvZyie/uA70qO4Jz1OGvfQxl93jVP2Us3 BBjQtBi8xQyJgvvDAGz9yz++t5XvCzl1T2dHDV34YJVy4umyQ+nVBH1yDKvwQZxaZsq1 g621rJvLCQc9fgXGQF5Zq/MysSi1PiiC3TgcnI4FA6wNbvT9KaKzoCOdrCLBjNgdIF56 aXyQ== X-Gm-Message-State: APzg51CqN5IjxKKIW68T3kq6djqSWtc1TyCKNjFIn7k7er2FCEkeFewZ DH8WFIgkRjZUBPDJHCXAdFUXKNMleFIGLnIm+rJYnxSQ X-Google-Smtp-Source: ANB0VdYEDVV43iIvBkAvlrtt3X/ntM15etdreoAWQO7SePH4xKFLLRk7vubJbKjmZPpkJztc0gDwKGcFtqt7tzZVr1M= X-Received: by 2002:a65:5304:: with SMTP id m4-v6mr4499161pgq.250.1536793425058; Wed, 12 Sep 2018 16:03:45 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <20180909143221.21d784d02f51623e8c57c545@gentoo.org> <1536510660.863.9.camel@gentoo.org> <20180910074539.GA6512@baraddur.perfinion.com> <0d8b7f02-9c38-969c-413b-69d4dee6ca89@gentoo.org> <20180912085649.GA16516@baraddur.perfinion.com> <6c18c6bd-4cf3-dff6-2f20-c021063e01fa@gentoo.org> In-Reply-To: <6c18c6bd-4cf3-dff6-2f20-c021063e01fa@gentoo.org> From: Rich Freeman Date: Wed, 12 Sep 2018 19:03:33 -0400 Message-ID: Subject: Re: [gentoo-dev] Changing policy about -Werror To: gentoo-dev Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: f2718c03-e6b0-420d-8a85-3ffa3c185fff X-Archives-Hash: 0fceb71215290ebb1622038551d034ce On Wed, Sep 12, 2018 at 6:55 PM Thomas Deutschmann wrote: > > On 2018-09-12 16:50, Rich Freeman wrote: > > There is also the case where we want these warnings to block > > installation, because the risk of there being a problem is too great. > > I really disagree with that. So many devs have already said multiple > times in this thread that "-Werror" is only turning existing warnings > into fatal errors but "-Werror" itself doesn't add any new checks and > more often requires "-O3" to be useful. > This seems unlikely. If upstream is using -Werror in their build system, then they'd be getting build errors if these warnings already existed at the time they released the version. Now, I could buy that -Werror turns NEW warnings into fatal errors, due to the use of a newer toolchain, since upstream probably didn't test with that toolchain and thus wouldn't have seen the warning. If the warning only appears with -O3, and the package isn't built with -O3, then -Werror is a no-op and is harmless. But, I think there is somewhat of a legitimate point in pointing out that -Werror is in some sense just a proxy for detecting when a toolchain is being used which wasn't tested by upstream. You could accomplish the same by sticking a ton of toolchain blockers in the package. Of course, I can't imagine the toolchain team would be terribly happy about that, but if you want to avoid using newer toolchains with older versions of a package that would probably the the appropriate way to do it. -- Rich