From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 58CFE13825A for ; Sun, 15 May 2016 23:19:45 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 33CCF14228; Sun, 15 May 2016 23:19:37 +0000 (UTC) Received: from mail-io0-f195.google.com (mail-io0-f195.google.com [209.85.223.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 437F021C051 for ; Sun, 15 May 2016 23:19:36 +0000 (UTC) Received: by mail-io0-f195.google.com with SMTP id k129so22826429iof.3 for ; Sun, 15 May 2016 16:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to; bh=z9AqMFEWvLFxNf7GhQh0Sv1GSJZ4PnUPNxyeMRxJpmY=; b=G2iDuOXueS7JrzEbbBPDMzJtBQgRmB9FKlkvrQdcNGDNPjY+uKvzwEpZh2lqlZcPCr VLVfBDNG8VIn8e1kLJBxLjUFE+nb64qnAgVQGWkX2i3xLSzzfmMvBEv6VqfrX+jb/wrm sj9r7EhZC2UJkDcgmCdrtGiCcZrjXhtghUUn8s9//aqTt9j+8Asy8hVP3BTUJx7meb/F h7/VJT60n48snQDQMJ/WaXhPeob56WBiCt8k6218nSV2OqmdAeFZwYuDKGtqTc4d2YBX JhqLXN9dYhLjzfG37GTvvIKBSMCVo6Z2K5+xZYR3xEwCJlDD50d6OMAhJdULvqbWQS5P 0MEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to; bh=z9AqMFEWvLFxNf7GhQh0Sv1GSJZ4PnUPNxyeMRxJpmY=; b=a5rVww+2MmRdKuEddy6omRRM3mpY6WvTAnzRzAqxmwJfto6czwmwzfEjxTkzYTihmJ xWk0e6O/hYha1lRF1uvW0ovgd0aJvySkSsfrM4GcrQwJLtHwA2KZR6c4gE8FMAi9sGeu u1lfWde4zloOkm+mJBXrGz8ZnAfkEujZ163O/KfUMX2sapEisuyR29BaXSO914fGANFV rrayyyAFEzOo26mNBI5Mqu1jYPtR7+4AEa8f+lce4b3fvXjeMsMFFVY9r7WGXMPh9sZA 9giWjONAKHHdGPoP07gf3byNt0AP0LTftPuvc36mQjORC5sehsdylccM0PzIjPq/h/eA HMdA== X-Gm-Message-State: AOPr4FX8C2Toi2MXhZiNAJzJoR20MEg3oBtpG7RxaSL2nPH+7liNA9iAfY7Xlkt/NZhDmUD0nMMwfSnS75rknw== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.36.95.143 with SMTP id r137mr6751806itb.24.1463354375427; Sun, 15 May 2016 16:19:35 -0700 (PDT) Sender: freemanrich@gmail.com Received: by 10.64.159.8 with HTTP; Sun, 15 May 2016 16:19:35 -0700 (PDT) In-Reply-To: References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <1537862.pH6huOSrz0@localhost> <2471981.YXCVhQinPE@localhost> <20160515122931.62603b62.mgorny@gentoo.org> <4504fd28-f9fa-031b-5d9b-9e13c8cafbb9@gentoo.org> Date: Sun, 15 May 2016 19:19:35 -0400 X-Google-Sender-Auth: 8-wnba-I-V5_oi89T6Xatu1nGxU Message-ID: Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ From: Rich Freeman To: gentoo-dev Content-Type: text/plain; charset=UTF-8 X-Archives-Salt: af1e78c0-1a62-4373-bd7a-88101d41afe1 X-Archives-Hash: e4940b41398014ed75a0393675b070fb On Sun, May 15, 2016 at 6:46 PM, Duncan <1i5t5.duncan@cox.net> wrote: > > Committing without testing, as long as you don't push, is fine, even > meritorious. It's the push that uploads those commits to the gentoo > reference repo, however, and testing should *definitely* be done before > pushing, with more commits /before/ the push to fix what the tests found > to be broken, should they be necessary. > Of course. In fact, this is often the type of workflow you'd tend to employ in a CI setup. I believe that pull requests submitted on github get automatically tinderboxed, though I have no idea whether that provides any benefits to something like an eclass (if the CI script just tests the ebuilds being modified it obviously would not). Maybe in a perfect world we'd actually have a CI testing package category with dummy packages that do nothing but run tests to cover this sort of thing. Even so, I would imagine that in most organizations CI is intended more as a sanity check than a substitute for testing your own work. Certainly where I work the expectation is that somebody would have at least compiled and run something before putting it into some kind of QA workflow, even with CI. -- Rich