From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E30D71381F3 for ; Tue, 23 Apr 2013 19:11:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2AF8DE0AA5; Tue, 23 Apr 2013 19:11:13 +0000 (UTC) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 39902E0A8B for ; Tue, 23 Apr 2013 19:11:12 +0000 (UTC) Received: by mail-vc0-f173.google.com with SMTP id gf12so1007761vcb.18 for ; Tue, 23 Apr 2013 12:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=W9foOe87t7+S/WQkh+RPHFehfzUZuVFIP4V4apQroeM=; b=kfJNg8MMc3/LeDiE1bHym6SPeszBSNXoExC/3E83txYGlgv27DenOk9aTphZ1evLdq olECsNdpifcBq/+cieDMmEiyn8I0dr2iYxIuykOxQ6N0WZ8RKV6UsnwthgNaFQjuYrTs 0MT1fV5XpHx1hFkYlYQWsXdtZqJKPmoaArXDksQBIN7+LZfeKjq61IEIYJ2/akWzw9lJ a/IvRCAwUt1YO2pZ3Vu3SP7PiuIDRI7IpTakc12zzcVBggAbxNyFk2e87905JxNXH8uL Psb0IuwV84M35ifHZhUdQvDyg0VgHtw4k/dg0DLXmPuLj9oziJoZsXPVVPpZbVW8wUMD dqHw== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.52.93.233 with SMTP id cx9mr3062941vdb.112.1366744271414; Tue, 23 Apr 2013 12:11:11 -0700 (PDT) Sender: freemanrich@gmail.com Received: by 10.52.168.4 with HTTP; Tue, 23 Apr 2013 12:11:11 -0700 (PDT) In-Reply-To: References: <20130419091632.D01152171D@flycatcher.gentoo.org> <20130419153043.30ffc50c@portable> <20130421170549.41cfea49@portable> <20130422154033.65a68a40@portable> <20130423200053.77ed8b49@marga.jer-c2.orkz.net> Date: Tue, 23 Apr 2013 15:11:11 -0400 X-Google-Sender-Auth: sSpJQDbVcxQG5cP14MvDJ6cQJHE Message-ID: Subject: Re: [gentoo-dev] Re: [OT/NIT] Re: Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask From: Rich Freeman To: gentoo-dev Content-Type: text/plain; charset=ISO-8859-1 X-Archives-Salt: c54c5b4b-da91-42fe-bc61-229fc0d1af68 X-Archives-Hash: 2dc5846755bacc52c6ac5f6bf65eef3e On Tue, Apr 23, 2013 at 2:37 PM, Matt Turner wrote: > On Tue, Apr 23, 2013 at 11:20 AM, Rich Freeman wrote: >> On Tue, Apr 23, 2013 at 2:00 PM, Jeroen Roovers wrote: >>> Er, you can't be seriously suggesting we will drop repoman checks with >>> the migration to git? I don't see how that would benefit anyone. >>> >> >> Interesting point. One thing to keep in mind with git is that commits >> don't affect the "central repository." Pushes are what impacts the >> repository. >> >> If I spend six months working on a bunch of coordinated package >> changes, nobody will see a thing until I push those commits and 500 >> ebuilds all change atomically (not that I'm suggesting that lack of >> communication is to be encouraged). A repoman check on a commit may >> not reflect its impact six months later when it actually hits the main >> tree. > > ... if you're squashing 6 months of work into a single commit before pushing. > > I don't think we want to do that, do we? Maybe bisecting isn't > particularly interesting for the portage tree. I never said that I was squashing 6 months of work into a single commit, only that I was pushing 6 months worth of commits in a single operation. Any repoman checks done at the time of each commit are essentially worthless. Consider this example: 1. Create app-misc/foo-1.2 which depends on app-misc/bar. Repoman checks this and it is fine. 2. Do 500 other commits. 3. Push it all to the tree six months later. 4. Get bug report that app-misc/bar was renamed two months back. Repoman is about checking changes to the main repository. What matters isn't how the change you made impacts your clone of the repository, but how that change impacts the main repository when it eventually makes its way back. Unless your workflow is to pull, commit, and push with no intervening commits by other contributors, the repoman check needs to be done before the push, not the commit. Rich