From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9128B13877A for ; Mon, 18 Aug 2014 13:27:44 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3D835E0A8E; Mon, 18 Aug 2014 13:27:40 +0000 (UTC) Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 446E4E098F for ; Mon, 18 Aug 2014 13:27:39 +0000 (UTC) Received: by mail-vc0-f180.google.com with SMTP id ij19so5716279vcb.39 for ; Mon, 18 Aug 2014 06:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=GCFJrZG3pks0mL7f2wSElEpgQPBW7eKIjLv3+7i9btw=; b=AkFr+nJnKcVCcJ0am7A0+9VdwY4tVe3+hI3rAaaoSnXHExOE8hLann8awqcGY+X2we 4lFvmzWqqNAj2Jx4PPPEffOcmXoP9XPAcax1pttp3qElNKK40p3Fao3Gy1IFgaV+CGFg ejOmYJxX++Becj/sg6SAtyHkN+dpiIH2WBNUCqaIHHpFefRyL54ndAS+/stkCRNQW+nY LfNJaDU/8LddXR1+jagR/JufKjfo071CRKcILJcnIpHz5L9k4A21BrgAcDrVN5/2DtBQ LoBPXwNQdiC3KhiSYDabN5VYRdCo9kgzfd+IBc5cdWgdI2nVgpukhfRPGfpPvCbizVg1 z6pw== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.52.94.108 with SMTP id db12mr2478079vdb.8.1408368458116; Mon, 18 Aug 2014 06:27:38 -0700 (PDT) Sender: freemanrich@gmail.com Received: by 10.52.8.229 with HTTP; Mon, 18 Aug 2014 06:27:37 -0700 (PDT) In-Reply-To: <53F1EFCB.9060403@gentoo.org> References: <20140816215428.GA6773@linux1> <53F1BF3C.9060902@gentoo.org> <53F1EFCB.9060403@gentoo.org> Date: Mon, 18 Aug 2014 09:27:37 -0400 X-Google-Sender-Auth: vMI7jxxUZ3jBeAMYhrZnV_0ZqwE Message-ID: Subject: Re: [gentoo-dev] rfc: calling all eclass phase functions by default From: Rich Freeman To: gentoo-dev Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: a2c57602-0489-4e20-b917-73aca9a48b09 X-Archives-Hash: 72424ca851f118f28fe5cb97948563f4 On Mon, Aug 18, 2014 at 8:21 AM, Sergey Popov wrote: > 18.08.2014 14:44, Rich Freeman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On Mon, Aug 18, 2014 at 4:54 AM, Sergey Popov wrot= e: >>> 17.08.2014 01:54, William Hubbs =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> >>>> # Foo and bar both have src_unpack and src_install functions. >>>> # we want foo's src_unpack and bar's src_install: >>>> >>>> ECLASS_PHASES=3D"foo_src_unpack >>>> bar_src_install" >>> >>> You have my strong opposition on such change as well. It will turn >>> ebuilds into unreadable and undpredictable mess, please do not do that >>> >> >> I'm not sure I follow your complaint. He is talking about adding one >> line to an ebuild. I'm not sure how that is unreadable, and the >> algorithm you quoted looks fairly predictable to me as well. >> >> Certainly it is less convenient than not having to do anything to pull >> in eclass-defined phase functions, and it requires ebuilds to be >> updated when eclasses are updated to add new phase functions. That >> could be problematic for cases like KDE/X11/etc where you have a large >> collection of short ebuilds with all the logic in an eclass. >> >> I just want to make sure I'm understanding your concern in case there >> is a new issue being raised. > > What's bad with overriding needed functions and saying which exported > functions(from eclasses) to execute and in which order? > > Is this approach flaw? In which ways? Ok, I was misunderstanding your original comment. You're advocating just having ebuilds explicitly call phase functions from eclasses then, and not automatically inheriting them? Your objection was to the ECLASS_PHASES concept, and not to the principle of eliminating automatic inheritance of phase functions? Please let me know if I'm still misunderstanding you. There are a lot of potential ways to go with this so it isn't always clear what part of a proposal is being objected to. Rich