public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Rich Freeman <rich0@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] stabilization commits and atomicity
Date: Mon, 19 Oct 2015 15:52:08 -0400	[thread overview]
Message-ID: <CAGfcS_=DpLJbHSQSAs2u9Ese1az2KdkPonB_AcANF-N__Uc4Dg@mail.gmail.com> (raw)
In-Reply-To: <56252EA3.8070106@gentoo.org>

On Mon, Oct 19, 2015 at 1:55 PM, hasufell <hasufell@gentoo.org> wrote:
> On 10/19/2015 07:52 PM, Rich Freeman wrote:
>> On Mon, Oct 19, 2015 at 1:40 PM, hasufell <hasufell@gentoo.org> wrote:
>>> On 10/19/2015 07:37 PM, Rich Freeman wrote:
>>>>
>>>> However, stabilizing a single package really is an impactful change.
>>>> The fact that you're doing 100 of them at one time doesn't really
>>>> diminish the impact of each one.  Any of them could break a system or
>>>> need to be reverted.
>>>>
>>>
>>> Since when do we allow reverting stabilization? The package needs to be
>>> fixed and possibly revbumped instead.
>>>
>>
>> It would really depend on the nature of the break.  If it is a serious
>> upstream problem and no fix is available, then reverting might be the
>> only practical solution.  It is of course not a preferred solution.
>>
>
> I don't think we depend on 'git revert' in that case. KEYWORDS are
> trivial changes (in terms of file diffs).
>

True, as long as they're truly standalone.

Maybe the compromise is:
1.  Groups of related stabilizations should be grouped.
2.  Groups of only unrelated stabilizations can also be grouped.
3.  You must not try to mix #1 and #2 in the same commit.

As you say individual packages are easy to revert anyway.  However, we
wouldn't want 100 of those to be mixed in with 50 packages that all
needed to be coordinated, because those 50 aren't easy to revert.

-- 
Rich


  reply	other threads:[~2015-10-19 19:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 11:21 [gentoo-dev] stabilization commits and atomicity hasufell
2015-10-19 11:55 ` Dirkjan Ochtman
2015-10-19 12:21   ` Rich Freeman
2015-10-19 14:37     ` Ian Stakenvicius
2015-10-19 15:04       ` hasufell
2015-10-19 15:10         ` Matthew Thode
2015-10-19 15:27         ` Ian Stakenvicius
2015-10-19 17:08           ` Rich Freeman
2015-10-19 17:13             ` hasufell
2015-10-19 17:37               ` Rich Freeman
2015-10-19 17:40                 ` hasufell
2015-10-19 17:52                   ` Rich Freeman
2015-10-19 17:55                     ` hasufell
2015-10-19 19:52                       ` Rich Freeman [this message]
2015-10-20 22:25                     ` [gentoo-dev] " Duncan
2015-10-20 23:16               ` Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGfcS_=DpLJbHSQSAs2u9Ese1az2KdkPonB_AcANF-N__Uc4Dg@mail.gmail.com' \
    --to=rich0@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox