From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 399B113877A for ; Mon, 18 Aug 2014 10:45:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B375AE0936; Mon, 18 Aug 2014 10:45:01 +0000 (UTC) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D3911E08E9 for ; Mon, 18 Aug 2014 10:45:00 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id la4so5509707vcb.19 for ; Mon, 18 Aug 2014 03:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=0WV4fF/nImuKhiXHNyw7FLulV3TT3jBDF8wHd2kyhcM=; b=qvbojcP8v6KOBFQSPZkaxLIP1esg0xQ6hEqliDqUG/hT5AULJjAXw/k9Y+vzrBK8U3 n5U2BZp3UVbVX3TSOXHaFse+N82VyWrJ0Vt59mfvPOTzW6aUCV35lzrfN1cS+G0QP/dK 1ImVQ5sx15alXOkhmEEm7VI5zHMfK1rnDBO0MCX+NpgJKkpi06bioXjRVs4ZVghW+R7q mPMQ6XGXZpeE9HQ2fnBURb65qxQEkPoxULDbg7VOrSW63FBIFsIjqxfR8ZF4TPWcraZR zfBDrpAwCp97ogj9urUD+bMrFe0Qxyhknr5syCBPHt4lJbe2axcyi8ltgFoKTLSzvYXH vU3w== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.52.129.165 with SMTP id nx5mr13745236vdb.25.1408358699893; Mon, 18 Aug 2014 03:44:59 -0700 (PDT) Sender: freemanrich@gmail.com Received: by 10.52.8.229 with HTTP; Mon, 18 Aug 2014 03:44:59 -0700 (PDT) In-Reply-To: <53F1BF3C.9060902@gentoo.org> References: <20140816215428.GA6773@linux1> <53F1BF3C.9060902@gentoo.org> Date: Mon, 18 Aug 2014 06:44:59 -0400 X-Google-Sender-Auth: rYe_8rjXrgMrcP4Vlt87_-bikkM Message-ID: Subject: Re: [gentoo-dev] rfc: calling all eclass phase functions by default From: Rich Freeman To: gentoo-dev Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: ecdd4f19-f541-4ce7-b618-f34d35574dd4 X-Archives-Hash: 1ba7b018d0701ddbdc292ba492eac9f2 On Mon, Aug 18, 2014 at 4:54 AM, Sergey Popov wrote: > 17.08.2014 01:54, William Hubbs =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> # Foo and bar both have src_unpack and src_install functions. >> # we want foo's src_unpack and bar's src_install: >> >> ECLASS_PHASES=3D"foo_src_unpack >> bar_src_install" > > You have my strong opposition on such change as well. It will turn > ebuilds into unreadable and undpredictable mess, please do not do that > I'm not sure I follow your complaint. He is talking about adding one line to an ebuild. I'm not sure how that is unreadable, and the algorithm you quoted looks fairly predictable to me as well. Certainly it is less convenient than not having to do anything to pull in eclass-defined phase functions, and it requires ebuilds to be updated when eclasses are updated to add new phase functions. That could be problematic for cases like KDE/X11/etc where you have a large collection of short ebuilds with all the logic in an eclass. I just want to make sure I'm understanding your concern in case there is a new issue being raised. Rich