From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2799E13832E for ; Sat, 20 Aug 2016 16:43:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 42B81E0853; Sat, 20 Aug 2016 16:43:34 +0000 (UTC) Received: from mail-ua0-f180.google.com (mail-ua0-f180.google.com [209.85.217.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 38726E083A for ; Sat, 20 Aug 2016 16:43:33 +0000 (UTC) Received: by mail-ua0-f180.google.com with SMTP id n59so127361257uan.2 for ; Sat, 20 Aug 2016 09:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=BwrQhHq5BQ7IZv0VNWFGsEnMstvKTCZy6vToy9cYq8M=; b=s8i5KiyTyDJtaXlzBZdeUiUVqi+XROdNtHbLT22D9IpT8Z7HTHgCS+6IOCJFVls0RW 68d13omVzIcCHnnl6gAbPxiHu88Hq9F5zwTDgrX6PBN7DaerMcqIk151TqP5Zv/ZGnVB gr2IreyBjXIR6pIWMHu/8OAbl4QuoA80X/kFlBQcExeLnN0z0RCDsEb58woBcuj1VC3C f1MBSGd6zCTGNHt6nSoQAaDvV1yp2qnqw+SXLvrh/d/LXWbgYrHfGde3mHus7+NgdT2V 83Ez0BSuC38mBMG1DfRt72N8dwZTwCDB5OyM2HKLebv+EWRa6r0CXsSYcXlNIoFShalp U7Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=BwrQhHq5BQ7IZv0VNWFGsEnMstvKTCZy6vToy9cYq8M=; b=PogHQbpVhS5IbUvdoq7Qn+ZMeOQElDQF6p+FmB2vDpPCPMPNMvfGAYqNkZGK1ZWsiZ FVNBeiLYwikJip3F9U4bB6B4I0kG/7+P53k02/8DVUwLUlPXlZdVaS7lwVaKTXwu3fxX eAP+oyzyYbOgUI8m7StTCUEmDMi1Q1SwicthRS6kvJvTwnKw4VKirwVMiuciGsSXnxaV 91UqRVedoi7OoJyHgpV4StRrgN/QutTBjDo3KUL/keeSMhBbeVJH9rv7heK1b2WVlPnI IhlhNJXVQ9Z0wRwHqbFOlFZ8yi5r6QjO11D90Vtc44IZV4oYQfoJVhptG9tZDkDGWFIn 8LSA== X-Gm-Message-State: AEkooutYd+Tk+DrWgoxsoLJO6GoejNBLPdAS+vvQr2LCA25mZzJ4OOu9lSQGTfyhPv/jgzkuUXuGXC3AX0J5Eg== X-Received: by 10.31.97.4 with SMTP id v4mr7380253vkb.38.1471711412129; Sat, 20 Aug 2016 09:43:32 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.31.178.71 with HTTP; Sat, 20 Aug 2016 09:42:51 -0700 (PDT) In-Reply-To: <20160806170539.82e500a7965303b5526c7689@gentoo.org> References: <20160729183158.254fcaefbe2485ad8ad5e3d8@gentoo.org> <20160729174241.337d0793.mgorny@gentoo.org> <20160729223601.b66b48bb392db1cb391f5049@gentoo.org> <20160730073708.7dcfb01a.mgorny@gentoo.org> <20160730123407.1d5ac5b737bc74d7c1684a92@gentoo.org> <20160806170539.82e500a7965303b5526c7689@gentoo.org> From: Raymond Jennings Date: Sat, 20 Aug 2016 09:42:51 -0700 Message-ID: Subject: Re: [gentoo-dev] [PATCH] subversion.eclass: support for EAPI 6 To: gentoo-dev Content-Type: multipart/alternative; boundary=94eb2c0948b2ee9510053a838362 X-Archives-Salt: a99eca4d-b44a-4406-b6db-67428155cc5c X-Archives-Hash: e0799383b45b37aa96c1f7e9e7e2c807 --94eb2c0948b2ee9510053a838362 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Just an FYI, games-emulation/dosbox tripped over this recently. On Sat, Aug 6, 2016 at 7:05 AM, Andrew Savchenko wrote= : > Hi, > > On Sat, 30 Jul 2016 12:34:07 +0300 Andrew Savchenko wrote: > > On Sat, 30 Jul 2016 07:37:08 +0200 Micha=C5=82 G=C3=B3rny wrote: > > > > @@ -116,7 +123,8 @@ ESVN_PROJECT=3D"${ESVN_PROJECT:-${PN/-svn}}" > > > > > > > > # @ECLASS-VARIABLE: ESVN_BOOTSTRAP > > > > # @DESCRIPTION: > > > > -# bootstrap script or command like autogen.sh or etc.. > > > > +# Bootstrap script or command like autogen.sh or etc.. > > > > +# Removed in EAPI 6 and later. > > > > ESVN_BOOTSTRAP=3D"${ESVN_BOOTSTRAP:-}" > > > > > > > > # @ECLASS-VARIABLE: ESVN_PATCHES > > > > @@ -127,6 +135,8 @@ ESVN_BOOTSTRAP=3D"${ESVN_BOOTSTRAP:-}" > > > > # > > > > # Patches are searched both in ${PWD} and ${FILESDIR}, if not foun= d > in either > > > > # location, the installation dies. > > > > +# > > > > +# Removed in EAPI 6 and later, use PATCHES instead. > > > > ESVN_PATCHES=3D"${ESVN_PATCHES:-}" > > > > > > It would be a good idea to check if the variables are set and die if > > > they are, so people don't accidentally use them. > > > > Impossible to implement. These variables (as well as all other > > ESVN_* variables) are usually set after subversion eclass is > > inherited. And even if I'll duplicate this check in all available > > functions (which is ridiculous by itself), it still will not help, > > since several functions are removed from EAPI 6 and people may > > rely on default behaviour of src_prepare() alone. > > > > > > # @ECLASS-VARIABLE: ESVN_RESTRICT > > > > @@ -355,7 +365,10 @@ subversion_fetch() { > > > > # @FUNCTION: subversion_bootstrap > > > > # @DESCRIPTION: > > > > # Apply patches in ${ESVN_PATCHES} and run ${ESVN_BOOTSTRAP} if > specified. > > > > +# Removed in EAPI 6 and later. > > > > subversion_bootstrap() { > > > > + has "${EAPI:-0}" 6 && die "${FUNCNAME[1]} is removed from > subversion.eclass in EAPI 6 and later" > > > > + > > > > > > Reverse the logic. This will require updating in every EAPI while it = is > > > rather unlikely the next EAPIs will return to previous behavior. > > > > Done. > > No further comments for a week =3D> in the tree now. > Thank you for review. > > Best regards, > Andrew Savchenko > --94eb2c0948b2ee9510053a838362 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Just an FYI, games-emulation/dosbox tripped over this rece= ntly.

On Sat= , Aug 6, 2016 at 7:05 AM, Andrew Savchenko <bircoph@gentoo.org> wrote:
Hi,

On Sat, 30 Jul 2016 12:34:07 +0300 Andrew Savchenko wrote:
> On Sat, 30 Jul 2016 07:37:08 +0200 Micha=C5=82 G=C3=B3rny wrote:
> > > @@ -116,7 +123,8 @@ ESVN_PROJECT=3D"${ESVN_PROJECT:-${PN/-svn}}"
> > >
> > >=C2=A0 # @ECLASS-VARIABLE: ESVN_BOOTSTRAP
> > >=C2=A0 # @DESCRIPTION:
> > > -# bootstrap script or command like autogen.sh or etc..
> > > +# Bootstrap script or command like autogen.sh or etc..
> > > +# Removed in EAPI 6 and later.
> > >=C2=A0 ESVN_BOOTSTRAP=3D"${ESVN_BOOTSTRAP:-}"<= br> > > >
> > >=C2=A0 # @ECLASS-VARIABLE: ESVN_PATCHES
> > > @@ -127,6 +135,8 @@ ESVN_BOOTSTRAP=3D"${ESVN_BOOTS= TRAP:-}"
> > >=C2=A0 #
> > >=C2=A0 # Patches are searched both in ${PWD} and ${FILESDIR},= if not found in either
> > >=C2=A0 # location, the installation dies.
> > > +#
> > > +# Removed in EAPI 6 and later, use PATCHES instead.
> > >=C2=A0 ESVN_PATCHES=3D"${ESVN_PATCHES:-}"
> >
> > It would be a good idea to check if the variables are set and die= if
> > they are, so people don't accidentally use them.
>
> Impossible to implement. These variables (as well as all other
> ESVN_* variables) are usually set after subversion eclass is
> inherited. And even if I'll duplicate this check in all available<= br> > functions (which is ridiculous by itself), it still will not help,
> since several functions are removed from EAPI 6 and people may
> rely on default behaviour of src_prepare() alone.
>
> > >=C2=A0 # @ECLASS-VARIABLE: ESVN_RESTRICT
> > > @@ -355,7 +365,10 @@ subversion_fetch() {
> > >=C2=A0 # @FUNCTION: subversion_bootstrap
> > >=C2=A0 # @DESCRIPTION:
> > >=C2=A0 # Apply patches in ${ESVN_PATCHES} and run ${ESVN_BOOT= STRAP} if specified.
> > > +# Removed in EAPI 6 and later.
> > >=C2=A0 subversion_bootstrap() {
> > > + has "${EAPI:-0}" 6 && die "${FUNCNA= ME[1]} is removed from subversion.eclass in EAPI 6 and later"
> > > +
> >
> > Reverse the logic. This will require updating in every EAPI while= it is
> > rather unlikely the next EAPIs will return to previous behavior.<= br> >
> Done.

No further comments for a week =3D> in the tree now.
Thank you for review.

Best regards,
Andrew Savchenko

--94eb2c0948b2ee9510053a838362--