From: Markos Chandras <hwoarang@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] DESCRIPTION="Based on the ${ECLASS} eclass"
Date: Mon, 17 Sep 2012 09:41:02 +0100 [thread overview]
Message-ID: <CAG2jQ8jAuBVANm981AhxkTZ8r4Lo0LcJiRzF+MyUwYiKN3LfQg@mail.gmail.com> (raw)
In-Reply-To: <20120915095912.57285308@pomiocik.lan>
On Sat, Sep 15, 2012 at 8:59 AM, Michał Górny <mgorny@gentoo.org> wrote:
> On Fri, 14 Sep 2012 19:43:42 -0400
> "Rick \"Zero_Chaos\" Farina" <zerochaos@gentoo.org> wrote:
>
>> On 09/14/2012 05:27 PM, Michał Górny wrote:
>> > On Fri, 14 Sep 2012 17:18:16 -0400
>> > "Rick \"Zero_Chaos\" Farina" <zerochaos@gentoo.org> wrote:
>> >
>> >> -----BEGIN PGP SIGNED MESSAGE-----
>> >> Hash: SHA1
>> >>
>> >> On 09/14/2012 04:56 PM, Ciaran McCreesh wrote:
>> >>> On Fri, 14 Sep 2012 16:51:54 -0400
>> >>> "Rick \"Zero_Chaos\" Farina" <zerochaos@gentoo.org> wrote:
>> >>>> I have a personal vendetta on this subject. Several eclasses set
>> >>>> a completely worthless description (and even more set a mostly
>> >>>> worthless DESCRIPTION) which ends up contaminating the
>> >>>> DESCRIPTION for an ebuild when inherit is done after DESCRIPTION
>> >>>> is set.
>> >>>
>> >>> http://article.gmane.org/gmane.linux.gentoo.devel/78813/
>> >>>
>> >>>> I realize that most of you will find this a little pedantic,
>> >>>> however, I find that needing to move my DESCRIPTION to below the
>> >>>> inherit often severely affects the readability of the ebuild, and
>> >>>> all to avoid a completely (or nearly) worthless DESCRIPTION from
>> >>>> contaminating my environment.
>> >>>
>> >>> You want your inherit line to be as near as the top as possible.
>> >>> The only things you should have before the inherit line are EAPI
>> >>> and any variables used by eclasses to determine behaviour.
>> >>>
>> >>>
>> >> I have a nasty habit of writing ebuilds to be both live and
>> >> versioned which requires me to test ${PV} then set things like
>> >> inherit VCS, SRC-URI, and KEYWORDS below. The large if block
>> >> looks better in my opinion below the settings which are the same
>> >> for all versions, rather than in the middle.
>> >>
>> >> Yes, it's a readability issue, but the point is, this shouldn't be
>> >> an issue at all.
>> >
>> > Use unifdef. Look at my overlay, and my ebuilds in the tree.
>> >
>>
>> So just so we are clear, everyone but me thinks that
>> DESCRIPTION="Based on the ${ECLASS} eclass" is a completely useful
>> and critically required piece of code?
>
> No. We agree with you that it is useless but you are saying that with
> a *completely* wrong reasoning.
>
>> Until that point I'll probably keep bringing this up.
>
> Don't forget to threaten us that you'll leave Gentoo.
>
> --
> Best regards,
> Michał Górny
This was uncalled-for. I see no such tone from his e-mails. We need no
more flames. We had enough of these already.
--
Regards,
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
next prev parent reply other threads:[~2012-09-17 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 20:51 [gentoo-dev] DESCRIPTION="Based on the ${ECLASS} eclass" Rick "Zero_Chaos" Farina
2012-09-14 20:56 ` Ciaran McCreesh
2012-09-14 21:18 ` Rick "Zero_Chaos" Farina
2012-09-14 21:27 ` Michał Górny
2012-09-14 23:43 ` Rick "Zero_Chaos" Farina
2012-09-15 4:16 ` Mike Gilbert
2012-09-15 7:59 ` Michał Górny
2012-09-15 19:13 ` Rick "Zero_Chaos" Farina
2012-09-17 8:41 ` Markos Chandras [this message]
2012-09-15 15:06 ` [gentoo-dev] " Duncan
2012-09-15 17:01 ` Zac Medico
2012-09-16 3:30 ` Duncan
2012-09-15 0:23 ` [gentoo-dev] " Mike Frysinger
2012-09-15 9:01 ` Sergei Trofimovich
2012-09-15 11:52 ` Kent Fredric
2012-09-15 14:59 ` [gentoo-dev] " Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG2jQ8jAuBVANm981AhxkTZ8r4Lo0LcJiRzF+MyUwYiKN3LfQg@mail.gmail.com \
--to=hwoarang@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox