[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[Samuli Suominen]

If you don't use double [[ then ${ROOT} will need "" quoting

On 08/04/2012 12:29 AM, William Hubbs (williamh) wrote:
> williamh    12/08/03 21:29:17
>
>    Modified:             udev-187-r1.ebuild udev-9999.ebuild ChangeLog
>    Log:
>    Add a warning for bug #429466 wrt the /lib/udev->/usr/lib/udev
>    migration.
>
>    (Portage version: 2.2.0_alpha120/cvs/Linux i686)
>
> Revision  Changes    Path
> 1.2                  sys-fs/udev/udev-187-r1.ebuild
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/udev-187-r1.ebuild?rev=1.2&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/udev-187-r1.ebuild?rev=1.2&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/udev-187-r1.ebuild?r1=1.1&r2=1.2
>
> Index: udev-187-r1.ebuild
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/sys-fs/udev/udev-187-r1.ebuild,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- udev-187-r1.ebuild	3 Aug 2012 00:57:06 -0000	1.1
> +++ udev-187-r1.ebuild	3 Aug 2012 21:29:16 -0000	1.2
> @@ -1,6 +1,6 @@
>   # Copyright 1999-2012 Gentoo Foundation
>   # Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/sys-fs/udev/udev-187-r1.ebuild,v 1.1 2012/08/03 00:57:06 williamh Exp $
> +# $Header: /var/cvsroot/gentoo-x86/sys-fs/udev/udev-187-r1.ebuild,v 1.2 2012/08/03 21:29:16 williamh Exp $
>
>   EAPI=4
>
> @@ -381,6 +381,17 @@
>   	ewarn "If you are using standalone udev, consolekithandles this"
>   	ewarn "functionality."
>
> +	if [ -d ${ROOT}/lib/udev ]
> +	then
> +		ewarn
> +		ewarn "This version of udev moves the files that were installed in"
> +		ewarn "/lib/udev to /usr/lib/udev."
> +		ewarn "We include a backward compatibility patch for gentoo to"
> +		ewarn "allow the rules in /lib/udev/rules.d to be read. However,"
> +		ewarn "bugs should be filed against packages that are installing"
> +	ewarn "files in /lib/udev so they can be fixed."
> +	fi
> +
>   	ewarn
>   	ewarn "You need to restart udev as soon as possible to make the upgrade go"
>   	ewarn "into affect."
>
>
>
> 1.102                sys-fs/udev/udev-9999.ebuild
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/udev-9999.ebuild?rev=1.102&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/udev-9999.ebuild?rev=1.102&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/udev-9999.ebuild?r1=1.101&r2=1.102
>
> Index: udev-9999.ebuild
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/sys-fs/udev/udev-9999.ebuild,v
> retrieving revision 1.101
> retrieving revision 1.102
> diff -u -r1.101 -r1.102
> --- udev-9999.ebuild	3 Aug 2012 00:57:06 -0000	1.101
> +++ udev-9999.ebuild	3 Aug 2012 21:29:16 -0000	1.102
> @@ -1,6 +1,6 @@
>   # Copyright 1999-2012 Gentoo Foundation
>   # Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/sys-fs/udev/udev-9999.ebuild,v 1.101 2012/08/03 00:57:06 williamh Exp $
> +# $Header: /var/cvsroot/gentoo-x86/sys-fs/udev/udev-9999.ebuild,v 1.102 2012/08/03 21:29:16 williamh Exp $
>
>   EAPI=4
>
> @@ -381,6 +381,17 @@
>   	ewarn "If you are using standalone udev, consolekithandles this"
>   	ewarn "functionality."
>
> +	if [ -d ${ROOT}/lib/udev ]
> +	then
> +		ewarn
> +		ewarn "This version of udev moves the files that were installed in"
> +		ewarn "/lib/udev to /usr/lib/udev."
> +		ewarn "We include a backward compatibility patch for gentoo to"
> +		ewarn "allow the rules in /lib/udev/rules.d to be read. However,"
> +		ewarn "bugs should be filed against packages that are installing"
> +	ewarn "files in /lib/udev so they can be fixed."
> +	fi
> +
>   	ewarn
>   	ewarn "You need to restart udev as soon as possible to make the upgrade go"
>   	ewarn "into affect."
>
>
>
> 1.704                sys-fs/udev/ChangeLog
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/ChangeLog?rev=1.704&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/ChangeLog?rev=1.704&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-fs/udev/ChangeLog?r1=1.703&r2=1.704
>
> Index: ChangeLog
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/sys-fs/udev/ChangeLog,v
> retrieving revision 1.703
> retrieving revision 1.704
> diff -u -r1.703 -r1.704
> --- ChangeLog	3 Aug 2012 00:57:06 -0000	1.703
> +++ ChangeLog	3 Aug 2012 21:29:16 -0000	1.704
> @@ -1,6 +1,10 @@
>   # ChangeLog for sys-fs/udev
>   # Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
> -# $Header: /var/cvsroot/gentoo-x86/sys-fs/udev/ChangeLog,v 1.703 2012/08/03 00:57:06 williamh Exp $
> +# $Header: /var/cvsroot/gentoo-x86/sys-fs/udev/ChangeLog,v 1.704 2012/08/03 21:29:16 williamh Exp $
> +
> +  03 Aug 2012; William Hubbs <williamh@gentoo.org> udev-187-r1.ebuild,
> +  udev-9999.ebuild:
> +  Add a warning for bug #429466 wrt the /lib/udev->/usr/lib/udev migration.
>
>   *udev-187-r1 (03 Aug 2012)
>
>
>
>
>

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[Doug Goldstein]

On Sat, Aug 4, 2012 at 2:31 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> If you don't use double [[ then ${ROOT} will need "" quoting
>

Don't do top post code reviews. Snip out the context and do code
reviews inline so that your feedback is meaningful. Top posting and
leaving the entire commit with CVS metadata and all is just wasteful
and silly.

-- 
Doug Goldstein

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[William Hubbs]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Sat, Aug 04, 2012 at 02:22:52PM -0500, Doug Goldstein wrote:
> On Sat, Aug 4, 2012 at 2:31 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> > If you don't use double [[ then ${ROOT} will need "" quoting
> >
> 
> Don't do top post code reviews. Snip out the context and do code
> reviews inline so that your feedback is meaningful. Top posting and
> leaving the entire commit with CVS metadata and all is just wasteful
> and silly.

This has been fixed.

WRT Doug's request, the important part is "snip out the context". Don't
just insert comments and leave the entire commit in the message.

Thanks,

William


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[Marc Schiffbauer]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Am Samstag, 4. August 2012, 10:31:05 schrieb Samuli Suominen:
> > +	if [ -d ${ROOT}/lib/udev ]

> If you don't use double [[ then ${ROOT} will need "" quoting

This was only true if ${ROOT} stood there on its own. IMO if you have
${ROOT}/foo you do not need "" quoting because even if $ROOT is empty you will 
not get a syntaxt error.

-Marc
-- 
0x35A64134 - 8AAC 5F46 83B4 DB70 8317  3723 296C 6CCA 35A6 4134

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[Peter Stuge]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Marc Schiffbauer wrote:
> > > +	if [ -d ${ROOT}/lib/udev ]
> 
> > If you don't use double [[ then ${ROOT} will need "" quoting
> 
> This was only true if ${ROOT} stood there on its own. IMO if you have
> ${ROOT}/foo you do not need "" quoting because even if $ROOT is empty
> you will not get a syntaxt error.

I think you will run into trouble if it contains whitespace.


//Peter

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[Diego Elio Pettenò]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On 05/08/2012 16:20, Marc Schiffbauer wrote:
> This was only true if ${ROOT} stood there on its own. IMO if you have
> ${ROOT}/foo you do not need "" quoting because even if $ROOT is empty you will 
> not get a syntaxt error.

Different issue I guess, here's it's about having spaces in there, not
the syntax error.

-- 
Diego Elio Pettenò — Flameeyes
flameeyes@flameeyes.eu — http://blog.flameeyes.eu/


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 554 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog

[Marc Schiffbauer]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Am Montag, 6. August 2012, 01:25:44 schrieb Peter Stuge:
> Marc Schiffbauer wrote:
> > > > +	if [ -d ${ROOT}/lib/udev ]
> > > 
> > > If you don't use double [[ then ${ROOT} will need "" quoting
> > 
> > This was only true if ${ROOT} stood there on its own. IMO if you have
> > ${ROOT}/foo you do not need "" quoting because even if $ROOT is empty
> > you will not get a syntaxt error.
> 
> I think you will run into trouble if it contains whitespace.

Indeed. Convinced.

-Marc
-- 
0x35A64134 - 8AAC 5F46 83B4 DB70 8317  3723 296C 6CCA 35A6 4134

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 190 bytes --]