From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0C23E138359 for ; Tue, 8 Sep 2020 16:10:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4B24FE086F; Tue, 8 Sep 2020 16:10:14 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 23B29E085A for ; Tue, 8 Sep 2020 16:10:13 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id z1so19779993wrt.3 for ; Tue, 08 Sep 2020 09:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=a+/N62yLCMpvWTqJvbiZgysotDYIMI2O83SK1hbIXx0=; b=UAhTRyvob4w8wVr5uzFnRIZy5whbLGu4qZvTIXnLzlKf0gyL6qxDJFlQo/fUuJxcYZ xoGxsaWsSk05lNi00o5vlTxLke7oMpzCVBak45WY92/y/k9GTZho36L4b9sSvI/TiCbl +cGS9Gl9LQLwnGnnvUvLUv6TZwF7kzhE6WafJN9wzpDgNV7wlHK4xXtGSZWF/ajKj3+i RnNFGt52BcmjYVnWnpiVF4fNoCVAJidOWxrz8AkeAVNPdRV5HffGh5+5+HOKOgYUdzSv kRUfXwYlwlX8mp8ppGyg6n6106Ywnmm/xi5N/UDvgClQoJ8lgjnqPR9GdAVuVlONe5LX xhjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=a+/N62yLCMpvWTqJvbiZgysotDYIMI2O83SK1hbIXx0=; b=rYjeSb1roUw9D+nZIJERS5noBNsakZMhR5GMsDufIX9ivYGjG0noOcXt3J+2ZRtg+I YDlCwqPuq9SXi3jYEt+fhsK3IC/yHYzYEvwu29IKGio8VGslKOFmUFXKeRn+S/yR6OfU EqIkqAr7lQS+8AjyayRYSXAA8Pj1z5KUeMggKWHT8CXl7Td7vVNp0V9/KbeHfCB682eu WEUlUxrB+KT83bwTd66F/JRR4TyNG5ja/nNXVijlax+9onhJnRWGLcRaVM3wJGmzpmUa Q2OcX2fvJOvYVn9q3s/YxJR8ZPsRNTyWEdDHrMwm8UfStmPEhK4Fy02sNZd8Pj8WqXRK FLSQ== X-Gm-Message-State: AOAM531yYZhncG+9sLtIRFWpx2zhpIpLvb1hOAcO+UwexZo7Y+TUAJKu XU3e/uiCgnfju1wiyYYS9u9DiR69RfRMnmAFQlv77BJZ X-Google-Smtp-Source: ABdhPJzSoKAfVI8Ptod7KOJT1H3V+1c4n9Zcfr2+HyOhs/u1RQpL2rKcKsS5rpDG4B0WjUtRTbQcEmeM17fffNwwg/o= X-Received: by 2002:adf:dd0e:: with SMTP id a14mr355241wrm.151.1599581412561; Tue, 08 Sep 2020 09:10:12 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <874ko8w9ap.fsf@gmail.com> In-Reply-To: From: David Michael Date: Tue, 8 Sep 2020 12:10:01 -0400 Message-ID: Subject: Re: [gentoo-dev] [PATCH 1/2] acct-group.eclass: declare the missing dependency on shadow To: gentoo-dev@lists.gentoo.org Cc: floppym@gentoo.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: e2de4cea-e195-4ff5-90c5-c1dad7677c3a X-Archives-Hash: 364438629f44ac2f7a6238055cc75012 On Tue, Sep 8, 2020 at 12:04 PM Micha=C5=82 G=C3=B3rny = wrote: > On Tue, 2020-09-08 at 11:57 -0400, David Michael wrote: > > Signed-off-by: David Michael > > --- > > eclass/acct-group.eclass | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/eclass/acct-group.eclass b/eclass/acct-group.eclass > > index 19a378e0b06..56e6391ef42 100644 > > --- a/eclass/acct-group.eclass > > +++ b/eclass/acct-group.eclass > > @@ -34,8 +34,12 @@ > > if [[ -z ${_ACCT_GROUP_ECLASS} ]]; then > > _ACCT_GROUP_ECLASS=3D1 > > > > +# The groupadd utility is called in pkg_preinst. It should be in IDEP= END. > > case ${EAPI:-0} in > > - 7) ;; > > + 7) > > + BDEPEND=3D"userland_GNU? ( sys-apps/shadow )" > > Nothing from shadow is used in src_install, so this BDEPEND is > unnecessary. It is a workaround for EAPI 7's lack of IDEPEND to attempt to handle cross-compiling, where RDEPEND alone would never attempt to install the package in the native root. Other packages and eclasses have been using this convention for the same reason (Emacs, fcaps.eclass, etc.). Thanks. David