* [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build
@ 2023-08-23 6:50 Michał Górny
2023-08-23 6:59 ` Sam James
2023-08-23 14:11 ` Matt Turner
0 siblings, 2 replies; 3+ messages in thread
From: Michał Górny @ 2023-08-23 6:50 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
eclass/cmake.eclass | 1 -
1 file changed, 1 deletion(-)
diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
index fb3f9b6352be..d0f6d0b4bd91 100644
--- a/eclass/cmake.eclass
+++ b/eclass/cmake.eclass
@@ -661,7 +661,6 @@ cmake_build() {
OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
*) eninja "$@" ;;
esac
- eninja "$@"
;;
esac
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build
2023-08-23 6:50 [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build Michał Górny
@ 2023-08-23 6:59 ` Sam James
2023-08-23 14:11 ` Matt Turner
1 sibling, 0 replies; 3+ messages in thread
From: Sam James @ 2023-08-23 6:59 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
Michał Górny <mgorny@gentoo.org> writes:
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> eclass/cmake.eclass | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
> index fb3f9b6352be..d0f6d0b4bd91 100644
> --- a/eclass/cmake.eclass
> +++ b/eclass/cmake.eclass
> @@ -661,7 +661,6 @@ cmake_build() {
> OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
> *) eninja "$@" ;;
> esac
> - eninja "$@"
> ;;
> esac
Maybe add a `Fixes: ...`, but lgtm, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build
2023-08-23 6:50 [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build Michał Górny
2023-08-23 6:59 ` Sam James
@ 2023-08-23 14:11 ` Matt Turner
1 sibling, 0 replies; 3+ messages in thread
From: Matt Turner @ 2023-08-23 14:11 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
On Wed, Aug 23, 2023 at 2:51 AM Michał Górny <mgorny@gentoo.org> wrote:
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> eclass/cmake.eclass | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
> index fb3f9b6352be..d0f6d0b4bd91 100644
> --- a/eclass/cmake.eclass
> +++ b/eclass/cmake.eclass
> @@ -661,7 +661,6 @@ cmake_build() {
> OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
> *) eninja "$@" ;;
> esac
> - eninja "$@"
> ;;
> esac
>
> --
> 2.42.0
Oops. Thanks. Looks good to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-23 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-23 6:50 [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build Michał Górny
2023-08-23 6:59 ` Sam James
2023-08-23 14:11 ` Matt Turner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox