From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A33B1138334 for ; Fri, 1 Nov 2019 20:36:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6E161E082D; Fri, 1 Nov 2019 20:36:16 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1B588E0828 for ; Fri, 1 Nov 2019 20:36:15 +0000 (UTC) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mattst88) by smtp.gentoo.org (Postfix) with ESMTPSA id C145034C67B for ; Fri, 1 Nov 2019 20:36:14 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id s17so12208779iol.12 for ; Fri, 01 Nov 2019 13:36:14 -0700 (PDT) X-Gm-Message-State: APjAAAXZ/KXjnwm38wBzuwgdqopFdRVz/m6r2wT2DJpiYGer1J/63s+0 7mOoNNVlUskrRfA4sSwisAkodmhKXOg/ZLxgnXU= X-Google-Smtp-Source: APXvYqzyvgT9NU2H5HT9r2DLGLVccHg/Py9E/zXKXDXYHoaZ1mNkAfHZuorI+cqAh6iEgFGMvnMFNnbrp8HKEziV6LQ= X-Received: by 2002:a02:c4cf:: with SMTP id h15mr4136879jaj.112.1572640572866; Fri, 01 Nov 2019 13:36:12 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <55b42dc1-cbfd-8fa0-8bfd-433e7c92a21f@veremit.xyz> In-Reply-To: <55b42dc1-cbfd-8fa0-8bfd-433e7c92a21f@veremit.xyz> From: Matt Turner Date: Fri, 1 Nov 2019 13:36:01 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] RFC: Require full $P not just $PN on stable/keyword commit messages To: gentoo development Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: a6971911-b087-4b14-8175-0853553f5d93 X-Archives-Hash: 0f81b3edec80dc5f5ad91530dd986ac4 On Fri, Nov 1, 2019 at 12:59 PM Michael 'veremitz' Everitt wrote: > > Hello, > > I've noticed a lot of stabilisation commit messages (and a few keywording > ones too) simply state the package atom and not the relevant > release/version. I find this a little meaningless, as unless this is the > first time the package has ever been either stabilised or keyworded, it is > reasonable to expect that there is/was some transition point for a package > from when it first entered the Gentoo Repository. > > Therefore, it would be much /more/ useful to have the package-version > tagged in the commit message, so that you could easily grep logs for when a > given version of a package was stabilised, and/or keyworded. Granted, this > is more of-use in a historical context compared to a present (future?!) > one, but I would argue that it conveys more meaning -with- the version than > without. Yes, I agree we should do this. My commit messages look like: sys-apps/systemd-243-r2: ppc64 stable, bug 698766 net-misc/mosh-1.3.2: added ~alpha In the past people have argued that the version in the title is superfluous since you can get the same info from git (log|show) --stat but the same (misguided argument) can be used to justify something absurd like simply making the bug number the subject. Honestly, just put the dang version in the title.