From: Matt Turner <mattst88@gentoo.org>
To: gentoo development <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] RFC: Require full $P not just $PN on stable/keyword commit messages
Date: Fri, 1 Nov 2019 13:36:01 -0700 [thread overview]
Message-ID: <CAEdQ38GdaoZ7gh8n=qYGaCMyXe5BOL17LEwk4ggzzDZWmn2Hmg@mail.gmail.com> (raw)
In-Reply-To: <55b42dc1-cbfd-8fa0-8bfd-433e7c92a21f@veremit.xyz>
On Fri, Nov 1, 2019 at 12:59 PM Michael 'veremitz' Everitt
<gentoo@veremit.xyz> wrote:
>
> Hello,
>
> I've noticed a lot of stabilisation commit messages (and a few keywording
> ones too) simply state the package atom and not the relevant
> release/version. I find this a little meaningless, as unless this is the
> first time the package has ever been either stabilised or keyworded, it is
> reasonable to expect that there is/was some transition point for a package
> from when it first entered the Gentoo Repository.
>
> Therefore, it would be much /more/ useful to have the package-version
> tagged in the commit message, so that you could easily grep logs for when a
> given version of a package was stabilised, and/or keyworded. Granted, this
> is more of-use in a historical context compared to a present (future?!)
> one, but I would argue that it conveys more meaning -with- the version than
> without.
Yes, I agree we should do this. My commit messages look like:
sys-apps/systemd-243-r2: ppc64 stable, bug 698766
net-misc/mosh-1.3.2: added ~alpha
In the past people have argued that the version in the title is
superfluous since you can get the same info from git (log|show) --stat
but the same (misguided argument) can be used to justify something
absurd like simply making the bug number the subject.
Honestly, just put the dang version in the title.
next prev parent reply other threads:[~2019-11-01 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 19:59 [gentoo-dev] RFC: Require full $P not just $PN on stable/keyword commit messages Michael 'veremitz' Everitt
2019-11-01 20:01 ` [gentoo-dev] " Michael 'veremitz' Everitt
2019-11-01 20:36 ` Matt Turner [this message]
2019-11-01 21:11 ` [gentoo-dev] " Rich Freeman
2019-11-01 21:34 ` Michael 'veremitz' Everitt
2019-11-01 21:45 ` Mike Gilbert
2019-11-01 21:50 ` Michael 'veremitz' Everitt
2019-11-01 21:47 ` Rich Freeman
2019-11-01 23:08 ` Sergei Trofimovich
2019-11-02 8:54 ` Kent Fredric
2019-11-02 16:25 ` Michael 'veremitz' Everitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEdQ38GdaoZ7gh8n=qYGaCMyXe5BOL17LEwk4ggzzDZWmn2Hmg@mail.gmail.com' \
--to=mattst88@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox