From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3B05015800A for ; Mon, 17 Jul 2023 15:24:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9FEAFE08AD; Mon, 17 Jul 2023 15:24:19 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4F510E083B for ; Mon, 17 Jul 2023 15:24:19 +0000 (UTC) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5634808e16eso2923895eaf.2 for ; Mon, 17 Jul 2023 08:24:18 -0700 (PDT) X-Gm-Message-State: ABy/qLZDXQdEo2+b6eqFtIWbzk1kQD6wT07D6mcZUoIaquI4Cf2g7sNo 8VWRghthyylEfl5hsscIJI7zS6rhw48rEtl5bMw= X-Google-Smtp-Source: APBJJlGHguch4vmFvrtQdUYScGx1M38map/fGPm+OQoBdW4GKhmRpzlcQl059s7GIAKNrYwtFE6lTlTU5ayBSzw0KNE= X-Received: by 2002:a05:6358:6f92:b0:135:afe6:4f83 with SMTP id s18-20020a0563586f9200b00135afe64f83mr77248rwn.29.1689607456874; Mon, 17 Jul 2023 08:24:16 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20230717145104.1404135-1-mattst88@gentoo.org> <448b7985cf67f10eb3ff6fe4771d44ee97e077dc.camel@nexadn.de> In-Reply-To: <448b7985cf67f10eb3ff6fe4771d44ee97e077dc.camel@nexadn.de> From: Matt Turner Date: Mon, 17 Jul 2023 11:24:05 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilation To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: dd7ee176-e759-44b8-904d-cce4a5f88d1b X-Archives-Hash: 07c5dc289f1dd6e3f9fb588d827d3f90 On Mon, Jul 17, 2023 at 10:56=E2=80=AFAM Adrian Schollmeyer = wrote: > Am Montag, dem 17.07.2023 um 10:51 -0400 schrieb Matt Turner: > > This works similar to cmake.eclass's ${CMAKE_VERBOSE}. > > Why not use MESON_VERBOSE as well? Avoids double negation in the code > (not unset -> verbose vs. MESON_VERBOSE =3D=3D true -> verbose) and keeps > the variable naming similar to cmake.eclass. > > nex I personally agree -- I was just sending the patch as-is from GitHub.