From: Matt Turner <mattst88@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilation
Date: Mon, 17 Jul 2023 11:24:05 -0400 [thread overview]
Message-ID: <CAEdQ38GF+4asmHeosrMnCLQ7Ymbbvf94DxS4MwyGJ+O5MPCPzg@mail.gmail.com> (raw)
In-Reply-To: <448b7985cf67f10eb3ff6fe4771d44ee97e077dc.camel@nexadn.de>
On Mon, Jul 17, 2023 at 10:56 AM Adrian Schollmeyer <nex@nexadn.de> wrote:
> Am Montag, dem 17.07.2023 um 10:51 -0400 schrieb Matt Turner:
> > This works similar to cmake.eclass's ${CMAKE_VERBOSE}.
>
> Why not use MESON_VERBOSE as well? Avoids double negation in the code
> (not unset -> verbose vs. MESON_VERBOSE == true -> verbose) and keeps
> the variable naming similar to cmake.eclass.
>
> nex
I personally agree -- I was just sending the patch as-is from GitHub.
next prev parent reply other threads:[~2023-07-17 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:51 [gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilation Matt Turner
2023-07-17 14:56 ` Adrian Schollmeyer
2023-07-17 15:24 ` Matt Turner [this message]
2023-07-17 15:23 ` [gentoo-dev] " Matt Turner
2023-07-18 16:44 ` [gentoo-dev] [PATCH v2] " Matt Turner
2023-07-19 7:23 ` Florian Schmaus
2023-07-20 15:00 ` Matt Turner
2023-07-20 15:06 ` Florian Schmaus
2023-07-20 15:08 ` Matt Turner
2023-07-20 15:45 ` Mike Gilbert
2023-07-20 16:58 ` Ulrich Mueller
2023-07-20 17:11 ` Ionen Wolkens
2023-07-20 17:33 ` Ionen Wolkens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEdQ38GF+4asmHeosrMnCLQ7Ymbbvf94DxS4MwyGJ+O5MPCPzg@mail.gmail.com \
--to=mattst88@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox