From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9C8551382C5 for ; Wed, 27 May 2020 21:31:14 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5DB01E08AE; Wed, 27 May 2020 21:31:10 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 28E64E0872 for ; Wed, 27 May 2020 21:31:10 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id e2so29740164eje.13 for ; Wed, 27 May 2020 14:31:09 -0700 (PDT) X-Gm-Message-State: AOAM531HKSAtI+4YMr7o/nFQ+VS4Om5DGE5niKsBSB6RPeDDYkAMXOyN gXqcj8i0IzoDkvyG5v5KIhHEPNzeBOnOd4j2taw= X-Google-Smtp-Source: ABdhPJyBxkuyRwWRWjmUcCCyZSvEx2PC0cHMg+Rau4XqdkGuPVq2/svv3Q8H3Z8MKo9OJ5iuDFUC/VBW+rfJNvzpY30= X-Received: by 2002:a17:906:18e9:: with SMTP id e9mr293637ejf.140.1590615066241; Wed, 27 May 2020 14:31:06 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <14c8d4a89d6b419124f7a8c3aea90ae6c81b1705.camel@gentoo.org> In-Reply-To: From: Matt Turner Date: Wed, 27 May 2020 14:30:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests To: gentoo development Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 4de67c76-e3b2-4aee-9914-0852269bdedf X-Archives-Hash: 5627211625360ca842a8e57c09c7581a On Wed, May 27, 2020 at 1:14 AM Alec Warner wrote: > On Tue, May 26, 2020, 23:08 Micha=C5=82 G=C3=B3rny wr= ote: >> >> On Tue, 2020-05-26 at 20:24 -0700, Alec Warner wrote: >> > The TL;DR is that a crack team of infra-folks[0] have been putting tog= ether >> > demos of CI services and things like gitlab / gitea / gerrit and so on= . >> > >> > Some of these come in combined (e.g. gitlab offers repo hosting, code >> > review / pull reqs, CI services, and deploy services.) Some of these a= re >> > piecemeal (e.g. gerrit has code review, zuul has CI) and gitea offers >> > repo-hosting but CI is separate (e.g. drone.) >> > >> > On the infra-side, I think we are pretty happy with repo-hosting (gito= lite) >> > and repo-serving (gitweb). We are missing a CI piece and a pull-reques= t >> > piece. Most of the users using PRs use either a gitlab or github mirro= r. >> > >> > I think the value of CI is pretty obvious to me (and I see tons of use >> > cases in Infra.) We could easily build CI into our current repository >> > solution (e.g. gitolite.) However gitolite doesn't really support PRs = in a >> > uniform way and so CI is mostly for submitted code; similar to the exi= sting >> > ::gentoo repo CI offered by mgorny. >> > >> > If we build a code review solution (like gitea / gerrit) would people = use >> > it? Would you use it if you couldn't merge (because the code review >> > solution can't gpg sign your commits or merges) so a tool like the exi= sting >> > pram tool would be needed to merge? >> > >> >> Does GitLab count? Gerrit is just PITA. I think we had some concerns >> about Gitea, so I'd like to test it before deciding. GitLab OTOH works >> just fine for a lot of projects, and seems the next best thing after >> GitHub > > > Gitlab does count (we deployed and tested an onprem version.) I think the= re are some major issues with it though. > - Licensing. Gitlab-CE is available, gitlab-EE is not OSS nor OSI approv= ed and many of the features we need are EE only and are not available in CE= . It's very surprising to me that CE wouldn't work for our purposes. Debian, GNOME, KDE, XFCE, and FreeDesktop have all switched to GitLab and are using CE. It's hard to believe that Gentoo's usage or requirements would be so different as to make GitLab a non-viable option. What features of EE do you think we need?