* [gentoo-dev] [RFC PATCH] metadata: Add gnome package stabilization groups
@ 2023-07-19 16:10 Matt Turner
2023-07-21 18:22 ` [gentoo-dev] " Arthur Zamarin
2023-07-22 17:08 ` [gentoo-dev] " Florian Schmaus
0 siblings, 2 replies; 5+ messages in thread
From: Matt Turner @ 2023-07-19 16:10 UTC (permalink / raw
To: gentoo-dev; +Cc: Arthur Zamarin, Matt Turner
Signed-off-by: Matt Turner <mattst88@gentoo.org>
---
Feel free to bikeshed the location, structure, file-format, etc.
metadata/stabilization-groups/gnome/evolution | 3 +++
metadata/stabilization-groups/gnome/glib | 3 +++
metadata/stabilization-groups/gnome/gnome-shell | 4 ++++
metadata/stabilization-groups/gnome/gobject-introspection | 2 ++
metadata/stabilization-groups/gnome/sysprof | 3 +++
metadata/stabilization-groups/gnome/vala | 2 ++
metadata/stabilization-groups/gnome/vte | 3 +++
7 files changed, 20 insertions(+)
create mode 100644 metadata/stabilization-groups/gnome/evolution
create mode 100644 metadata/stabilization-groups/gnome/glib
create mode 100644 metadata/stabilization-groups/gnome/gnome-shell
create mode 100644 metadata/stabilization-groups/gnome/gobject-introspection
create mode 100644 metadata/stabilization-groups/gnome/sysprof
create mode 100644 metadata/stabilization-groups/gnome/vala
create mode 100644 metadata/stabilization-groups/gnome/vte
diff --git a/metadata/stabilization-groups/gnome/evolution b/metadata/stabilization-groups/gnome/evolution
new file mode 100644
index 000000000000..21bbcf804e94
--- /dev/null
+++ b/metadata/stabilization-groups/gnome/evolution
@@ -0,0 +1,3 @@
+gnome-extra/evolution-data-server
+gnome-extra/evolution-ews
+mail-client/evolution
diff --git a/metadata/stabilization-groups/gnome/glib b/metadata/stabilization-groups/gnome/glib
new file mode 100644
index 000000000000..51a5659dd725
--- /dev/null
+++ b/metadata/stabilization-groups/gnome/glib
@@ -0,0 +1,3 @@
+dev-libs/glib
+dev-util/gdbus-codegen
+dev-util/glib-utils
diff --git a/metadata/stabilization-groups/gnome/gnome-shell b/metadata/stabilization-groups/gnome/gnome-shell
new file mode 100644
index 000000000000..ddf76f8f88f4
--- /dev/null
+++ b/metadata/stabilization-groups/gnome/gnome-shell
@@ -0,0 +1,4 @@
+gnome-base/gnome-shell
+gnome-extra/gnome-shell-extensions
+gnome-extra/gnome-shell-frippery
+x11-wm/mutter
diff --git a/metadata/stabilization-groups/gnome/gobject-introspection b/metadata/stabilization-groups/gnome/gobject-introspection
new file mode 100644
index 000000000000..8baf4ae59124
--- /dev/null
+++ b/metadata/stabilization-groups/gnome/gobject-introspection
@@ -0,0 +1,2 @@
+dev-libs/gobject-introspection
+dev-libs/gobject-introspection-common
diff --git a/metadata/stabilization-groups/gnome/sysprof b/metadata/stabilization-groups/gnome/sysprof
new file mode 100644
index 000000000000..66a338916039
--- /dev/null
+++ b/metadata/stabilization-groups/gnome/sysprof
@@ -0,0 +1,3 @@
+dev-util/sysprof
+dev-util/sysprof-capture
+dev-util/sysprof-common
diff --git a/metadata/stabilization-groups/gnome/vala b/metadata/stabilization-groups/gnome/vala
new file mode 100644
index 000000000000..2e4d5a33748d
--- /dev/null
+++ b/metadata/stabilization-groups/gnome/vala
@@ -0,0 +1,2 @@
+dev-lang/vala
+dev-libs/vala-common
diff --git a/metadata/stabilization-groups/gnome/vte b/metadata/stabilization-groups/gnome/vte
new file mode 100644
index 000000000000..ce25ab265262
--- /dev/null
+++ b/metadata/stabilization-groups/gnome/vte
@@ -0,0 +1,3 @@
+gui-libs/vte
+gui-libs/vte-common
+x11-libs/vte
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [gentoo-dev] Re: [RFC PATCH] metadata: Add gnome package stabilization groups
2023-07-19 16:10 [gentoo-dev] [RFC PATCH] metadata: Add gnome package stabilization groups Matt Turner
@ 2023-07-21 18:22 ` Arthur Zamarin
2023-07-24 13:58 ` Matt Turner
2023-07-22 17:08 ` [gentoo-dev] " Florian Schmaus
1 sibling, 1 reply; 5+ messages in thread
From: Arthur Zamarin @ 2023-07-21 18:22 UTC (permalink / raw
To: Matt Turner, gentoo-dev
[-- Attachment #1.1: Type: text/plain, Size: 3298 bytes --]
On 19/07/2023 19.10, Matt Turner wrote:
> Signed-off-by: Matt Turner <mattst88@gentoo.org>
> ---
> Feel free to bikeshed the location, structure, file-format, etc.
>
> metadata/stabilization-groups/gnome/evolution | 3 +++
> metadata/stabilization-groups/gnome/glib | 3 +++
> metadata/stabilization-groups/gnome/gnome-shell | 4 ++++
> metadata/stabilization-groups/gnome/gobject-introspection | 2 ++
> metadata/stabilization-groups/gnome/sysprof | 3 +++
> metadata/stabilization-groups/gnome/vala | 2 ++
> metadata/stabilization-groups/gnome/vte | 3 +++
> 7 files changed, 20 insertions(+)
> create mode 100644 metadata/stabilization-groups/gnome/evolution
> create mode 100644 metadata/stabilization-groups/gnome/glib
> create mode 100644 metadata/stabilization-groups/gnome/gnome-shell
> create mode 100644 metadata/stabilization-groups/gnome/gobject-introspection
> create mode 100644 metadata/stabilization-groups/gnome/sysprof
> create mode 100644 metadata/stabilization-groups/gnome/vala
> create mode 100644 metadata/stabilization-groups/gnome/vte
>
So semi-formalizing it before I implement parsing it in pkgcore:
1. everything is located under "metadata/stabilization-groups/"
2. We search recursively as much as needed, so all files are included in
any depth.
3. Group name plays similarly to path, so here the group name would be
"@gnome/vte" (at least for `pkgdev bugs` invocations). By using full
path, we are safe from name collisions.
4. The file itself uses similar format to our various profiles files.
Ignore white-spaces before and after, "#" as a comment. Only one
"cat/pkg" per line.
5. I think for now we can go without mandatory copyright header...
How it will affect `pkgdev bugs` invocations? I'll use your sets as
example. Let's say our invocation is `pkgdev bugs dev-libs/glib
@gnome/vala`.
- if a set is passed (anything starting with @), replace it with all the
contents of that set (so "@gnome/vala" equals to "dev-libs/vala-common
dev-lang/vala").
- Drop every package from the pkglist whose latest matching package to
the restricts expression is already latest (so nothing better to do).
- pkgdev bugs builds the full graph as it does today. Let's say it
decided it needs to also add "dev-util/glib-utils".
- For every defined set, all the packages included in graph and in the
set are merged into one bug. This means we would get one bug for
"@gnome/vala" ("dev-libs/vala-common dev-lang/vala") and one bug for
"@gnome/glib" ("dev-libs/glib dev-util/glib-utils"). Notice that it
didn't add the other package in that set ("dev-util/gdbus-codegen")
since it wasn't requested or required.
Does this flow seems logical and flexible enough? I don't think auto
adding whole set if any one of it's package is required is a good idea
since it might explode? If folks want to stable the whole set, explicit
pass it as arg in the invocation.
Do note that I'm open to other flows and usages, everything is open for
me (I didn't start to implement it, just scratches in my notebook).
--
Arthur Zamarin
arthurzam@gentoo.org
Gentoo Linux developer (Python, pkgcore stack, Arch Teams, GURU)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] [RFC PATCH] metadata: Add gnome package stabilization groups
2023-07-19 16:10 [gentoo-dev] [RFC PATCH] metadata: Add gnome package stabilization groups Matt Turner
2023-07-21 18:22 ` [gentoo-dev] " Arthur Zamarin
@ 2023-07-22 17:08 ` Florian Schmaus
2023-07-22 18:40 ` Sam James
1 sibling, 1 reply; 5+ messages in thread
From: Florian Schmaus @ 2023-07-22 17:08 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1.1.1: Type: text/plain, Size: 3810 bytes --]
On 19/07/2023 18.10, Matt Turner wrote:
> Signed-off-by: Matt Turner <mattst88@gentoo.org>
> ---
> Feel free to bikeshed the location, structure, file-format, etc.
>
> metadata/stabilization-groups/gnome/evolution | 3 +++
> metadata/stabilization-groups/gnome/glib | 3 +++
> metadata/stabilization-groups/gnome/gnome-shell | 4 ++++
> metadata/stabilization-groups/gnome/gobject-introspection | 2 ++
> metadata/stabilization-groups/gnome/sysprof | 3 +++
> metadata/stabilization-groups/gnome/vala | 2 ++
> metadata/stabilization-groups/gnome/vte | 3 +++
> 7 files changed, 20 insertions(+)
> create mode 100644 metadata/stabilization-groups/gnome/evolution
> create mode 100644 metadata/stabilization-groups/gnome/glib
> create mode 100644 metadata/stabilization-groups/gnome/gnome-shell
> create mode 100644 metadata/stabilization-groups/gnome/gobject-introspection
> create mode 100644 metadata/stabilization-groups/gnome/sysprof
> create mode 100644 metadata/stabilization-groups/gnome/vala
> create mode 100644 metadata/stabilization-groups/gnome/vte
>
> diff --git a/metadata/stabilization-groups/gnome/evolution b/metadata/stabilization-groups/gnome/evolution
> new file mode 100644
> index 000000000000..21bbcf804e94
> --- /dev/null
> +++ b/metadata/stabilization-groups/gnome/evolution
> @@ -0,0 +1,3 @@
> +gnome-extra/evolution-data-server
> +gnome-extra/evolution-ews
> +mail-client/evolution
> diff --git a/metadata/stabilization-groups/gnome/glib b/metadata/stabilization-groups/gnome/glib
> new file mode 100644
> index 000000000000..51a5659dd725
> --- /dev/null
> +++ b/metadata/stabilization-groups/gnome/glib
> @@ -0,0 +1,3 @@
> +dev-libs/glib
> +dev-util/gdbus-codegen
> +dev-util/glib-utils
> diff --git a/metadata/stabilization-groups/gnome/gnome-shell b/metadata/stabilization-groups/gnome/gnome-shell
> new file mode 100644
> index 000000000000..ddf76f8f88f4
> --- /dev/null
> +++ b/metadata/stabilization-groups/gnome/gnome-shell
> @@ -0,0 +1,4 @@
> +gnome-base/gnome-shell
> +gnome-extra/gnome-shell-extensions
> +gnome-extra/gnome-shell-frippery
> +x11-wm/mutter
> diff --git a/metadata/stabilization-groups/gnome/gobject-introspection b/metadata/stabilization-groups/gnome/gobject-introspection
> new file mode 100644
> index 000000000000..8baf4ae59124
> --- /dev/null
> +++ b/metadata/stabilization-groups/gnome/gobject-introspection
> @@ -0,0 +1,2 @@
> +dev-libs/gobject-introspection
> +dev-libs/gobject-introspection-common
> diff --git a/metadata/stabilization-groups/gnome/sysprof b/metadata/stabilization-groups/gnome/sysprof
> new file mode 100644
> index 000000000000..66a338916039
> --- /dev/null
> +++ b/metadata/stabilization-groups/gnome/sysprof
> @@ -0,0 +1,3 @@
> +dev-util/sysprof
> +dev-util/sysprof-capture
> +dev-util/sysprof-common
> diff --git a/metadata/stabilization-groups/gnome/vala b/metadata/stabilization-groups/gnome/vala
> new file mode 100644
> index 000000000000..2e4d5a33748d
> --- /dev/null
> +++ b/metadata/stabilization-groups/gnome/vala
> @@ -0,0 +1,2 @@
> +dev-lang/vala
> +dev-libs/vala-common
> diff --git a/metadata/stabilization-groups/gnome/vte b/metadata/stabilization-groups/gnome/vte
> new file mode 100644
> index 000000000000..ce25ab265262
> --- /dev/null
> +++ b/metadata/stabilization-groups/gnome/vte
> @@ -0,0 +1,3 @@
> +gui-libs/vte
> +gui-libs/vte-common
> +x11-libs/vte
Couldn't stabilization groups be package sets? For example, instead of
metadata/stabilization-groups/gnome/vte
you have
sets/stable-group-gnome-vte
with the exact same content (may requires that :;gentoo declares a
sets.conf).
- Flow
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 17273 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] [RFC PATCH] metadata: Add gnome package stabilization groups
2023-07-22 17:08 ` [gentoo-dev] " Florian Schmaus
@ 2023-07-22 18:40 ` Sam James
0 siblings, 0 replies; 5+ messages in thread
From: Sam James @ 2023-07-22 18:40 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 4188 bytes --]
Florian Schmaus <flow@gentoo.org> writes:
> [[PGP Signed Part:Undecided]]
> On 19/07/2023 18.10, Matt Turner wrote:
>> Signed-off-by: Matt Turner <mattst88@gentoo.org>
>> ---
>> Feel free to bikeshed the location, structure, file-format, etc.
>> metadata/stabilization-groups/gnome/evolution | 3 +++
>> metadata/stabilization-groups/gnome/glib | 3 +++
>> metadata/stabilization-groups/gnome/gnome-shell | 4 ++++
>> metadata/stabilization-groups/gnome/gobject-introspection | 2 ++
>> metadata/stabilization-groups/gnome/sysprof | 3 +++
>> metadata/stabilization-groups/gnome/vala | 2 ++
>> metadata/stabilization-groups/gnome/vte | 3 +++
>> 7 files changed, 20 insertions(+)
>> create mode 100644 metadata/stabilization-groups/gnome/evolution
>> create mode 100644 metadata/stabilization-groups/gnome/glib
>> create mode 100644 metadata/stabilization-groups/gnome/gnome-shell
>> create mode 100644 metadata/stabilization-groups/gnome/gobject-introspection
>> create mode 100644 metadata/stabilization-groups/gnome/sysprof
>> create mode 100644 metadata/stabilization-groups/gnome/vala
>> create mode 100644 metadata/stabilization-groups/gnome/vte
>> diff --git a/metadata/stabilization-groups/gnome/evolution
>> b/metadata/stabilization-groups/gnome/evolution
>> new file mode 100644
>> index 000000000000..21bbcf804e94
>> --- /dev/null
>> +++ b/metadata/stabilization-groups/gnome/evolution
>> @@ -0,0 +1,3 @@
>> +gnome-extra/evolution-data-server
>> +gnome-extra/evolution-ews
>> +mail-client/evolution
>> diff --git a/metadata/stabilization-groups/gnome/glib b/metadata/stabilization-groups/gnome/glib
>> new file mode 100644
>> index 000000000000..51a5659dd725
>> --- /dev/null
>> +++ b/metadata/stabilization-groups/gnome/glib
>> @@ -0,0 +1,3 @@
>> +dev-libs/glib
>> +dev-util/gdbus-codegen
>> +dev-util/glib-utils
>> diff --git a/metadata/stabilization-groups/gnome/gnome-shell b/metadata/stabilization-groups/gnome/gnome-shell
>> new file mode 100644
>> index 000000000000..ddf76f8f88f4
>> --- /dev/null
>> +++ b/metadata/stabilization-groups/gnome/gnome-shell
>> @@ -0,0 +1,4 @@
>> +gnome-base/gnome-shell
>> +gnome-extra/gnome-shell-extensions
>> +gnome-extra/gnome-shell-frippery
>> +x11-wm/mutter
>> diff --git a/metadata/stabilization-groups/gnome/gobject-introspection b/metadata/stabilization-groups/gnome/gobject-introspection
>> new file mode 100644
>> index 000000000000..8baf4ae59124
>> --- /dev/null
>> +++ b/metadata/stabilization-groups/gnome/gobject-introspection
>> @@ -0,0 +1,2 @@
>> +dev-libs/gobject-introspection
>> +dev-libs/gobject-introspection-common
>> diff --git a/metadata/stabilization-groups/gnome/sysprof b/metadata/stabilization-groups/gnome/sysprof
>> new file mode 100644
>> index 000000000000..66a338916039
>> --- /dev/null
>> +++ b/metadata/stabilization-groups/gnome/sysprof
>> @@ -0,0 +1,3 @@
>> +dev-util/sysprof
>> +dev-util/sysprof-capture
>> +dev-util/sysprof-common
>> diff --git a/metadata/stabilization-groups/gnome/vala b/metadata/stabilization-groups/gnome/vala
>> new file mode 100644
>> index 000000000000..2e4d5a33748d
>> --- /dev/null
>> +++ b/metadata/stabilization-groups/gnome/vala
>> @@ -0,0 +1,2 @@
>> +dev-lang/vala
>> +dev-libs/vala-common
>> diff --git a/metadata/stabilization-groups/gnome/vte b/metadata/stabilization-groups/gnome/vte
>> new file mode 100644
>> index 000000000000..ce25ab265262
>> --- /dev/null
>> +++ b/metadata/stabilization-groups/gnome/vte
>> @@ -0,0 +1,3 @@
>> +gui-libs/vte
>> +gui-libs/vte-common
>> +x11-libs/vte
>
>
> Couldn't stabilization groups be package sets? For example, instead of
>
> metadata/stabilization-groups/gnome/vte
>
> you have
>
> sets/stable-group-gnome-vte
>
> with the exact same content (may requires that :;gentoo declares a
> sets.conf).
This then ends up polluting users' list of sets, e.g. when they run
`emerge --list-sets`, or `emerge @<TAB>`, and so on.
It had occurred to me but I decided not to suggest it for this
reason. Also, these groups aren't necessarily going to be things
users should emerge directly at all (e.g. related libraries).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [gentoo-dev] Re: [RFC PATCH] metadata: Add gnome package stabilization groups
2023-07-21 18:22 ` [gentoo-dev] " Arthur Zamarin
@ 2023-07-24 13:58 ` Matt Turner
0 siblings, 0 replies; 5+ messages in thread
From: Matt Turner @ 2023-07-24 13:58 UTC (permalink / raw
To: Arthur Zamarin; +Cc: gentoo-dev
On Fri, Jul 21, 2023 at 2:22 PM Arthur Zamarin <arthurzam@gentoo.org> wrote:
>
> On 19/07/2023 19.10, Matt Turner wrote:
> > Signed-off-by: Matt Turner <mattst88@gentoo.org>
> > ---
> > Feel free to bikeshed the location, structure, file-format, etc.
> >
> > metadata/stabilization-groups/gnome/evolution | 3 +++
> > metadata/stabilization-groups/gnome/glib | 3 +++
> > metadata/stabilization-groups/gnome/gnome-shell | 4 ++++
> > metadata/stabilization-groups/gnome/gobject-introspection | 2 ++
> > metadata/stabilization-groups/gnome/sysprof | 3 +++
> > metadata/stabilization-groups/gnome/vala | 2 ++
> > metadata/stabilization-groups/gnome/vte | 3 +++
> > 7 files changed, 20 insertions(+)
> > create mode 100644 metadata/stabilization-groups/gnome/evolution
> > create mode 100644 metadata/stabilization-groups/gnome/glib
> > create mode 100644 metadata/stabilization-groups/gnome/gnome-shell
> > create mode 100644 metadata/stabilization-groups/gnome/gobject-introspection
> > create mode 100644 metadata/stabilization-groups/gnome/sysprof
> > create mode 100644 metadata/stabilization-groups/gnome/vala
> > create mode 100644 metadata/stabilization-groups/gnome/vte
> >
>
> So semi-formalizing it before I implement parsing it in pkgcore:
>
> 1. everything is located under "metadata/stabilization-groups/"
> 2. We search recursively as much as needed, so all files are included in
> any depth.
> 3. Group name plays similarly to path, so here the group name would be
> "@gnome/vte" (at least for `pkgdev bugs` invocations). By using full
> path, we are safe from name collisions.
> 4. The file itself uses similar format to our various profiles files.
> Ignore white-spaces before and after, "#" as a comment. Only one
> "cat/pkg" per line.
> 5. I think for now we can go without mandatory copyright header...
>
>
>
> How it will affect `pkgdev bugs` invocations? I'll use your sets as
> example. Let's say our invocation is `pkgdev bugs dev-libs/glib
> @gnome/vala`.
>
> - if a set is passed (anything starting with @), replace it with all the
> contents of that set (so "@gnome/vala" equals to "dev-libs/vala-common
> dev-lang/vala").
>
> - Drop every package from the pkglist whose latest matching package to
> the restricts expression is already latest (so nothing better to do).
>
> - pkgdev bugs builds the full graph as it does today. Let's say it
> decided it needs to also add "dev-util/glib-utils".
>
> - For every defined set, all the packages included in graph and in the
> set are merged into one bug. This means we would get one bug for
> "@gnome/vala" ("dev-libs/vala-common dev-lang/vala") and one bug for
> "@gnome/glib" ("dev-libs/glib dev-util/glib-utils"). Notice that it
> didn't add the other package in that set ("dev-util/gdbus-codegen")
> since it wasn't requested or required.
>
> Does this flow seems logical and flexible enough? I don't think auto
> adding whole set if any one of it's package is required is a good idea
> since it might explode? If folks want to stable the whole set, explicit
> pass it as arg in the invocation.
>
> Do note that I'm open to other flows and usages, everything is open for
> me (I didn't start to implement it, just scratches in my notebook).
Yeah, this sounds spot on to me.
Thanks Arthur!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-24 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-19 16:10 [gentoo-dev] [RFC PATCH] metadata: Add gnome package stabilization groups Matt Turner
2023-07-21 18:22 ` [gentoo-dev] " Arthur Zamarin
2023-07-24 13:58 ` Matt Turner
2023-07-22 17:08 ` [gentoo-dev] " Florian Schmaus
2023-07-22 18:40 ` Sam James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox