From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 828C6138334 for ; Wed, 22 Aug 2018 19:20:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1F47DE09B0; Wed, 22 Aug 2018 19:20:28 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B979EE0974 for ; Wed, 22 Aug 2018 19:20:27 +0000 (UTC) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mattst88) by smtp.gentoo.org (Postfix) with ESMTPSA id 1C469335C94 for ; Wed, 22 Aug 2018 19:20:26 +0000 (UTC) Received: by mail-it0-f43.google.com with SMTP id p81-v6so4444654itp.1 for ; Wed, 22 Aug 2018 12:20:26 -0700 (PDT) X-Gm-Message-State: APzg51BNHjDH7yvCpbB2CO6PYzfD7nDKRY3pZF2KHzpJrJI2CQmRhzzV DcMqyhJDdbkH2MAx82jDUZ0q7BuntBr3EXABgPA= X-Google-Smtp-Source: ANB0VdZWRiX55B1br8UIXVSk2bclewTjnhm9XY2kELYe2pC3oBg3XEf9HvzZOKpEds7p6oQ35O3e4hz7eUBGBp/zEYk= X-Received: by 2002:a02:a886:: with SMTP id l6-v6mr6429393jam.105.1534965624172; Wed, 22 Aug 2018 12:20:24 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <5cc35530-3d96-1a0f-b484-73ea3d58bed5@gentoo.org> In-Reply-To: <5cc35530-3d96-1a0f-b484-73ea3d58bed5@gentoo.org> From: Matt Turner Date: Wed, 22 Aug 2018 12:20:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] Gentoo i486 support To: gentoo development Cc: Gentoo x86 AT , release@gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 25c522d5-21bc-44f1-ad22-835b65acc9c1 X-Archives-Hash: 1400045097ea6154ff96f24ca0f5bf2d On Wed, Aug 22, 2018 at 5:26 AM Ben Kohler wrote: > 2) Patch catalyst to start setting CXXFLAGS again. Rather than roll > back to exactly CXXFLAGS="${CFLAGS}" again, it's been suggested that we > start setting COMMON_FLAGS, and CFLAGS="${COMMON_FLAGS}" > CXXFLAGS=${COMMON_FLAGS}" etc. I prepared such a patch a while back > [4], which seems to work but may need a bit of updating. [snip] > [2] > https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=b409bd9bb4b50f69a555e4e148057ade86a7ed16 I don't think that was intentional, was it? That commit looks like it's supposed to just be a plain refactor (It's titled "stagebase.py: Refactor the *FLAGS handling code in chroot_setup()" after all) so it shouldn't have changed behavior. I'm guessing the commit is just broken. It doesn't even look like the commit message was finished when it was pushed. I think you should do whatever is required to fix catalyst brokenness.