From: Matt Turner <mattst88@gentoo.org>
To: gentoo development <gentoo-dev@lists.gentoo.org>
Cc: Gentoo x86 AT <x86@gentoo.org>, release@gentoo.org
Subject: Re: [gentoo-dev] Gentoo i486 support
Date: Wed, 22 Aug 2018 12:20:11 -0700 [thread overview]
Message-ID: <CAEdQ38EC2=7d05tnSR9ArGuC0S=no=Q3KkNs8ueZTKzfvkLx7g@mail.gmail.com> (raw)
In-Reply-To: <5cc35530-3d96-1a0f-b484-73ea3d58bed5@gentoo.org>
On Wed, Aug 22, 2018 at 5:26 AM Ben Kohler <bkohler@gentoo.org> wrote:
> 2) Patch catalyst to start setting CXXFLAGS again. Rather than roll
> back to exactly CXXFLAGS="${CFLAGS}" again, it's been suggested that we
> start setting COMMON_FLAGS, and CFLAGS="${COMMON_FLAGS}"
> CXXFLAGS=${COMMON_FLAGS}" etc. I prepared such a patch a while back
> [4], which seems to work but may need a bit of updating.
[snip]
> [2]
> https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=b409bd9bb4b50f69a555e4e148057ade86a7ed16
I don't think that was intentional, was it?
That commit looks like it's supposed to just be a plain refactor (It's
titled "stagebase.py: Refactor the *FLAGS handling code in
chroot_setup()" after all) so it shouldn't have changed behavior. I'm
guessing the commit is just broken. It doesn't even look like the
commit message was finished when it was pushed.
I think you should do whatever is required to fix catalyst brokenness.
next prev parent reply other threads:[~2018-08-22 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 12:26 [gentoo-dev] Gentoo i486 support Ben Kohler
2018-08-22 13:08 ` Rich Freeman
2018-08-22 13:23 ` Mart Raudsepp
2018-08-22 14:22 ` Peter Stuge
2018-08-22 20:27 ` R0b0t1
2018-08-22 20:39 ` Rich Freeman
2018-08-25 11:07 ` Andrew Savchenko
2018-08-22 13:21 ` James Le Cuirot
2018-08-22 14:30 ` Mike Gilbert
2018-08-22 15:27 ` Thomas Deutschmann
2018-08-22 19:20 ` Matt Turner [this message]
2018-08-22 19:27 ` M. J. Everitt
2018-08-22 20:19 ` Richard Yao
2018-08-24 13:19 ` Kent Fredric
2018-08-24 13:57 ` Mike Gilbert
2018-08-24 14:13 ` Rich Freeman
2018-08-24 14:40 ` Kent Fredric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEdQ38EC2=7d05tnSR9ArGuC0S=no=Q3KkNs8ueZTKzfvkLx7g@mail.gmail.com' \
--to=mattst88@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=release@gentoo.org \
--cc=x86@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox