From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
by finch.gentoo.org with esmtp (Exim 4.60)
(envelope-from <gentoo-dev+bounces-49882-garchives=archives.gentoo.org@lists.gentoo.org>)
id 1S0G5c-0002kN-40
for garchives@archives.gentoo.org; Wed, 22 Feb 2012 17:34:52 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id CBD91E10F8;
Wed, 22 Feb 2012 17:34:36 +0000 (UTC)
Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com [209.85.215.53])
by pigeon.gentoo.org (Postfix) with ESMTP id 6B00BE077C
for <gentoo-dev@lists.gentoo.org>; Wed, 22 Feb 2012 17:33:55 +0000 (UTC)
Received: by lahd3 with SMTP id d3so335902lah.40
for <gentoo-dev@lists.gentoo.org>; Wed, 22 Feb 2012 09:33:55 -0800 (PST)
Received-SPF: pass (google.com: domain of matthew.summers@liquidustech.com designates 10.152.128.202 as permitted sender) client-ip=10.152.128.202;
Authentication-Results: mr.google.com; spf=pass (google.com: domain of matthew.summers@liquidustech.com designates 10.152.128.202 as permitted sender) smtp.mail=matthew.summers@liquidustech.com
Received: from mr.google.com ([10.152.128.202])
by 10.152.128.202 with SMTP id nq10mr23597218lab.11.1329932035329 (num_hops = 1);
Wed, 22 Feb 2012 09:33:55 -0800 (PST)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Received: by 10.152.128.202 with SMTP id nq10mr19851742lab.11.1329932035247;
Wed, 22 Feb 2012 09:33:55 -0800 (PST)
Sender: matthew.summers@liquidustech.com
Received: by 10.152.5.197 with HTTP; Wed, 22 Feb 2012 09:33:55 -0800 (PST)
In-Reply-To: <1329862452.25132.0.camel@keitaro>
References: <4F40D7C3.1070906@gentoo.org>
<1329862452.25132.0.camel@keitaro>
Date: Wed, 22 Feb 2012 11:33:55 -0600
X-Google-Sender-Auth: aQKO3WnfRmAzUifFbITfJUD-eIY
Message-ID: <CAET+hMTXnB+7+RqHWRWDka2FbKDBds_5j6pfOTx4LdMPZsoaZQ@mail.gmail.com>
Subject: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
From: Matthew Summers <quantumsummers@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Gm-Message-State: ALoCoQmjbuyITnJT68zdnO37pSR8BV7H1UL4RfwKE7KBD6VvJvqAjbBg9ScfNhTG7P+xwxm34qej
X-Archives-Salt: 4451e9a1-fe16-4a38-ac36-c004ab9291bc
X-Archives-Hash: 6a5a7974703c8eb08cbe07586173779c
On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@gentoo.org> wro=
te:
> Le dimanche 19 f=C3=A9vrier 2012 =C3=A0 12:06 +0100, Justin a =C3=A9crit =
:
>> Hi,
>>
>> any objections against following patch for subversion.eclass?
>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
>> reemerge of a package.
>>
>>
>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
>> @@ -469,7 +469,9 @@
>> =C2=A0 =C2=A0 =C2=A0 local target=3D"${1}"
>> =C2=A0 =C2=A0 =C2=A0 local key=3D"${2}"
>>
>> - =C2=A0 =C2=A0 env LC_ALL=3DC svn info "${target}" | grep -i "^${key}" =
| cut -d" " -f2-
>> + =C2=A0 =C2=A0 env LC_ALL=3DC svn info \
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${options} --username "${ESV=
N_USER}" --password "${ESVN_PASSWORD}" \
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "${target}" | grep -i "^${ke=
y}" | cut -d" " -f2-
>> =C2=A0}
>>
>> =C2=A0## -- subversion__get_repository_uri()
>> --------------------------------------- #
>
> I'm not an expert of the subversion eclass, but the diff looks good.
>
> --
> Gilles Dartiguelongue <eva@gentoo.org>
> Gentoo
Why would you want a password in an ebuild? The var ESVN_PASSWORD
seems like trouble to me.
--=20
Matthew W. Summers
Gentoo Foundation Inc.