From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RtRNd-0006fQ-Cd for garchives@archives.gentoo.org; Fri, 03 Feb 2012 22:13:17 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EA2C5E07C9; Fri, 3 Feb 2012 22:12:28 +0000 (UTC) Received: from mail-tul01m020-f181.google.com (mail-tul01m020-f181.google.com [209.85.214.181]) by pigeon.gentoo.org (Postfix) with ESMTP id E90ABE070F for ; Fri, 3 Feb 2012 22:11:09 +0000 (UTC) Received: by obbup10 with SMTP id up10so5591153obb.40 for ; Fri, 03 Feb 2012 14:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type; bh=VHFJOU0/h11YeXieW+md2SFHzY3GQ4YgClc+KU+5TxU=; b=waqKgGL+u5cetROIqayy9YdyYd6YKrzcuDL04b9jBQZDFAr7NQ+04sJOwmnJG/Jn42 X7wIK5IABxqX2xGXgkM69UFM06jw6AY+UQnJ6T/smDLDSoDbEBR9wOrnpAnUnxiFVUyO zVzcZUpZVSmbNX1PDCKwKLn+CMtpGMF1e8dD4= Received: by 10.182.11.41 with SMTP id n9mr8279652obb.24.1328307069331; Fri, 03 Feb 2012 14:11:09 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Sender: nirbheek.chauhan@gmail.com Received: by 10.60.14.69 with HTTP; Fri, 3 Feb 2012 14:10:49 -0800 (PST) In-Reply-To: <201202031427.23101.vapier@gentoo.org> References: <201202030456.43456.vapier@gentoo.org> <201202031427.23101.vapier@gentoo.org> From: Nirbheek Chauhan Date: Sat, 4 Feb 2012 03:40:49 +0530 X-Google-Sender-Auth: w-8dQxxgpHywpLoaEoipL-vAqd0 Message-ID: Subject: Re: [gentoo-dev] Re: RFC: New eclass: mozlinguas.eclass To: gentoo-dev@lists.gentoo.org Content-Type: multipart/alternative; boundary=f46d044794650529e004b8169701 X-Archives-Salt: b7ece1be-75b6-4017-a153-b63a9d0808a8 X-Archives-Hash: 0129b633ed0ac7be914bd2447f2b6824 --f46d044794650529e004b8169701 Content-Type: text/plain; charset=UTF-8 On Sat, Feb 4, 2012 at 12:57 AM, Mike Frysinger wrote: > On Friday 03 February 2012 11:44:42 Nirbheek Chauhan wrote: > > On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger > wrote: > > >> mozlinguas() { > > > > > > missing eclass documentation > > > > Is it really needed for private functions? Nothing should ever call this. > > needed ? no. nice ? sure. up to you as the maintainer, but the eclass > doc > format does support @INTERNAL on functions so it doesn't get exported to > the > man page. > Okay, that was my only concern (eclass doc). The function itself is documented in the second line of the function body. I just moved that up now. -- ~Nirbheek Chauhan Gentoo GNOME+Mozilla Team --f46d044794650529e004b8169701 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Sat, Feb 4, 2012 at 12:57 AM, Mike Frysinger = <vapier@gentoo.or= g> wrote:
On Friday 03 February 2012 11:44:42 Nirbheek Chauhan wrot= e:
> On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> >> mozlinguas() {
> >
> > missing eclass documentation
>
> Is it really needed for private functions? Nothing should ever call th= is.

needed ? =C2=A0no. =C2=A0nice ? =C2=A0sure. =C2=A0up to you as the ma= intainer, but the eclass doc
format does support @INTERNAL on functions so it doesn't get exported t= o the
man page.
<= /blockquote>

Okay, that was my only concern (eclass doc). The func= tion itself is documented in the second line of the function body. I just m= oved that up now.

--
~Nirbheek Chauhan

Gentoo GNOME+Mozilla Team
--f46d044794650529e004b8169701--