Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test

[Davide Pesavento <pesa@gentoo.org>]

On Tue, Aug 21, 2018 at 11:57 AM Davide Pesavento <pesa@gentoo.org> wrote:
>
> On Tue, Aug 21, 2018 at 2:46 AM Michał Górny <mgorny@gentoo.org> wrote:
> >
> > On Tue, 2018-08-21 at 01:54 -0400, Davide Pesavento wrote:
> > > On Mon, Aug 20, 2018 at 11:00 AM Michał Górny <mgorny@gentoo.org> wrote:
> > > >
> > > > Improve the description of USE=test to clearly indicate what the flag
> > > > does instead of claiming it workaround for Portage.
> > > > ---
> > > >  profiles/use.desc | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Changed in v2: added description of FEATURES=test relevance
> > > >
> > > > diff --git a/profiles/use.desc b/profiles/use.desc
> > > > index 078226b92250..bd360194a09b 100644
> > > > --- a/profiles/use.desc
> > > > +++ b/profiles/use.desc
> > > > @@ -338,7 +338,7 @@ taglib - Enable tagging support with taglib
> > > >  tcl - Add support the Tcl language
> > > >  tcmalloc - Use the dev-util/google-perftools libraries to replace the malloc() implementation with a possibly faster one
> > > >  tcpd - Add support for TCP wrappers
> > > > -test - Workaround to pull in packages needed to run with FEATURES=test. Portage-2.1.2 handles this internally, so don't set it in make.conf/package.use anymore
> > > > +test - Enable dependencies and/or preparations necessary to run tests (usually automatically controled by FEATURES=test but can be switched independently)
> > >
> > > s/controled/controlled/
> > > s/switched/enabled/
> >
> > It can also be disabled.  Maybe 'toggled'?
> >
>
> Wait, are you saying that I can set USE=-test while FEATURES=test is
> enabled? Is that a valid combination?

make.conf(5) says the following regarding FEATURES=test:

    This feature implies the "test"USE flag if it is a member of IUSE,
either explicitly or implicitly [...]. The "test" USE flag is also
automatically disabled when the "test" feature is disabled.

So, it looks like the whole "independently" part in the use desc is incorrect.