From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.77) (envelope-from ) id 1Spzco-0004r9-Qu for garchives@archives.gentoo.org; Sat, 14 Jul 2012 10:30:59 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 240E221C011; Sat, 14 Jul 2012 10:30:44 +0000 (UTC) Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com [209.85.160.53]) by pigeon.gentoo.org (Postfix) with ESMTP id C50AEE077A for ; Sat, 14 Jul 2012 10:30:00 +0000 (UTC) Received: by pbbrr13 with SMTP id rr13so7997705pbb.40 for ; Sat, 14 Jul 2012 03:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=baV2Jrdd4epKxiHR5s5v2pKLd4t1PXZTRHr9iaTDfSU=; b=Ves2t+w5Aq5mtkmltnKACAL6nI23t7INDKSwxPP/c0NQU8FGCD7oJeqj+LdkEBFIRn sY+RVrXaiIiaEK4R11onKyYBK2kNtsNuqTJdyldpy6zns9fTeL2ldfH081C/ruhz5/Mc asaLGDBbTKti0wBclHaLOnGwuvSNY/Yfia7+EM4RYI/zU+RFxUNleEGCxPJ4bicsuwGF 3JKdcFlfeuH04jgWvFH7vBIyBz+y5gMU1fc5JqvILFAe9AkNVjhqDHJv8c71j81VNQmB 4tWqFtJ3HmvGRhDhcf18txnsfpx/M0X4jzAHxxzOZMGRBMH6HFNnklJ+WWIM8958//+s I+3Q== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.68.194.169 with SMTP id hx9mr11016663pbc.8.1342261800021; Sat, 14 Jul 2012 03:30:00 -0700 (PDT) Sender: davidepesa@gmail.com Received: by 10.66.41.51 with HTTP; Sat, 14 Jul 2012 03:29:59 -0700 (PDT) In-Reply-To: <20120713095057.186f3dc3@gentoo.org> References: <20120713083456.61c78c04@gentoo.org> <20120713095057.186f3dc3@gentoo.org> Date: Sat, 14 Jul 2012 12:29:59 +0200 X-Google-Sender-Auth: LZOWCZ8MenVUQHsw7JkpET7tzgM Message-ID: Subject: Re: [gentoo-dev] RFC: using array variables in qt4-r2.eclass From: Davide Pesavento To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 X-Archives-Salt: ea9ad2f5-4c32-4361-ac13-6e0a6e58a977 X-Archives-Hash: a4fd363f0f87ce7c5e0f2224daa95e06 On Fri, Jul 13, 2012 at 3:50 PM, Alexis Ballier wrote: > On Fri, 13 Jul 2012 15:26:58 +0200 > Davide Pesavento wrote: > >> > [...] >> >> + # backward compatibility for non-array variables >> >> + if [[ -n ${DOCS} ]] && [[ "$(declare -p DOCS 2>/dev/null >> >> 2>&1)" != "declare -a"* ]]; then >> >> + dodoc ${DOCS} || die "dodoc failed" >> >> + fi >> >> + if [[ -n ${HTML_DOCS} ]] && [[ "$(declare -p HTML_DOCS >> >> 2>/dev/null 2>&1)" != "declare -a"* ]]; then >> >> + dohtml -r ${HTML_DOCS} || die "dohtml failed" >> >> + fi >> >> } >> > >> > maybe issue an eqawarn in that case telling people to convert to >> > arrays; some time later make this an ewarn telling non-array support >> > will be removed and again later make this a die :) >> > (if you take that route i would expect you to start converting >> > packages to use arrays) >> > >> >> We have no intention of deprecating non-array variables in qt4-r2 >> eclass. > > why ? having two codepaths for the same thing, one being inferior, > sounds like a good reason to deprecate the inferior one :) > > A. > Maintaining these two codepaths has practically zero cost, while forcing every ebuild using qt4-r2 to switch to arrays would waste developers' time which is better spent elsewhere. Furthermore, the non-array variant is not necessarily inferior, because it allows you to use bash globbing, brace expansion, etc... Thanks, Pesa