From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-73438-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 2E1A81384B4
	for <garchives@archives.gentoo.org>; Mon, 30 Nov 2015 17:40:44 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 12C7021C080;
	Mon, 30 Nov 2015 17:40:35 +0000 (UTC)
Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 0699821C012
	for <gentoo-dev@lists.gentoo.org>; Mon, 30 Nov 2015 17:40:33 +0000 (UTC)
Received: by lfaz4 with SMTP id z4so207250677lfa.0
        for <gentoo-dev@lists.gentoo.org>; Mon, 30 Nov 2015 09:40:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:content-type;
        bh=P1LoGoV/nuUpMwQjSoHsIhsr3t9rBN2ZImj7bqs9hyE=;
        b=jzGYb661njfJEgz5rUN1P54h/Cpxrx5jvUEXaVDcL71Qncpu1pce5ipCiXwXT8Y/Pe
         SMFPaMx3s+k1EzcquyW+K9hMf+riJwrd2cRbmawv4Xsd7NG4FUGb5A89vZh9q5Pp2C+q
         usvh7BtfiQYTUU3/zUFGuKEUxvdReMnyCWhFEvr/rMeU0VT+WPGAbal/QwuoxY1vedAi
         Se12tYw72quH4S+RB3oi6SgszI0XrwwSjl5h31JLscEu1onC3w7zElVZCo4F3dsQMZp+
         lh7lIRyWMFvzZFBSU4LBUowD+wHdvKfowgDVU4kmh3jvhZwrY4MPQjYRbgEVFh1v1t+y
         ZeiA==
X-Received: by 10.112.139.230 with SMTP id rb6mr25405886lbb.138.1448905232410;
 Mon, 30 Nov 2015 09:40:32 -0800 (PST)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Sender: davidepesa@gmail.com
Received: by 10.112.137.232 with HTTP; Mon, 30 Nov 2015 09:40:12 -0800 (PST)
In-Reply-To: <5659CD63.2080000@gentoo.org>
References: <1448717061-11581-1-git-send-email-jlec@gentoo.org>
 <1448717061-11581-9-git-send-email-jlec@gentoo.org> <CADfzvvaP3tQTV7i+hJKSeG_30wcr2khgJWVNXmpxRJr1F-6MSQ@mail.gmail.com>
 <5659CD63.2080000@gentoo.org>
From: Davide Pesavento <pesa@gentoo.org>
Date: Mon, 30 Nov 2015 18:40:12 +0100
X-Google-Sender-Auth: Y7cE5U7ELBUS-vSHo0duPBL8Drc
Message-ID: <CADfzvvaiKdC_OF40=aQ6md7JYnn+nLcyr6HfvBQuz4PZtFR=0Q@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into
 single virtx()
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=UTF-8
X-Archives-Salt: aeafe3d7-06fd-4a21-8788-ce6663dee0db
X-Archives-Hash: 4d64a70b736a920d46c05a77d484ac88

On Sat, Nov 28, 2015 at 4:50 PM, Justin Lecher (jlec) <jlec@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 28/11/15 16:28, Davide Pesavento wrote:
>>> else -               nonfatal ${VIRTUALX_COMMAND} "$@" +
>>> nonfatal "$@"
>>
>> Please take the opportunity to clean this up, possibly only in
>> EAPI=6 if you don't want to risk breaking existing ebuilds. See bug
>> 517976 for details.
>>
>>> retval=$?
>
> The return value is recorded and gets evaluated correctly.
>
> src_test() {
>         virtx false
> }
>
[...]
>
> Am I missing something?

The scenario of bug 517976 is different. I think a minimized test case
is the following (untested):

foo() {
    die "meh"
    return 0
}

src_test() {
    virtx foo
}