From: Davide Pesavento <pesa@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()
Date: Mon, 30 Nov 2015 18:40:12 +0100 [thread overview]
Message-ID: <CADfzvvaiKdC_OF40=aQ6md7JYnn+nLcyr6HfvBQuz4PZtFR=0Q@mail.gmail.com> (raw)
In-Reply-To: <5659CD63.2080000@gentoo.org>
On Sat, Nov 28, 2015 at 4:50 PM, Justin Lecher (jlec) <jlec@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 28/11/15 16:28, Davide Pesavento wrote:
>>> else - nonfatal ${VIRTUALX_COMMAND} "$@" +
>>> nonfatal "$@"
>>
>> Please take the opportunity to clean this up, possibly only in
>> EAPI=6 if you don't want to risk breaking existing ebuilds. See bug
>> 517976 for details.
>>
>>> retval=$?
>
> The return value is recorded and gets evaluated correctly.
>
> src_test() {
> virtx false
> }
>
[...]
>
> Am I missing something?
The scenario of bug 517976 is different. I think a minimized test case
is the following (untested):
foo() {
die "meh"
return 0
}
src_test() {
virtx foo
}
next prev parent reply other threads:[~2015-11-30 17:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 13:24 [gentoo-dev] [PATCH 0/8] virtualx.eclass: New API and EAPI=6 support Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle supported EAPIs Justin Lecher
2015-11-28 14:46 ` Davide Pesavento
2015-11-28 13:24 ` [gentoo-dev] [PATCH 2/8] virtualx.eclass: Only source eclass once Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 3/8] virtualx.eclass: Use eqawarn instead of ewarn "QA:..." Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 Justin Lecher
2015-11-28 14:03 ` Michał Górny
2015-11-28 14:08 ` Justin Lecher (jlec)
2015-11-28 15:57 ` Michał Górny
2015-11-28 15:59 ` Justin Lecher (jlec)
2015-11-28 13:24 ` [gentoo-dev] [PATCH 5/8] virtualx.eclass: Support EAPI=6 Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 6/8] virtualx.eclass: Whitespace cleanup Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 7/8] virtualx.eclass: Add missing die Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx() Justin Lecher
2015-11-28 15:28 ` Davide Pesavento
2015-11-28 15:50 ` Justin Lecher (jlec)
2015-11-30 17:40 ` Davide Pesavento [this message]
2015-12-01 7:25 ` Justin Lecher (jlec)
2015-11-28 14:02 ` [gentoo-dev] [PATCH 0/8] virtualx.eclass: New API and EAPI=6 support Michał Górny
2015-11-28 16:20 ` [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle supported EAPIs Justin Lecher
2015-11-28 16:20 ` [gentoo-dev] [PATCH 2/8] virtualx.eclass: Only source eclass once Justin Lecher
2015-11-28 16:20 ` [gentoo-dev] [PATCH 3/8] virtualx.eclass: Use eqawarn instead of ewarn "QA:..." Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 Justin Lecher
2015-11-29 9:57 ` Michał Górny
2015-11-29 12:02 ` Justin Lecher (jlec)
2015-11-29 12:24 ` [gentoo-dev] [PATCH 0/8] virtualx.eclass updates version 3 Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle supported EAPIs Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 2/8] virtualx.eclass: Only source eclass once Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 3/8] virtualx.eclass: Use eqawarn instead of ewarn "QA:..." Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 4/8] virtualx.eclass: Whitespace cleanup Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 5/8] virtualx.eclass: Add missing die Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 6/8] virtualx.eclass: Simplify API into single virtx() Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 7/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 Justin Lecher
2015-11-29 13:21 ` Michał Górny
2015-11-29 12:24 ` [gentoo-dev] [PATCH 8/8] virtualx.eclass: Support EAPI=6 Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 5/8] virtualx.eclass: Whitespace cleanup Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 6/8] virtualx.eclass: Add missing die Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 7/8] virtualx.eclass: Simplify API into single virtx() Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 8/8] virtualx.eclass: Support EAPI=6 Justin Lecher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADfzvvaiKdC_OF40=aQ6md7JYnn+nLcyr6HfvBQuz4PZtFR=0Q@mail.gmail.com' \
--to=pesa@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox