From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-73369-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id B8B981384B4
	for <garchives@archives.gentoo.org>; Sat, 28 Nov 2015 14:46:37 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id DE85121C0C0;
	Sat, 28 Nov 2015 14:46:28 +0000 (UTC)
Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id A6CF021C010
	for <gentoo-dev@lists.gentoo.org>; Sat, 28 Nov 2015 14:46:27 +0000 (UTC)
Received: by lffu14 with SMTP id u14so154510246lff.1
        for <gentoo-dev@lists.gentoo.org>; Sat, 28 Nov 2015 06:46:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=9EwifoxqT9esiQIe3ByiGyog2AKRtgCM1fAaIV9u5Qs=;
        b=x6rTsTjBTB79NODGuM8ai2ET7Jv3QA7/T6hgtiLYahDSYi8b0Swo63M0gBhphbUOb3
         QuQm9Y5UR8MAli38cI1TsepGe2sxYpEfsgmOBtedagLIDinQJaikG3AACS+UX1wGiUII
         /05sWaG6l4M/B9xmaFUVXsl7dpF8UmLQD0tYCsQiML99qG5mmYBmE8rz8ni0tkRH04Q9
         lE+Ib+p9sVdXeTW4HE9KKHwOk7KCcbII/XhqD6Tt3wCwQXbPovb0A0E0lgHjqVTAoHzT
         8VQmdAwBE2OhZZHO8TBVcArlLSNC2yZMOag6bl8rmNKPzdBkO6RIgv5J6h6jDQ9w1Qpj
         kcIQ==
X-Received: by 10.25.83.146 with SMTP id h140mr11242501lfb.52.1448721986110;
 Sat, 28 Nov 2015 06:46:26 -0800 (PST)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Sender: davidepesa@gmail.com
Received: by 10.112.137.232 with HTTP; Sat, 28 Nov 2015 06:46:06 -0800 (PST)
In-Reply-To: <1448717061-11581-2-git-send-email-jlec@gentoo.org>
References: <1448717061-11581-1-git-send-email-jlec@gentoo.org> <1448717061-11581-2-git-send-email-jlec@gentoo.org>
From: Davide Pesavento <pesa@gentoo.org>
Date: Sat, 28 Nov 2015 15:46:06 +0100
X-Google-Sender-Auth: eA4rObLBG7MkWqPVpZbigudo6qo
Message-ID: <CADfzvvadQYNt2T33aXXCjM1DKQhzmSOkOURmia=49xL+_MaY2A@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle
 supported EAPIs
To: gentoo-dev@lists.gentoo.org
Cc: Justin Lecher <jlec@gentoo.org>
Content-Type: text/plain; charset=UTF-8
X-Archives-Salt: e4b259f0-f316-4b44-8a5f-a2b3d67b8d0e
X-Archives-Hash: 440412f4f28fb608bee50f4c5cc40489

On Sat, Nov 28, 2015 at 2:24 PM, Justin Lecher <jlec@gentoo.org> wrote:
> Signed-off-by: Justin Lecher <jlec@gentoo.org>
> ---
>  eclass/virtualx.eclass | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> index 5d27ed9..584fb29 100644
> --- a/eclass/virtualx.eclass
> +++ b/eclass/virtualx.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2012 Gentoo Foundation
> +# Copyright 1999-2015 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  # $Id$
>
> @@ -9,6 +9,17 @@
>  # Original author: Martin Schlemmer <azarah@gentoo.org>
>  # @BLURB: This eclass can be used for packages that needs a working X environment to build.
>
> +case "${EAPI:-0}" in
> +       0|1)
> +               die "virtualx eclass require EAPI=2 or newer."

require -> requires

[nitpicking, feel free to ignore] Technically "2 or newer" is not
correct and not future-proof. You can rephrase to something like
"virtualx.eclass: EAPI ${EAPI} is too old".