From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.77) (envelope-from ) id 1SqMaB-00060y-Ht for garchives@archives.gentoo.org; Sun, 15 Jul 2012 11:01:47 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5AE43E05EB; Sun, 15 Jul 2012 11:01:28 +0000 (UTC) Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com [209.85.160.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 60F3EE0566 for ; Sun, 15 Jul 2012 11:00:48 +0000 (UTC) Received: by pbbrr13 with SMTP id rr13so9615651pbb.40 for ; Sun, 15 Jul 2012 04:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZcmpKlmIqQQF4h04l61dZ74uRyqiK9+QuVbxKPT5uGE=; b=IXVGqOApcf2F1btHqk4ZxkUnmlTdywKNdwoMb77ScXg1L/toP1pCbTNt1v3oSm1YAg //4SvdfybnSnvdRmBdEx3XcuQ+bjrshx4BMaC4p/so3wAhiZnBfo4Pos4MLhp8xvmnU7 bqByc1f7wtHb2mkzBtIpfBrdaDCSeMRTAbTsfb85McgveHDCznS2xxfAwbEDJgTlr99h /R+KRMnBEpha3lPsRpdvDWjLPoEW7GLelnzC9h2jIDRG9VutcQEuyM53TDu8jHD+ShAg aw03m8gFfMH4mYOen69LIuzrvLoYa7BuS+8yxjayR4//wzU3VQvs+P57rSuUqMMuJYOa zbuA== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.66.74.66 with SMTP id r2mr14957409pav.45.1342350047641; Sun, 15 Jul 2012 04:00:47 -0700 (PDT) Sender: davidepesa@gmail.com Received: by 10.66.41.51 with HTTP; Sun, 15 Jul 2012 04:00:47 -0700 (PDT) In-Reply-To: <20120714160042.7e8ea9b8@pomiocik.lan> References: <20120713083456.61c78c04@gentoo.org> <20120713095057.186f3dc3@gentoo.org> <20120714160042.7e8ea9b8@pomiocik.lan> Date: Sun, 15 Jul 2012 13:00:47 +0200 X-Google-Sender-Auth: nMCuHSHf4ITI7VTufMt9nwIsgs0 Message-ID: Subject: Re: [gentoo-dev] RFC: using array variables in qt4-r2.eclass From: Davide Pesavento To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 5a0920bc-5bab-4b63-9af4-bc47b3dbf8dc X-Archives-Hash: c1814203799947cd49b2674a79105a0a On Sat, Jul 14, 2012 at 4:00 PM, Micha=C5=82 G=C3=B3rny = wrote: > On Sat, 14 Jul 2012 12:29:59 +0200 > Davide Pesavento wrote: > >> On Fri, Jul 13, 2012 at 3:50 PM, Alexis Ballier >> wrote: >> > On Fri, 13 Jul 2012 15:26:58 +0200 >> > Davide Pesavento wrote: >> > >> >> > [...] >> >> >> + # backward compatibility for non-array variables >> >> >> + if [[ -n ${DOCS} ]] && [[ "$(declare -p DOCS 2>/dev/null >> >> >> 2>&1)" !=3D "declare -a"* ]]; then >> >> >> + dodoc ${DOCS} || die "dodoc failed" >> >> >> + fi >> >> >> + if [[ -n ${HTML_DOCS} ]] && [[ "$(declare -p HTML_DOCS >> >> >> 2>/dev/null 2>&1)" !=3D "declare -a"* ]]; then >> >> >> + dohtml -r ${HTML_DOCS} || die "dohtml failed" >> >> >> + fi >> >> >> } >> >> > >> >> > maybe issue an eqawarn in that case telling people to convert to >> >> > arrays; some time later make this an ewarn telling non-array >> >> > support will be removed and again later make this a die :) >> >> > (if you take that route i would expect you to start converting >> >> > packages to use arrays) >> >> > >> >> >> >> We have no intention of deprecating non-array variables in qt4-r2 >> >> eclass. >> > >> > why ? having two codepaths for the same thing, one being inferior, >> > sounds like a good reason to deprecate the inferior one :) >> > >> > A. >> > >> >> Maintaining these two codepaths has practically zero cost, while >> forcing every ebuild using qt4-r2 to switch to arrays would waste >> developers' time which is better spent elsewhere. >> >> Furthermore, the non-array variant is not necessarily inferior, >> because it allows you to use bash globbing, brace expansion, etc... > > And arrays stopped to allow that overnight? > I mean that the following won't work as you might expect: DOCS=3D("*.txt") Thanks, Pesa