From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 69A1C1382C5 for ; Sun, 25 Feb 2018 11:36:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 35951E0826; Sun, 25 Feb 2018 11:36:18 +0000 (UTC) Received: from mail-oi0-x241.google.com (mail-oi0-x241.google.com [IPv6:2607:f8b0:4003:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D3041E0821 for ; Sun, 25 Feb 2018 11:36:17 +0000 (UTC) Received: by mail-oi0-x241.google.com with SMTP id c18so410051oiy.9 for ; Sun, 25 Feb 2018 03:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=oxV7SLxJixvElWhBHFvGJRCqouZ6rbT/aq/8DrcEx7I=; b=KyM3vK/koKhghfSjcbjE3hycvcY/htfaH7wjMsSohndOfCfqPuo+ALhuPfXuMS8tFj v8HSdui2V59gh3DjIgy6c64dLNdYyPTrWvaWz6tXRCjAyZJr11FIq0SVAXQoFIVbxuao /UtFjI+gJ42jrEoN+BnLvKHm/UA5XgQiYx/t89zDLewsV4uHYDLY5KhT0EicXILGOMsW 5XJctX4ED8KKfm8JqOgJ9lQ4ZZCtOys0n4ehCyoc7sJ8lIFkUjdI2hsxHpaMoKgY0XcG /hgxMYPAYfIowEnX2Zvujy7+3aLad+pBBsPHt+tAADtQtROSmUZonKVlqUnSQD6L90ED udBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=oxV7SLxJixvElWhBHFvGJRCqouZ6rbT/aq/8DrcEx7I=; b=ZV3ma22BvzwrSfjyoGGE6aPc4r+bhDcDrEoYPpWzovWmgtpwJsQ5vEWbaNxVyTcQSw M8e7nvN0iSbiNZwizSNZfETPecXVNVyXgpEorHZJaG173H3cDwhxFug+f66NvYheRymK 3qUqa1Gkw1l8NkygIuz3rfMfe1hSirO3sT6QQpt1bMOlsxMREzhHVOQL77v7iyK09oBa ZkCBB4RL9RAE/aJQmT+K5d93DtRasElsCh19Byg08gHQiX6Gh0H9edjnxUgGjiMmDbMI wJdeZtbHiUu2zPerHne1swmWz64AfJhi3MvJPYHxkPBIqqszITxMXtBgRcLFu0zHEzMy mvcA== X-Gm-Message-State: APf1xPBcmDkxihZgt7Lp0tV3/H/2xxCsD0ob2FSqge5n195VNeLf/mma UN5dvJcjaiXcTosxkEnMGNNlncyF5ibRERossczrScdr X-Google-Smtp-Source: AG47ELtjHD8Fc6CGGZjQM/3dLs7R09iu0qli0JaYa92i4loSJBUcoMCnmtfRhLws5elh2h+kZk8nNjfsfNp7Rnp486s= X-Received: by 10.202.107.77 with SMTP id g74mr4375749oic.24.1519558576588; Sun, 25 Feb 2018 03:36:16 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.202.185.67 with HTTP; Sun, 25 Feb 2018 03:36:15 -0800 (PST) In-Reply-To: <20180225090652.26182-1-mgorny@gentoo.org> References: <20180225090652.26182-1-mgorny@gentoo.org> From: Francesco Riosa Date: Sun, 25 Feb 2018 12:36:15 +0100 Message-ID: Subject: Re: [gentoo-dev] [PATCH] cmake-utils.eclass: Extend ASM rules to ASM-ATT To: gentoo development Content-Type: multipart/alternative; boundary="001a11408c7e2c4c3d056607cd54" X-Archives-Salt: 0b85b1b6-803c-45f6-927a-f8603f49910f X-Archives-Hash: d7ada5f7faa636dcbfc766ed36c888f5 --001a11408c7e2c4c3d056607cd54 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-02-25 10:06 GMT+01:00 Micha=C5=82 G=C3=B3rny : > Some CMake projects use ASM-ATT rather than ASM, so extend our rule > overrides to that. > for the curious: https://cmake.org/Wiki/CMake/Assembler#ASM-ATT ASM-ATT This can be used for assembler files in AT&T assembler syntax. This includes the GNU assembler gas. - Supported assembler names: as, gas, may have toolchain specific prefix - Supported source files extensions: .s, .asm - .S files, i.e. assembler files which require preprocessing, are not supported - Involved files: CMakeASM-ATTInformation.cmake, CMakeDetermineASM-ATTCompiler.cmake, CMakeTestASM-ATTCompiler.cmake > > Bug: https://bugs.gentoo.org/625844 > --- > eclass/cmake-utils.eclass | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass > index b9f69a824b14..ef3f3c2607f8 100644 > --- a/eclass/cmake-utils.eclass > +++ b/eclass/cmake-utils.eclass > @@ -516,6 +516,7 @@ cmake-utils_src_configure() { > fi > cat > "${build_rules}" <<- _EOF_ || die > SET (CMAKE_ASM_COMPILE_OBJECT " > ${includes} ${CPPFLAGS} -o -c " CACHE > STRING "ASM compile command" FORCE) > + SET (CMAKE_ASM-ATT_COMPILE_OBJECT " > ${includes} ${CPPFLAGS} -o -c " CACHE > STRING "ASM compile command" FORCE) > SET (CMAKE_C_COMPILE_OBJECT " > ${includes} ${CPPFLAGS} -o -c " CACHE STRING "C > compile command" FORCE) > SET (CMAKE_CXX_COMPILE_OBJECT " > ${includes} ${CPPFLAGS} -o -c " CACHE > STRING "C++ compile command" FORCE) > SET (CMAKE_Fortran_COMPILE_OBJECT > " ${includes} ${FCFLAGS} -o > -c " CACHE STRING "Fortran compile command" FORCE) > @@ -531,6 +532,7 @@ cmake-utils_src_configure() { > local toolchain_file=3D${BUILD_DIR}/gentoo_toolchain.cmake > cat > ${toolchain_file} <<- _EOF_ || die > SET (CMAKE_ASM_COMPILER "${myCC/ /;}") > + SET (CMAKE_ASM-ATT_COMPILER "${myCC/ /;}") > SET (CMAKE_C_COMPILER "${myCC/ /;}") > SET (CMAKE_CXX_COMPILER "${myCXX/ /;}") > SET (CMAKE_Fortran_COMPILER "${myFC/ /;}") > @@ -609,6 +611,7 @@ cmake-utils_src_configure() { > if [[ ${CMAKE_BUILD_TYPE} !=3D Gentoo && ${EAPI} !=3D 5 ]]; then > cat >> ${common_config} <<- _EOF_ || die > SET (CMAKE_ASM_FLAGS_${CMAKE_BUILD_TYPE^^} "" > CACHE STRING "") > + SET (CMAKE_ASM-ATT_FLAGS_${CMAKE_BUILD_TYPE^^} "" > CACHE STRING "") > SET (CMAKE_C_FLAGS_${CMAKE_BUILD_TYPE^^} "" CACHE > STRING "") > SET (CMAKE_CXX_FLAGS_${CMAKE_BUILD_TYPE^^} "" > CACHE STRING "") > SET (CMAKE_Fortran_FLAGS_${CMAKE_BUILD_TYPE^^} "" > CACHE STRING "") > -- > 2.16.2 > > > --001a11408c7e2c4c3d056607cd54 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2018-02-25 10:06 GMT+01:00 Micha=C5=82 G=C3=B3rny <= ;mgorny@gentoo.org>:
Some CM= ake projects use ASM-ATT rather than ASM, so extend our rule
overrides to that.

ASM-ATT

This can be used for assembler files in AT&T asse= mbler syntax. This includes the GNU assembler gas.

  • Supported assembler names: as, gas, may have toolchain specific pre= fix
  • Supported source files extensions= : .s, .asm
  • .S files, i.e. assembler f= iles which require preprocessing, are not supported
  • Involved files: CMakeASM-ATTInformation.cmake, CMakeDetermin= eASM-ATTCompiler.cmake, CMakeTestASM-ATTCompiler.cmake

<= div>=C2=A0

Bug: https://bugs.gentoo.org/625844
---
=C2=A0eclass/cmake-utils.eclass | 3 +++
=C2=A01 file changed, 3 insertions(+)

diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
index b9f69a824b14..ef3f3c2607f8 100644
--- a/eclass/cmake-utils.eclass
+++ b/eclass/cmake-utils.eclass
@@ -516,6 +516,7 @@ cmake-utils_src_configure() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 fi
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cat > "${build_rules}" <<- _= EOF_ || die
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_ASM_COMP= ILE_OBJECT "<CMAKE_ASM_COMPILER> <DEFINES> ${includes} ${C= PPFLAGS} <FLAGS> -o <OBJECT> -c <SOURCE>" CACHE STRI= NG "ASM compile command" FORCE)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SET (CMAKE_ASM-ATT_= COMPILE_OBJECT "<CMAKE_ASM_COMPILER> <DEFINES> ${includes}= ${CPPFLAGS} <FLAGS> -o <OBJECT> -c <SOURCE>" CACHE = STRING "ASM compile command" FORCE)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_C_COMPIL= E_OBJECT "<CMAKE_C_COMPILER> <DEFINES> ${includes} ${CPPFL= AGS} <FLAGS> -o <OBJECT> -c <SOURCE>" CACHE STRING &= quot;C compile command" FORCE)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_CXX_COMP= ILE_OBJECT "<CMAKE_CXX_COMPILER> <DEFINES> ${includes} ${C= PPFLAGS} <FLAGS> -o <OBJECT> -c <SOURCE>" CACHE STRI= NG "C++ compile command" FORCE)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_Fortran_= COMPILE_OBJECT "<CMAKE_Fortran_COMPILER> <DEFINES> ${inclu= des} ${FCFLAGS} <FLAGS> -o <OBJECT> -c <SOURCE>" CAC= HE STRING "Fortran compile command" FORCE)
@@ -531,6 +532,7 @@ cmake-utils_src_configure() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 local toolchain_file=3D${BUILD_DIR}/gentoo= _toolchain.cmake
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cat > ${toolchain_file} <<- _EOF_ || d= ie
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_ASM_COMP= ILER "${myCC/ /;}")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SET (CMAKE_ASM-ATT_= COMPILER "${myCC/ /;}")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_C_COMPIL= ER "${myCC/ /;}")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_CXX_COMP= ILER "${myCXX/ /;}")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET (CMAKE_Fortran_= COMPILER "${myFC/ /;}")
@@ -609,6 +611,7 @@ cmake-utils_src_configure() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if [[ ${CMAKE_BUILD_TYPE} !=3D Gentoo &&= ; ${EAPI} !=3D 5 ]]; then
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cat >> ${comm= on_config} <<- _EOF_ || die
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 SET (CMAKE_ASM_FLAGS_${CMAKE_BUILD_TYPE^^} "" CAC= HE STRING "")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0SET (CMAKE_ASM-ATT_FLAGS_${CMAKE_BUILD_TYPE^^} "" = CACHE STRING "")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 SET (CMAKE_C_FLAGS_${CMAKE_BUILD_TYPE^^} "" CACHE= STRING "")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 SET (CMAKE_CXX_FLAGS_${CMAKE_BUILD_TYPE^^} "" CAC= HE STRING "")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 SET (CMAKE_Fortran_FLAGS_${CMAKE_BUILD_TYPE^^} ""= CACHE STRING "")
--
2.16.2



--001a11408c7e2c4c3d056607cd54--