[gentoo-dev] meson.eclass third draft

[gentoo-dev] meson.eclass third draft

[William Hubbs]

[-- Attachment #1.1: Type: text/plain, Size: 369 bytes --]

All,

here is the third (and hopefully final) draft of meson.eclass. I am
leaving the code in for the cross support but commented so all I need to
do later is add toolchain-funcs back to inherit and uncomment the code
once I know how to write the cross file, which shouldn't take too long.
I added a link to the documentation for it in the comments.

Thanks,

William


[-- Attachment #1.2: meson.eclass --]
[-- Type: text/plain, Size: 2910 bytes --]

# Copyright 2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2

# @ECLASS: meson.eclass
# @MAINTAINER:
# William Hubbs <williamh@gentoo.org>
# @BLURB: common ebuild functions for meson-based packages
# @DESCRIPTION:
#
# @EXAMPLE:
# Typical ebuild using meson.eclass:
#
# @CODE
# EAPI=6
#
# inherit meson
#
# ...
#
# src_configure() {
# 	local emesonargs=(
# 		-Dqt4=$(usex qt4 true false)
# 		-Dthreads=$(usex threads true false)
# 		-Dtiff=$(usex tiff true false)
# 	)
# 	meson_src_configure
# }
#
# ...
#
# @CODE

case ${EAPI:-0} in
	6) ;;
	*) die "EAPI=${EAPI} is not supported" ;;
esac

EXPORT_FUNCTIONS src_configure src_compile src_test src_install

if [[ -z ${_MESON_ECLASS} ]]; then
_MESON_ECLASS=1

	inherit ninja-utils

DEPEND=">=dev-util/meson-0.39.1
	>=dev-util/ninja-1.7.2"

# @ECLASS-VARIABLE: BUILD_DIR
# @DEFAULT_UNSET
# @DESCRIPTION:
# Build directory, location where all generated files should be placed.
# If this isn't set, it defaults to ${WORKDIR}/${P}-build.

# @ECLASS-VARIABLE: EMESON_SOURCE
# @DEFAULT_UNSET
# @DESCRIPTION:
# The location of the source files for the project;this is the source
# directory to pass to meson.
# If this isn't set, it defaults to ${S}

# @VARIABLE: emesonargs
# @DEFAULT_UNSET
# @DESCRIPTION:
# Optional meson arguments as Bash array; this should be defined before
# calling meson_src_configure.

# create a cross file for meson
# fixme: populate one instead of just touching it
# _meson_create_cross_file() {
#	http://mesonbuild.com/Cross-compilation.html
#	touch "${T}"/meson.crossfile
# }

# @FUNCTION: meson_src_configure
# @DESCRIPTION:
# this is the meson_src_configure function
meson_src_configure() {
	debug-print-function ${FUNCNAME} "$@"

	# Common args
	local mesonargs=(
		--buildtype plain
		--libdir "$(get_libdir)"
		--localstatedir "${EPREFIX}/var/lib"
		--prefix "${EPREFIX}"/usr
		--sysconfdir "${EPREFIX}/etc"
		)

#	if tc-is-cross-compiler; then
#		_meson_create_cross_file || die "unable to write meson cross file"
#		mesonargs+=(
#			--cross-file "${T}"/meson.crossfile
#		)
#	fi

	# Append additional arguments from ebuild
	mesonargs+=("${emesonargs[@]}")

	BUILD_DIR="${BUILD_DIR:-${WORKDIR}/${P}-build}"
	set -- meson "${mesonargs[@]}" "$@" \
		"${EMESON_SOURCE:-${S}}" "${BUILD_DIR}"
	echo "$@"
	"$@" || die
}

# @FUNCTION: meson_src_compile
# @DESCRIPTION:
# This is the meson_src_compile function.
meson_src_compile() {
	debug-print-function ${FUNCNAME} "$@"

	eninja -v -C "${BUILD_DIR}"
}

# @FUNCTION: meson_src_test
# @DESCRIPTION:
# this is the meson_src_test function.
meson_src_test() {
	debug-print-function ${FUNCNAME} "$@"

	eninja -v -C "${BUILD_DIR}" test
}

# @FUNCTION: meson_src_install
# @DESCRIPTION:
# this is the meson_src_install function.
meson_src_install() {
	debug-print-function ${FUNCNAME} "$@"

	DESTDIR="${D}" eninja -v -C "${BUILD_DIR}" install || die
}

fi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[Mike Gilbert]

On Fri, May 5, 2017 at 11:35 AM, William Hubbs <williamh@gentoo.org> wrote:
> All,
>
> here is the third (and hopefully final) draft of meson.eclass. I am
> leaving the code in for the cross support but commented so all I need to
> do later is add toolchain-funcs back to inherit and uncomment the code
> once I know how to write the cross file, which shouldn't take too long.
> I added a link to the documentation for it in the comments.
>

You still have eninja || die in the install phase. The || die is unnecessary.

Re: [gentoo-dev] meson.eclass third draft

[William Hubbs]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

On Fri, May 05, 2017 at 12:24:03PM -0400, Mike Gilbert wrote:
> On Fri, May 5, 2017 at 11:35 AM, William Hubbs <williamh@gentoo.org> wrote:
> > All,
> >
> > here is the third (and hopefully final) draft of meson.eclass. I am
> > leaving the code in for the cross support but commented so all I need to
> > do later is add toolchain-funcs back to inherit and uncomment the code
> > once I know how to write the cross file, which shouldn't take too long.
> > I added a link to the documentation for it in the comments.
> >
> 
> You still have eninja || die in the install phase. The || die is unnecessary.
 
 Ok, that is fixed in my copy, I thought I got rid of all of those. ;-)

 Unless there are more changes, I won't send out the eclass to the list
 again, I'll just commit it on Monday and reply to this thread when I
 do.

 William


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

On pią, 2017-05-05 at 10:35 -0500, William Hubbs wrote:
> # Copyright 2017 Gentoo Foundation

Aren't we supposed to use the full range of years here?

> # Distributed under the terms of the GNU General Public License v2
> 
> # @ECLASS: meson.eclass
> # @MAINTAINER:
> # William Hubbs <williamh@gentoo.org>
> # @BLURB: common ebuild functions for meson-based packages
> # @DESCRIPTION:
> #
> # @EXAMPLE:
> # Typical ebuild using meson.eclass:
> #
> # @CODE
> # EAPI=6
> #
> # inherit meson
> #
> # ...
> #
> # src_configure() {
> # 	local emesonargs=(
> # 		-Dqt4=$(usex qt4 true false)
> # 		-Dthreads=$(usex threads true false)
> # 		-Dtiff=$(usex tiff true false)
> # 	)
> # 	meson_src_configure
> # }
> #
> # ...
> #
> # @CODE
> 
> case ${EAPI:-0} in
> 	6) ;;
> 	*) die "EAPI=${EAPI} is not supported" ;;
> esac
> 
> EXPORT_FUNCTIONS src_configure src_compile src_test src_install
> 
> if [[ -z ${_MESON_ECLASS} ]]; then
> _MESON_ECLASS=1
> 
> 	inherit ninja-utils

Extra tab on front of the line.

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[William L. Thomson Jr.]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

On Fri, 05 May 2017 18:55:41 +0200
Michał Górny <mgorny@gentoo.org> wrote:

> On pią, 2017-05-05 at 10:35 -0500, William Hubbs wrote:
> > # Copyright 2017 Gentoo Foundation  
> 
> Aren't we supposed to use the full range of years here?

It applies when something comes into existing. If this eclass did not
exist in 2016, a copyright for that year would not be correct.

This maybe different for ebuilds, as that could be considered derived
from the original ebuild. First one ever written. I am not sure the
same applies to eclasses, but it might. In that case the year of the
first eclass would be correct.

I guess it is safe to always use the oldest year. Most important is
that it has the current year if anything. Like things in tree that are
copyright 2016. Could have another copyright for 2017. Just as an
example, not really something of concern.

Though likely would be good to have a script that runs annually to
update all copyrights to current year. I do some of that myself and
need to do more....

Additional reading
http://www.copyrightlaws.com/international/copyright-notice-year/

-- 
William L. Thomson Jr.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[William L. Thomson Jr.]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On Fri, 5 May 2017 13:18:58 -0400
"William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:

> On Fri, 05 May 2017 18:55:41 +0200
> Michał Górny <mgorny@gentoo.org> wrote:
> 
> > On pią, 2017-05-05 at 10:35 -0500, William Hubbs wrote:  
> > > # Copyright 2017 Gentoo Foundation    
> > 
> > Aren't we supposed to use the full range of years here?  
> 
> It applies when something comes into existing. If this eclass did not
> exist in 2016, a copyright for that year would not be correct.
> 
> This maybe different for ebuilds, as that could be considered derived
> from the original ebuild. First one ever written. I am not sure the
> same applies to eclasses, but it might. In that case the year of the
> first eclass would be correct.
> 
> I guess it is safe to always use the oldest year. 

It may not be good to use the oldest year. Rather the first year
something came into existence.

"If the copyright duration depends on the date of first publication
and the year given in the notice is earlier than the
actual publication date, protection may be shortened by
beginning the term on the date in the notice"
https://www.copyright.gov/circs/circ03.pdf

That means if you author something in 2017, and put down say 1999-2017.
You are starting at 1999, and not 2017. Losing 16 years for no reason.

-- 
William L. Thomson Jr.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[Erik Närström]

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

I'snt copyright deth of author +70yrs?

On 5 May 2017 20:06, "William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:

> On Fri, 5 May 2017 13:18:58 -0400
> "William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:
>
> > On Fri, 05 May 2017 18:55:41 +0200
> > Michał Górny <mgorny@gentoo.org> wrote:
> >
> > > On pią, 2017-05-05 at 10:35 -0500, William Hubbs wrote:
> > > > # Copyright 2017 Gentoo Foundation
> > >
> > > Aren't we supposed to use the full range of years here?
> >
> > It applies when something comes into existing. If this eclass did not
> > exist in 2016, a copyright for that year would not be correct.
> >
> > This maybe different for ebuilds, as that could be considered derived
> > from the original ebuild. First one ever written. I am not sure the
> > same applies to eclasses, but it might. In that case the year of the
> > first eclass would be correct.
> >
> > I guess it is safe to always use the oldest year.
>
> It may not be good to use the oldest year. Rather the first year
> something came into existence.
>
> "If the copyright duration depends on the date of first publication
> and the year given in the notice is earlier than the
> actual publication date, protection may be shortened by
> beginning the term on the date in the notice"
> https://www.copyright.gov/circs/circ03.pdf
>
> That means if you author something in 2017, and put down say 1999-2017.
> You are starting at 1999, and not 2017. Losing 16 years for no reason.
>
> --
> William L. Thomson Jr.
>

[-- Attachment #2: Type: text/html, Size: 2161 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[William L. Thomson Jr.]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

On Fri, 5 May 2017 18:20:43 +0000
Erik Närström <erik.narstrom@gmail.com> wrote:

> I'snt copyright deth of author +70yrs?

Yes for work that is copyright to say you or me. Something copyright to
an immortal entity I believe is different. Even if Gentoo ended, not
sure that is the same as a person dying. We essential give up our
copyright when you put Gentoo's copyright on there. I think it would
have to include a persons name for the death term to apply.

I believe 95-120 years is the duration. 
https://www.copyright.gov/circs/circ15a.pdf

-- 
William L. Thomson Jr.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[William L. Thomson Jr.]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

On Fri, 5 May 2017 14:05:38 -0400
"William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:

> That means if you author something in 2017, and put down say
> 1999-2017. You are starting at 1999, and not 2017. Losing 16 years

Er 18.... back to 1st grade...

-- 
William L. Thomson Jr.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] OT Copyright -> meson.eclass third draft

[William L. Thomson Jr.]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On Fri, 5 May 2017 14:31:17 -0400
"William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:

> On Fri, 5 May 2017 18:20:43 +0000
> Erik Närström <erik.narstrom@gmail.com> wrote:
> 
> > I'snt copyright deth of author +70yrs?  
> 
> Yes for work that is copyright to say you or me. Something copyright
> to an immortal entity I believe is different. Even if Gentoo ended,
> not sure that is the same as a person dying. We essential give up our
> copyright when you put Gentoo's copyright on there. I think it would
> have to include a persons name for the death term to apply.
> 
> I believe 95-120 years is the duration. 
> https://www.copyright.gov/circs/circ15a.pdf
> 

That is for the United States, not the world. Seems most others go with
the author aspect. But I am not sure how that carries over to entities.
At least in the US, this stuff that is copyright Gentoo is bound to
those terms.

https://en.wikipedia.org/wiki/Copyright_term

OT....
Corporate personhood is one of the most contentious things in the US.
IMHO it was the reason for the civil war not slavery etc. If it was
slavery no need for civil rights. It was about coporate personhood. 
https://en.wikipedia.org/wiki/Corporate_personhood

This amendment, super abstract. Not sure software exists this abstract
in nature....

"As a matter of interpretation of the word "person" in the Fourteenth
Amendment, U.S. courts have extended certain constitutional protections
to corporations. "
https://en.wikipedia.org/wiki/Fourteenth_Amendment_to_the_United_States_Constitution




-- 
William L. Thomson Jr.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[Erik Närström]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Ok, that makes sense. Are from sweden where you can't give up copyright, so
didn't even think considerd that it wasn't tied to a person.


Thanks /EKG

On 5 May 2017 20:33, "William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:

> On Fri, 5 May 2017 18:20:43 +0000
> Erik Närström <erik.narstrom@gmail.com> wrote:
>
> > I'snt copyright deth of author +70yrs?
>
> Yes for work that is copyright to say you or me. Something copyright to
> an immortal entity I believe is different. Even if Gentoo ended, not
> sure that is the same as a person dying. We essential give up our
> copyright when you put Gentoo's copyright on there. I think it would
> have to include a persons name for the death term to apply.
>
> I believe 95-120 years is the duration.
> https://www.copyright.gov/circs/circ15a.pdf
>
> --
> William L. Thomson Jr.
>

[-- Attachment #2: Type: text/html, Size: 1402 bytes --]

Re: [gentoo-dev] OT Copyright -> meson.eclass third draft

[Erik Närström]

[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]

I'am far from a legal scholar, i do know that one of the main driver behind
extending the copyright to death of author +70yrs was so Disney would
continue to control miky mouse, or atlest tahat is the folk lore on the
topic. So that make it seem like even if gentoo owns the material they only
do so until 70yrs after the author deaths. Mening year of writing is
surpluses, atlest considring us copyright.

/EKG

ps. Please tell me if I only generate noise.

On 5 May 2017 20:39, "William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:

> On Fri, 5 May 2017 14:31:17 -0400
> "William L. Thomson Jr." <wlt-ml@o-sinc.com> wrote:
>
> > On Fri, 5 May 2017 18:20:43 +0000
> > Erik Närström <erik.narstrom@gmail.com> wrote:
> >
> > > I'snt copyright deth of author +70yrs?
> >
> > Yes for work that is copyright to say you or me. Something copyright
> > to an immortal entity I believe is different. Even if Gentoo ended,
> > not sure that is the same as a person dying. We essential give up our
> > copyright when you put Gentoo's copyright on there. I think it would
> > have to include a persons name for the death term to apply.
> >
> > I believe 95-120 years is the duration.
> > https://www.copyright.gov/circs/circ15a.pdf
> >
>
> That is for the United States, not the world. Seems most others go with
> the author aspect. But I am not sure how that carries over to entities.
> At least in the US, this stuff that is copyright Gentoo is bound to
> those terms.
>
> https://en.wikipedia.org/wiki/Copyright_term
>
> OT....
> Corporate personhood is one of the most contentious things in the US.
> IMHO it was the reason for the civil war not slavery etc. If it was
> slavery no need for civil rights. It was about coporate personhood.
> https://en.wikipedia.org/wiki/Corporate_personhood
>
> This amendment, super abstract. Not sure software exists this abstract
> in nature....
>
> "As a matter of interpretation of the word "person" in the Fourteenth
> Amendment, U.S. courts have extended certain constitutional protections
> to corporations. "
> https://en.wikipedia.org/wiki/Fourteenth_Amendment_to_the_
> United_States_Constitution
>
>
>
>
> --
> William L. Thomson Jr.
>

[-- Attachment #2: Type: text/html, Size: 3308 bytes --]

Re: [gentoo-dev] meson.eclass third draft

[William Hubbs]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Fri, May 05, 2017 at 10:35:43AM -0500, William Hubbs wrote:
> All,
> 
> here is the third (and hopefully final) draft of meson.eclass. I am
> leaving the code in for the cross support but commented so all I need to
> do later is add toolchain-funcs back to inherit and uncomment the code
> once I know how to write the cross file, which shouldn't take too long.
> I added a link to the documentation for it in the comments.
> 
> Thanks,

This has been committed to the tree.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=844ae0dea3592e0c1a21b4e9dae0662f535955e1

Thanks,

William


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]