public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Wolfgang E. Sanyer" <wolfgangesanyer@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Continuous integration on GURU
Date: Thu, 22 Apr 2021 09:01:19 -0400	[thread overview]
Message-ID: <CACwN4Ly47PfUV6wnMKsfeGb0bmP+Mco4tobhg4Hhnb-xOqVMwA@mail.gmail.com> (raw)
In-Reply-To: <2113586.72vocr9iq0@spectre>

On Thu, Apr 22, 2021 at 8:39 AM Agostino Sarubbo <ago@gentoo.org> wrote:
>
> On giovedì 22 aprile 2021 12:02:20 CEST Michał Górny wrote:
> > Well, I suppose scanning the dev branch would be preferable over
> > the master branch.  In reality, they are usually only a few hours apart
> > but it might be useful to know of new breakage in dev before it's merged
> > to master.
> >
> > It would be ideal if you could do a switch when master and dev are
> > in sync, and just copy the state from master.
>
> Hi,
>
> I think that your approach could be generally valid but for this use case I'm
> against because of the following:
>
> 1) The approach is valid in cases like our github PRs and the bot that
> approves the commit. In this case, who moves the commit between branches does
> not know if the scan has been done or not.
>
> 2) I don't see the reason to scan against something that we don't know if will
> be the same in master branch
>
> 3) We are not doing a similar approach for ::gentoo so I don't see why do this
> for GURU since, after all, it is an overlay
>
> 4) Packages in master are supposed to be tested at least from 2 different
> people (who made the commit in dev and who moves the commit to master) so it
> means less bugspam
>

Perhaps another approach could be to add a third branch, "staging".
Any reviewers could move the appropriate ebuilds to "staging" once all
the reviews and discussions are done but before moving to "master"

In fact, probably a github action could be set up to automatically
move to "master" after the CI stuff passes.


  parent reply	other threads:[~2021-04-22 13:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  9:59 [gentoo-dev] Continuous integration on GURU Agostino Sarubbo
2021-04-22 10:02 ` Michał Górny
2021-04-22 12:39   ` Agostino Sarubbo
2021-04-22 12:59     ` Ionen Wolkens
2021-04-22 13:11       ` Agostino Sarubbo
2021-04-22 13:23       ` Sam James
2021-04-22 13:31         ` Agostino Sarubbo
2021-04-22 13:57           ` Sam James
2021-04-22 13:01     ` Wolfgang E. Sanyer [this message]
2021-04-22 13:03     ` Michał Górny
2021-04-22 13:10     ` Andrew Ammerlaan
2021-04-22 10:22 ` Theo Anderson
2021-04-22 11:30   ` Agostino Sarubbo
2021-04-22 13:45     ` Theo Anderson
2021-04-22 13:59       ` Ionen Wolkens
2021-04-22 17:58       ` Agostino Sarubbo
2021-04-22 10:25 ` Michał Górny
2021-04-22 11:27   ` Agostino Sarubbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACwN4Ly47PfUV6wnMKsfeGb0bmP+Mco4tobhg4Hhnb-xOqVMwA@mail.gmail.com \
    --to=wolfgangesanyer@gmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox