public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ben de Groot <yngwin@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: readme.gentoo.eclass: use echo -e instead of plain echo (Was: Re: [gentoo-dev] readme.gentoo.eclass: Add a DISABLE_AUTOFORMATTING variable=
Date: Mon, 28 Jan 2013 14:37:10 +0800	[thread overview]
Message-ID: <CAB9SyzRi7gL56xsFdaL5AvAy3y9rmtW=-wic0gwjvNiNW+suPQ@mail.gmail.com> (raw)
In-Reply-To: <201301272337.06614.vapier@gentoo.org>

On 28 January 2013 12:37, Mike Frysinger <vapier@gentoo.org> wrote:
> On Sunday 27 January 2013 13:21:27 Pacho Ramos wrote:
>> The problem is that it doesn't work so well. If I have the following at
>> src_prepare (for example):
>> src_prepare() {
>>         DOC_CONTENTS="You must create a symlink rom /etc/splash/tuxonice
>> to the theme you want tuxonice to use, e.g.: \n
>>                       # ln -sfn /etc/splash/emergence /etc/splash/tuxonice \n"
>> ...
>>
>> and I handle ${DOC_CONTENTS} with quotes, it will end writing that tabs
>> also in generated file as the contents of the variable will be put
>> as-is. On the other hand, if I don't put it between quotes
>
> forcibly normalizing whitespace for all callers is wrong imo (as is sending it
> through `fmt`).  if the caller gave you content to write, it should write it.
> if the caller didn't want tabs, it shouldn't have used it in the first place.
> -mike

I've started using this eclass, but with README files, not the variable,
because this is currently the only way I can make sure it honours my
formatting.

-- 
Cheers,

Ben | yngwin
Gentoo developer
Gentoo Qt project lead, Gentoo Wiki admin


  reply	other threads:[~2013-01-28  6:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-27 14:00 [gentoo-dev] readme.gentoo.eclass: Add a DISABLE_AUTOFORMATTING variable Pacho Ramos
2013-01-27 17:47 ` readme.gentoo.eclass: use echo -e instead of plain echo (Was: Re: [gentoo-dev] readme.gentoo.eclass: Add a DISABLE_AUTOFORMATTING variable= Pacho Ramos
2013-01-27 18:05   ` Mike Frysinger
2013-01-27 18:21     ` Pacho Ramos
2013-01-28  4:37       ` Mike Frysinger
2013-01-28  6:37         ` Ben de Groot [this message]
2013-01-28 19:30           ` Pacho Ramos
2013-01-29  2:28             ` Mike Frysinger
2013-01-29  6:03             ` Ben de Groot
2013-01-29 21:47               ` Pacho Ramos
2013-01-29 22:06                 ` Michał Górny
2013-01-30  8:27                 ` Ralph Sennhauser
2013-01-30 13:24                 ` Ben de Groot
2013-01-30 18:43                   ` Pacho Ramos
2013-01-31 18:59   ` Pacho Ramos
2013-02-01  9:55     ` Ben de Groot
2013-02-01 11:07       ` Michael Weber
2013-02-01 20:34       ` Pacho Ramos
2013-02-02 11:04         ` Pacho Ramos
2013-01-31 15:22 ` [gentoo-dev] readme.gentoo.eclass: Add a DISABLE_AUTOFORMATTING variable Dan Douglas
2013-01-31 20:43   ` [gentoo-dev] " Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB9SyzRi7gL56xsFdaL5AvAy3y9rmtW=-wic0gwjvNiNW+suPQ@mail.gmail.com' \
    --to=yngwin@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox