From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-59767-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
by finch.gentoo.org (Postfix) with ESMTP id 5F9981381F3
for <garchives@archives.gentoo.org>; Mon, 22 Apr 2013 12:00:46 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 8C920E0A8E;
Mon, 22 Apr 2013 12:00:40 +0000 (UTC)
Received: from mail-ia0-f175.google.com (mail-ia0-f175.google.com [209.85.210.175])
(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id A0B3DE0A03
for <gentoo-dev@lists.gentoo.org>; Mon, 22 Apr 2013 12:00:39 +0000 (UTC)
Received: by mail-ia0-f175.google.com with SMTP id i38so1114467iae.34
for <gentoo-dev@lists.gentoo.org>; Mon, 22 Apr 2013 05:00:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20120113;
h=mime-version:x-received:reply-to:sender:in-reply-to:references:date
:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
bh=3IRW/VlTkBLkn7uFumsMpxvLfdlTnPZ5M073H2TkeWE=;
b=V2zrW+T1ZeSnrkx4i7EwNEaXn58imHucqwYIgUxEHzC+0To+z4cIbuVCxvmQAS7bx/
LtFOd2D7dKTQwsXpNdE2orjHEWgbQw1Xlkb6VZ3FILW1hahco2nsXuL8WrbohywW2kPb
VFUik0WtqhJAviZe9BXeoyv5IGxkBvJnZHynNmszs1X9BQdfxyAMeStDYwP6LUA1TeRW
v1G197vbdxbYbsMgkTNB+C4Eek1Q1uVAO/Jz4wDG7vdmmfXvUMsGrDy2vg3Q9evc9pGG
WfadwFMAn7DeJMn7UXHzlxLpfge24d5lBOH1Jf3QSWPDym3KsGy7v6yoFEWtkXzmschA
Nz/g==
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
X-Received: by 10.43.146.3 with SMTP id jw3mr11492291icc.39.1366632038910;
Mon, 22 Apr 2013 05:00:38 -0700 (PDT)
Sender: yngwin@gmail.com
Received: by 10.64.30.234 with HTTP; Mon, 22 Apr 2013 05:00:38 -0700 (PDT)
In-Reply-To: <20130421170549.41cfea49@portable>
References: <20130419091632.D01152171D@flycatcher.gentoo.org>
<20130419153043.30ffc50c@portable>
<CAB9SyzRq-RuMUU0cXnWYC_+-yv3FSJ=fDw335QmUrqQinsbzQw@mail.gmail.com>
<20130421170549.41cfea49@portable>
Date: Mon, 22 Apr 2013 20:00:38 +0800
X-Google-Sender-Auth: FZf8a9biqBPTPhPOTwClPLgAFfU
Message-ID: <CAB9SyzQ7f6145adfAcZgMVhdKWBjCHPsVSV-nTOCQbx7rt1PSA@mail.gmail.com>
Subject: Re: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit
in profiles: ChangeLog package.mask
From: Ben de Groot <yngwin@gentoo.org>
To: Alexis Ballier <aballier@gentoo.org>
Cc: gentoo-dev <gentoo-dev@lists.gentoo.org>
Content-Type: multipart/alternative; boundary=001a11c2e9aa381e1f04daf1d178
X-Archives-Salt: e070c7c8-2f26-4b76-be33-11d2557f9c4a
X-Archives-Hash: 2cd401a4ab54a36f71930f26762109a5
--001a11c2e9aa381e1f04daf1d178
Content-Type: text/plain; charset=UTF-8
On 21 April 2013 23:05, Alexis Ballier <aballier@gentoo.org> wrote:
> On Sun, 21 Apr 2013 20:53:28 +0800
> Ben de Groot <yngwin@gentoo.org> wrote:
> > >
> > > PS: btw, some hunks are weird in your commit, a locale issue ?
> > >
> >
> > No, just a line in my vimrc that removes trailing whitespace.
> >
>
> You should probably disable it or remove trailing whitespaces in a
> separate commit though. Having functional changes mixed with
> whitespace/cosmetics in a single commit makes it hard to read
> and understand.
>
> [This is really a nitpick, no need to have a debate, it's only a
> suggestion ;)]
>
> Alexis.
>
I don't see the problem. Also, in this case I see only one extra hunk.
But once we have proper tools (like git) we can revisit this.
I don't think there is currently any guideline in devmanual that
recommends not mixing functional changes with cosmetics.
--
Cheers,
Ben | yngwin
Gentoo developer
Gentoo Qt project lead, Gentoo Wiki admin
--001a11c2e9aa381e1f04daf1d178
Content-Type: text/html; charset=UTF-8
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 April 2013 23:05, Alexis Ballier <span dir="ltr"><<a href="mailto:aballier@gentoo.org" target="_blank">aballier@gentoo.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Sun, 21 Apr 2013 20:53:28 +0800<br>
Ben de Groot <<a href="mailto:yngwin@gentoo.org">yngwin@gentoo.org</a>> wrote:<br>
> ><br>
</div><div class="im">> > PS: btw, some hunks are weird in your commit, a locale issue ?<br>
> ><br>
><br>
> No, just a line in my vimrc that removes trailing whitespace.<br>
><br>
<br>
</div>You should probably disable it or remove trailing whitespaces in a<br>
separate commit though. Having functional changes mixed with<br>
whitespace/cosmetics in a single commit makes it hard to read<br>
and understand.<br>
<br>
[This is really a nitpick, no need to have a debate, it's only a<br>
suggestion ;)]<br>
<span class="HOEnZb"><font color="#888888"><br>
Alexis.<br>
</font></span></blockquote></div><br></div><div class="gmail_extra">I don't see the problem. Also, in this case I see only one extra hunk.<br></div><div class="gmail_extra">But once we have proper tools (like git) we can revisit this.<br>
</div><div class="gmail_extra">I don't think there is currently any guideline in devmanual that<br>recommends not mixing functional changes with cosmetics.<br clear="all"></div><div class="gmail_extra"><br>-- <br>Cheers,<br>
<br>Ben | yngwin<br>Gentoo developer<br>Gentoo Qt project lead, Gentoo Wiki admin
</div></div>
--001a11c2e9aa381e1f04daf1d178--