On 21 April 2013 23:05, Alexis Ballier <aballier@gentoo.org> wrote:

> On Sun, 21 Apr 2013 20:53:28 +0800
> Ben de Groot <yngwin@gentoo.org> wrote:
> > >
> > > PS: btw, some hunks are weird in your commit, a locale issue ?
> > >
> >
> > No, just a line in my vimrc that removes trailing whitespace.
> >
>
> You should probably disable it or remove trailing whitespaces in a
> separate commit though. Having functional changes mixed with
> whitespace/cosmetics in a single commit makes it hard to read
> and understand.
>
> [This is really a nitpick, no need to have a debate, it's only a
> suggestion ;)]
>
> Alexis.
>

I don't see the problem. Also, in this case I see only one extra hunk.
But once we have proper tools (like git) we can revisit this.
I don't think there is currently any guideline in devmanual that
recommends not mixing functional changes with cosmetics.

-- 
Cheers,

Ben | yngwin
Gentoo developer
Gentoo Qt project lead, Gentoo Wiki admin