From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-59344-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 68983138010
	for <garchives@archives.gentoo.org>; Wed, 27 Mar 2013 15:22:48 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 6CF50E0A7D;
	Wed, 27 Mar 2013 15:22:14 +0000 (UTC)
Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 8C144E0A70
	for <gentoo-dev@lists.gentoo.org>; Wed, 27 Mar 2013 15:22:13 +0000 (UTC)
Received: by mail-ve0-f180.google.com with SMTP id c13so4866238vea.25
        for <gentoo-dev@lists.gentoo.org>; Wed, 27 Mar 2013 08:22:12 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:x-received:sender:x-originating-ip:in-reply-to
         :references:date:x-google-sender-auth:message-id:subject:from:to
         :content-type:content-transfer-encoding:x-gm-message-state;
        bh=R+SxSA0fYxI2JJbTV4Dp4LwRiVQpJg5ynLGAFeivAtU=;
        b=DoP6F68ynibmoVmRq1xOsKsiIS+1amdR6rkuqIPF+ji14a6mcBwoR2IOBiCTiYaO5d
         WrqeasPPVwysLmy8Py5QsCTi5z4ylnuX12+WewtjWhWahZiUNkXdffRdeEM31FPMoEHG
         oDuO5BeG8e++1GGTO6RkW1h+bAWtmltDyf6bzFnn9b2kgJqY6jvDz9mm2C1Wj8elvrUt
         vZxCFqrIopL0oVGHqtQUwCxarOgSZP06qcqmyPBU65+QQ/TAVNbMdm2OZGekuJQv2T5C
         ikSBxyz66LYVB9x+B/uZ6HtXrCk2kfFZfNyOuYeNNOMJtIw4q6bbT4zovR1NHsKEdrb9
         NMRA==
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
X-Received: by 10.58.154.229 with SMTP id vr5mr23884743veb.11.1364397732357;
 Wed, 27 Mar 2013 08:22:12 -0700 (PDT)
Sender: antarus@scriptkitty.com
Received: by 10.220.209.5 with HTTP; Wed, 27 Mar 2013 08:22:12 -0700 (PDT)
X-Originating-IP: [75.147.136.182]
In-Reply-To: <1364387960.24497.6.camel@gilles.gandi.net>
References: <5145B4B9.3070104@gentoo.org>
	<514F9840.7030204@gentoo.org>
	<1364387960.24497.6.camel@gilles.gandi.net>
Date: Wed, 27 Mar 2013 08:22:12 -0700
X-Google-Sender-Auth: c80BzjF2dPV6ukQzuVnrafk_6m0
Message-ID: <CAAr7Pr_y3VNtmRHRK0sY0Jsaw5VEUwGy-D0WYOXsPrx2RAxdZA@mail.gmail.com>
Subject: Re: [gentoo-dev] Proposed update to pax-utils.eclass
From: Alec Warner <antarus@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Gm-Message-State: ALoCoQn2F39N8441AXBe4HJKvdMC5UkuhJSbh/8apnnYYo2QgdMrgcxclFDXBrq0fmZMPZ3ZQKK/
X-Archives-Salt: 5694293c-fad9-4df7-b167-32fb1b03693a
X-Archives-Hash: d33de6119e857a3239dde61ec102041a

On Wed, Mar 27, 2013 at 5:39 AM, Gilles Dartiguelongue <eva@gentoo.org> wro=
te:
> Le dimanche 24 mars 2013 =C3=A0 20:20 -0400, Anthony G. Basile a =C3=A9cr=
it :
>> Last call, does anyone have a problem with me updating the
>> pax-utils.eclass?  See Ref [3] above for the code.  I'll wait a couple
>> more days and then do it.
>
> looks like last conditional branch for XT marking in pax-mark function
> is not using the proper variables (pt_* instead ot xt_*).
>
> The PAX_MARKINGS variable is not documented with eclass documentation
> markup, it should at least get an "@INTERNAL" if this is not supposed to
> be modified by eclass users.
>
> _pax_list_files can receive documentation this way as well.
>
> You should probably try to avoid mixing [[ ]] and [ ] in the eclass. [ ]
> seems to be less used here so just have everything [[ ]] and drop the
> useless quoting that came with [ ].

You should never use [ in the tree.

-A

>
> The rest looks fine.
>
> --
> Gilles Dartiguelongue <eva@gentoo.org>
> Gentoo
>
>