From: Alec Warner <antarus@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Proposed update to pax-utils.eclass
Date: Wed, 27 Mar 2013 08:22:12 -0700 [thread overview]
Message-ID: <CAAr7Pr_y3VNtmRHRK0sY0Jsaw5VEUwGy-D0WYOXsPrx2RAxdZA@mail.gmail.com> (raw)
In-Reply-To: <1364387960.24497.6.camel@gilles.gandi.net>
On Wed, Mar 27, 2013 at 5:39 AM, Gilles Dartiguelongue <eva@gentoo.org> wrote:
> Le dimanche 24 mars 2013 à 20:20 -0400, Anthony G. Basile a écrit :
>> Last call, does anyone have a problem with me updating the
>> pax-utils.eclass? See Ref [3] above for the code. I'll wait a couple
>> more days and then do it.
>
> looks like last conditional branch for XT marking in pax-mark function
> is not using the proper variables (pt_* instead ot xt_*).
>
> The PAX_MARKINGS variable is not documented with eclass documentation
> markup, it should at least get an "@INTERNAL" if this is not supposed to
> be modified by eclass users.
>
> _pax_list_files can receive documentation this way as well.
>
> You should probably try to avoid mixing [[ ]] and [ ] in the eclass. [ ]
> seems to be less used here so just have everything [[ ]] and drop the
> useless quoting that came with [ ].
You should never use [ in the tree.
-A
>
> The rest looks fine.
>
> --
> Gilles Dartiguelongue <eva@gentoo.org>
> Gentoo
>
>
prev parent reply other threads:[~2013-03-27 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 12:19 [gentoo-dev] Proposed update to pax-utils.eclass Anthony G. Basile
2013-03-25 0:20 ` Anthony G. Basile
2013-03-27 12:39 ` Gilles Dartiguelongue
2013-03-27 15:22 ` Alec Warner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAr7Pr_y3VNtmRHRK0sY0Jsaw5VEUwGy-D0WYOXsPrx2RAxdZA@mail.gmail.com \
--to=antarus@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox